All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
	linux-kselftest@vger.kernel.org
Subject: Re: [bug report] selftests/tls: add a test for fragmented messages
Date: Tue, 7 Jan 2020 10:14:02 -0800	[thread overview]
Message-ID: <202001071013.1AE709474@keescook> (raw)
In-Reply-To: <20200107140106.ejj4zgeiu4fauatn@kili.mountain>

On Tue, Jan 07, 2020 at 05:01:06PM +0300, Dan Carpenter wrote:
>    621  } while (0); OPTIONAL_HANDLER(_assert)
>         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> The problem is the OPTIONAL_HANDLER().  Smatch thinks it should be
> included inside the do {} while(0) loop.

It looks weird, but it is intentional. :)

-- 
Kees Cook

      reply	other threads:[~2020-01-07 18:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 14:01 [bug report] selftests/tls: add a test for fragmented messages Dan Carpenter
2020-01-07 18:14 ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202001071013.1AE709474@keescook \
    --to=keescook@chromium.org \
    --cc=dan.carpenter@oracle.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.