From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C5FC33C8C for ; Tue, 7 Jan 2020 14:20:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A048F208C4 for ; Tue, 7 Jan 2020 14:20:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A048F208C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4486489FE8; Tue, 7 Jan 2020 14:20:51 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 66EA189FE8 for ; Tue, 7 Jan 2020 14:20:49 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2020 06:20:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,406,1571727600"; d="scan'208";a="271532898" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 07 Jan 2020 06:20:46 -0800 Received: by stinkbox (sSMTP sendmail emulation); Tue, 07 Jan 2020 16:20:45 +0200 Date: Tue, 7 Jan 2020 16:20:45 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Lucas De Marchi Message-ID: <20200107142045.GE1208@intel.com> References: <20190306131957.GC3888@intel.com> <20190308232321.30168-1-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: remove ICP_PP_CONTROL X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics , Lucas De Marchi Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Jan 02, 2020 at 03:44:38PM -0800, Lucas De Marchi wrote: > Today I saw this register and had a vague memory of having already > removed it in the past. > It seems this patch has never been reviewed/applied. > = > Ping Reviewed-by: Ville Syrj=E4l=E4 > = > Lucas De Marchi > = > On Fri, Mar 8, 2019 at 3:23 PM Lucas De Marchi = wrote: > > > > This register was placed in the middle of the PP_STATUS definition > > instead of together with the PP_CONTROL where it should. Since it's not > > used and there are no current plans to use it, just remove the > > definition. > > > > v2: remove the define rather than moving it. > > > > Signed-off-by: Lucas De Marchi > > --- > > drivers/gpu/drm/i915/i915_reg.h | 11 ----------- > > 1 file changed, 11 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i91= 5_reg.h > > index c0cd7a836799..4a855befa838 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@ -4692,17 +4692,6 @@ enum { > > #define _PP_STATUS 0x61200 > > #define PP_STATUS(pps_idx) _MMIO_PPS(pps_idx, _PP_STATUS) > > #define PP_ON (1 << 31) > > - > > -#define _PP_CONTROL_1 0xc7204 > > -#define _PP_CONTROL_2 0xc7304 > > -#define ICP_PP_CONTROL(x) _MMIO(((x) =3D=3D 1) ? _PP_CONT= ROL_1 : \ > > - _PP_CONTROL_2) > > -#define POWER_CYCLE_DELAY_MASK (0x1f << 4) > > -#define POWER_CYCLE_DELAY_SHIFT 4 > > -#define VDD_OVERRIDE_FORCE (1 << 3) > > -#define BACKLIGHT_ENABLE (1 << 2) > > -#define PWR_DOWN_ON_RESET (1 << 1) > > -#define PWR_STATE_TARGET (1 << 0) > > /* > > * Indicates that all dependencies of the panel are on: > > * > > -- > > 2.20.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > = > = > -- = > Lucas De Marchi -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx