From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Theodore Y. Ts'o" Subject: Re: [PATCH v3 1/8] random: Don't wake crng_init_wait when crng_init == 1 Date: Tue, 7 Jan 2020 15:42:50 -0500 Message-ID: <20200107204250.GF3619@mit.edu> References: <6fbc0bfcbfc1fa2c76fd574f5b6f552b11be7fde.1577088521.git.luto@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <6fbc0bfcbfc1fa2c76fd574f5b6f552b11be7fde.1577088521.git.luto@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Andy Lutomirski Cc: LKML , Linux API , Kees Cook , "Jason A. Donenfeld" , "Ahmed S. Darwish" , Lennart Poettering , "Eric W. Biederman" , "Alexander E. Patrakov" , Michael Kerrisk , Willy Tarreau , Matthew Garrett , Ext4 Developers List , linux-man , Stephan Mueller List-Id: linux-api@vger.kernel.org On Mon, Dec 23, 2019 at 12:20:44AM -0800, Andy Lutomirski wrote: > crng_init_wait is only used to wayt for crng_init to be set to 2, so > there's no point to waking it when crng_init is set to 1. Remove the > unnecessary wake_up_interruptible() call. > > Signed-off-by: Andy Lutomirski Applied with a spelling fix ("wayt->wait"). - Ted