From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Theodore Y. Ts'o" Subject: Re: [PATCH v3 2/8] random: Add a urandom_read_nowait() for random APIs that don't warn Date: Tue, 7 Jan 2020 15:43:32 -0500 Message-ID: <20200107204332.GG3619@mit.edu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Lutomirski Cc: LKML , Linux API , Kees Cook , "Jason A. Donenfeld" , "Ahmed S. Darwish" , Lennart Poettering , "Eric W. Biederman" , "Alexander E. Patrakov" , Michael Kerrisk , Willy Tarreau , Matthew Garrett , Ext4 Developers List , linux-man , Stephan Mueller List-Id: linux-api@vger.kernel.org On Mon, Dec 23, 2019 at 12:20:45AM -0800, Andy Lutomirski wrote: > /dev/random and getrandom() never warn. Split the meat of > urandom_read() into urandom_read_nowarn() and leave the warning code > in urandom_read(). > > This has no effect on kernel behavior, but it makes subsequent > patches more straightforward. It also makes the fact that > getrandom() never warns more obvious. > > Signed-off-by: Andy Lutomirski Applied, thanks. - Ted