From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D66C282DD for ; Tue, 7 Jan 2020 21:28:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECC172080A for ; Tue, 7 Jan 2020 21:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578432481; bh=5iePZfUEZunjoNLkBaYgCmYBqwNYY481W0P0hx6+A4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=dM+E/fC0F2AheztQRJtnRrE5sWezMom/y94+EmURfry6GOcWHtykvwWAt5R1RqBcM RqMT+DmO5PlxW07GWtvTLCyaKMVl4jLU7TgT6MyTDejBlKfsECwIQC7na1aOl26x0L /CxIQkwkEg77pLyV9o+Ri0mnL01lowiniVfX9aos= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727490AbgAGU5M (ORCPT ); Tue, 7 Jan 2020 15:57:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:53582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727419AbgAGU5G (ORCPT ); Tue, 7 Jan 2020 15:57:06 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65879214D8; Tue, 7 Jan 2020 20:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578430625; bh=5iePZfUEZunjoNLkBaYgCmYBqwNYY481W0P0hx6+A4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ljR5s1GvS/hQADxzCNqX20sdPlGEh5TZ/N+Y6Z9RyOO/nxCtixP6/9tgvdYpmYCAG mLRQOfMs7Du8/hvnUkcC/vLgllU4d/ZD/eWLFu60o81ru2o8B/422JY4UiGsUdsj3p gn+oAAMa64OIXRj4S8KqE3dl5LW/JbU11VLlOtSw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Himanshu Madhani , Quinn Tran , Hannes Reinecke , Roman Bolshakov , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 030/191] scsi: qla2xxx: Dont defer relogin unconditonally Date: Tue, 7 Jan 2020 21:52:30 +0100 Message-Id: <20200107205334.613230532@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200107205332.984228665@linuxfoundation.org> References: <20200107205332.984228665@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roman Bolshakov [ Upstream commit dabc5ec915f3a2c657ecfb529cd3d4ec303a4412 ] qla2x00_configure_local_loop sets RELOGIN_NEEDED bit and calls qla24xx_fcport_handle_login to perform the login. This bit triggers a wake up of DPC later after a successful login. The deferred call is not needed if login succeeds, and it's set in qla24xx_fcport_handle_login in case of errors, hence it should be safe to drop. Link: https://lore.kernel.org/r/20191125165702.1013-12-r.bolshakov@yadro.com Acked-by: Himanshu Madhani Acked-by: Quinn Tran Reviewed-by: Hannes Reinecke Tested-by: Hannes Reinecke Signed-off-by: Roman Bolshakov Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 4e424f1ce5de..80f276d67c14 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -5045,7 +5045,6 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha) memcpy(&ha->plogi_els_payld.data, (void *)ha->init_cb, sizeof(ha->plogi_els_payld.data)); - set_bit(RELOGIN_NEEDED, &vha->dpc_flags); } else { ql_dbg(ql_dbg_init, vha, 0x00d1, "PLOGI ELS param read fail.\n"); -- 2.20.1