From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B54FC33C9E for ; Tue, 7 Jan 2020 21:08:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1A8724672 for ; Tue, 7 Jan 2020 21:08:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eD+UKFCU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1A8724672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qml0urjrjQhuXCJ+xx5sZMIOi+IbLulbDgYWJsRjRME=; b=eD+UKFCUo572nw JPczZQVdTWfbSOZEHN/jEfuySvn47AsdxsXHxRpHoCPMlcP0yeHY+F1S43C5b5EN4ejkzPP+06iCR uo/m0vgsuuCyfDaaygV8QRih4x/JdN4it5/Feww7S3Vk7oxQZW5zVuxGB1HknLo6rR+kcsxkQ+Ac6 BmCW7gvoEYh+cPAntR3P5rMfQXdCzNCCoBFZOuYe2albg+qxO86FD4zDgyR8SVFO8Wa61ApN/U78a b+E1blnooRrtjGetFc6zwrwiOctSBY6mZ0NOlEw8upfT9BNb8pPEJz0+YF4LQ4PhBTuVKVYQiHVvl c3/alVYdi+NFEgNTvYAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iow5W-0006aR-NP; Tue, 07 Jan 2020 21:08:30 +0000 Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iow5T-0006ZX-MA for linux-arm-kernel@lists.infradead.org; Tue, 07 Jan 2020 21:08:29 +0000 Received: from callcc.thunk.org (guestnat-104-133-0-111.corp.google.com [104.133.0.111] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 007L7OUj026037 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 7 Jan 2020 16:07:27 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id BA95E4207DF; Tue, 7 Jan 2020 16:07:24 -0500 (EST) Date: Tue, 7 Jan 2020 16:07:24 -0500 From: "Theodore Y. Ts'o" To: Qian Cai Subject: Re: [PATCH] char/random: silence a lockdep splat with printk() Message-ID: <20200107210724.GN3619@mit.edu> References: <1573679785-21068-1-git-send-email-cai@lca.pw> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1573679785-21068-1-git-send-email-cai@lca.pw> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200107_130827_890292_D87797B0 X-CRM114-Status: UNSURE ( 7.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmladek@suse.com, sergey.senozhatsky.work@gmail.com, arnd@arndb.de, peterz@infradead.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, longman@redhat.com, dan.j.williams@intel.com, will@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 13, 2019 at 04:16:25PM -0500, Qian Cai wrote: > From: Sergey Senozhatsky > > Sergey didn't like the locking order, > > uart_port->lock -> tty_port->lock > > uart_write (uart_port->lock) > __uart_start > pl011_start_tx > pl011_tx_chars > uart_write_wakeup > tty_port_tty_wakeup > tty_port_default > tty_port_tty_get (tty_port->lock) > > but those code is so old, and I have no clue how to de-couple it after > checking other locks in the splat. There is an onging effort to make all > printk() as deferred, so until that happens, workaround it for now as a > short-term fix. Applied, thanks. - Ted _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C815C33C9E for ; Tue, 7 Jan 2020 21:08:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 663E8214D8 for ; Tue, 7 Jan 2020 21:08:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 663E8214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 186068E000B; Tue, 7 Jan 2020 16:08:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 135558E0007; Tue, 7 Jan 2020 16:08:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 073018E000B; Tue, 7 Jan 2020 16:08:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id E82648E0007 for ; Tue, 7 Jan 2020 16:08:11 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id ACB9F6100 for ; Tue, 7 Jan 2020 21:08:11 +0000 (UTC) X-FDA: 76352075982.04.paint64_2a54748227d5d X-HE-Tag: paint64_2a54748227d5d X-Filterd-Recvd-Size: 2227 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jan 2020 21:08:10 +0000 (UTC) Received: from callcc.thunk.org (guestnat-104-133-0-111.corp.google.com [104.133.0.111] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 007L7OUj026037 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 7 Jan 2020 16:07:27 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id BA95E4207DF; Tue, 7 Jan 2020 16:07:24 -0500 (EST) Date: Tue, 7 Jan 2020 16:07:24 -0500 From: "Theodore Y. Ts'o" To: Qian Cai Cc: arnd@arndb.de, gregkh@linuxfoundation.org, sergey.senozhatsky.work@gmail.com, pmladek@suse.com, rostedt@goodmis.org, catalin.marinas@arm.com, will@kernel.org, dan.j.williams@intel.com, peterz@infradead.org, longman@redhat.com, tglx@linutronix.de, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] char/random: silence a lockdep splat with printk() Message-ID: <20200107210724.GN3619@mit.edu> References: <1573679785-21068-1-git-send-email-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1573679785-21068-1-git-send-email-cai@lca.pw> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 13, 2019 at 04:16:25PM -0500, Qian Cai wrote: > From: Sergey Senozhatsky > > Sergey didn't like the locking order, > > uart_port->lock -> tty_port->lock > > uart_write (uart_port->lock) > __uart_start > pl011_start_tx > pl011_tx_chars > uart_write_wakeup > tty_port_tty_wakeup > tty_port_default > tty_port_tty_get (tty_port->lock) > > but those code is so old, and I have no clue how to de-couple it after > checking other locks in the splat. There is an onging effort to make all > printk() as deferred, so until that happens, workaround it for now as a > short-term fix. Applied, thanks. - Ted