All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/coreutils: drop useless patch
Date: Tue, 7 Jan 2020 21:23:02 +0100	[thread overview]
Message-ID: <20200107212302.56f1842c@windsurf> (raw)
In-Reply-To: <20200106212336.7411-1-yann.morin.1998@free.fr>

On Mon,  6 Jan 2020 22:23:36 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Until version 8.23, we needed to patch coreutils to ensure that options
> be passed before non-options when calling help2man (during the build).
> Our patch would just swap around two consecutive lines, and required
> autoreconfguring and gettextising.
> 
> However, in coreutils 8.24, upstream applied a semantically equivalent
> fix, but we did not notice, and we blindly fixed the patch by swapping
> the previously faulty lines, even though the issue was no longer present
> to begin with (if one would need an example of cargo cult, this is it).
> 
> Drop our patch, as it has not been needed for the past 4.5 years.
> 
> This means that we can also stop autoreconfiguring and gettextising.
> Woot!
> 
> Rename the remaining patch.
> 
> Reported-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  .../0001-fix-for-dummy-man-usage.patch        | 25 -------------------
>  ... 0001-strtod_fix_clash_with_strtold.patch} |  0
>  package/coreutils/coreutils.mk                |  4 ---
>  3 files changed, 29 deletions(-)
>  delete mode 100644 package/coreutils/0001-fix-for-dummy-man-usage.patch
>  rename package/coreutils/{0002-strtod_fix_clash_with_strtold.patch => 0001-strtod_fix_clash_with_strtold.patch} (100%)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2020-01-07 20:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 21:23 [Buildroot] [PATCH] package/coreutils: drop useless patch Yann E. MORIN
2020-01-07 20:23 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200107212302.56f1842c@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.