From: Christoph Hellwig <hch@infradead.org>
To: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <damien.lemoal@wdc.com>
Subject: Re: [PATCH] block: streamline merge possibility checks
Date: Wed, 8 Jan 2020 05:41:19 -0800 [thread overview]
Message-ID: <20200108134119.GE4455@infradead.org> (raw)
In-Reply-To: <20191218194156.29430-1-dmitry.fomichev@wdc.com>
On Wed, Dec 18, 2019 at 02:41:56PM -0500, Dmitry Fomichev wrote:
> Checks for data direction in attempt_merge() and blk_rq_merge_ok()
> are redundant and will always succeed when the both I/O request
> operations are equal. Therefore, remove them.
>
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-01-08 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 19:41 [PATCH] block: streamline merge possibility checks Dmitry Fomichev
2019-12-19 8:56 ` Bob Liu
2019-12-19 10:05 ` Damien Le Moal
2019-12-20 6:50 ` Bob Liu
2020-01-08 13:44 ` Christoph Hellwig
2020-01-08 22:02 ` Dmitry Fomichev
2020-01-09 0:56 ` Bob Liu
2020-01-08 13:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108134119.GE4455@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dmitry.fomichev@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.