From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8130BC33CA2 for ; Wed, 8 Jan 2020 20:38:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DFB920692 for ; Wed, 8 Jan 2020 20:38:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aOQvAVQg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DFB920692 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8aA05wppNfosiOfooAyYJy46w2WgVRVqcRb1uB+fw2Y=; b=aOQvAVQg1ZuHw6 Tx/suyhe16bv3UR7IxIZQjsSqHWaCN+NFp0J/PavTqoiPV4MgnZ+5iwwQwa2zJ/FRZLvnXjR8g4wp q4Rn/o16B8AmffhrpxuAdAUyzEWmo6MzMJqkeBojGZQmPU0+hwOETz5iMrBrEKwwa8vpdvxUT0IRm VQ2cQDeC7bRXCSyOd+q3Stu4HkQiqO4ppl/CKN91fw4ZwONgOFpCGSOXMlSlMon4T84FmlK51pYJB vX6ydwvLzc0OAZf2mJGHfVDQ1SDWCb4cPm0jCeDedi1KrM1ikMYGgBFluo/SMAmlyv/BnAkfrOSKv PNo55WYOQNjwdNYC1d5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipI68-0000XI-R6; Wed, 08 Jan 2020 20:38:36 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipI65-0000Vy-Ev for linux-mediatek@lists.infradead.org; Wed, 08 Jan 2020 20:38:35 +0000 Received: by mail-ot1-f67.google.com with SMTP id k14so4930212otn.4 for ; Wed, 08 Jan 2020 12:38:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fYbMCE8GKhztIwg7FUhSFbp5MPOuXQT9UONOLwZL9bI=; b=bhclZE0y+FZSejoRc1K0uEa1FvUYrd6O41Cj6n2SaOjl1ayqrUQnQ9meUTOEBQSOjW agSGQ1zb7M1i/UiflDN2VXPI2UMHq6xvSkMXgreWmkETaS3d0Hl4V8C+Y3jQEjYRgLfa JV+B9tCRBUQVmv3+EP78I0p77+uJPzcNS/IJQbSfgavrKv0rFxDz6qgWUS4DmXFCvbbu rW5zBW16F03ZEnkOhH8jwP6qubVt+odIEJPDphR/TnnhV7NlUed6cvLGtxqJQ2mVtjmJ LHgFqDsGEA6HCPsn6TtZfUwgE/6cyF81Ggq+a6HjHwaTp/QQUVJRv5dQNK+F00T1qzaf 84gQ== X-Gm-Message-State: APjAAAUZYLPrkMquL1ksAq7YsTy8QD5NwnpTMGvkEXa0ZyDVwfn4dQ5M 4X0VL5aQdJ+iOHgNp8/dEQuxNXQ= X-Google-Smtp-Source: APXvYqyG/G8qEbzrqhTiAlpsfp+n+TJN6Wm4MpscbCc94Yw9lBw8Ik5UT0cUtMXgBTsABZhLINhiJQ== X-Received: by 2002:a05:6830:13d9:: with SMTP id e25mr5511371otq.134.1578515911743; Wed, 08 Jan 2020 12:38:31 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 47sm1524253otf.54.2020.01.08.12.38.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2020 12:38:30 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 220333 by rob-hp-laptop (DragonFly Mail Agent v0.11); Wed, 08 Jan 2020 14:38:29 -0600 Date: Wed, 8 Jan 2020 14:38:29 -0600 From: Rob Herring To: Roger Lu Subject: Re: [PATCH v6 1/3] dt-bindings: soc: add mtk svs dt-bindings Message-ID: <20200108203829.GA18987@bogus> References: <20200107070154.1574-1-roger.lu@mediatek.com> <20200107070154.1574-2-roger.lu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200107070154.1574-2-roger.lu@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200108_123833_495923_F87C56B3 X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Angus Lin , Kevin Hilman , Stephen Boyd , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, HenryC Chen , YT Lee , Fan Chen , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Xiaoqing Liu , Charles Yang , Matthias Brugger , Nishanth Menon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Jan 07, 2020 at 03:01:52PM +0800, Roger Lu wrote: > Document the binding for enabling mtk svs on MediaTek SoC. > > Signed-off-by: Roger Lu > --- > .../devicetree/bindings/power/mtk-svs.txt | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/mtk-svs.txt > > diff --git a/Documentation/devicetree/bindings/power/mtk-svs.txt b/Documentation/devicetree/bindings/power/mtk-svs.txt > new file mode 100644 > index 000000000000..9a3e81b9e1d2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/mtk-svs.txt > @@ -0,0 +1,76 @@ > +* Mediatek Smart Voltage Scaling (MTK SVS) > + > +This describes the device tree binding for the MTK SVS controller (bank) > +which helps provide the optimized CPU/GPU/CCI voltages. This device also > +needs thermal data to calculate thermal slope for accurately compensate > +the voltages when temperature change. > + > +Required properties: > +- compatible: > + - "mediatek,mt8183-svs" : For MT8183 family of SoCs > +- reg: Address range of the MTK SVS controller. > +- interrupts: IRQ for the MTK SVS controller. > +- clocks, clock-names: Clocks needed for the svs hardware. required > + clocks are: > + "main": Main clock for svs controller to work. > +- nvmem-cells: Phandle to the calibration data provided by a nvmem device. > +- nvmem-cell-names: Should be "svs-calibration-data" and "calibration-data" > + > +Subnodes: > +- svs-cpu-little: SVS bank device node of little CPU > + compatible: "mediatek,mt8183-svs-cpu-little" > + operating-points-v2: OPP table hooked by SVS little CPU bank. > + SVS will optimze this OPP table voltage part. > + vcpu-little-supply: PMIC buck of little CPU > +- svs-cpu-big: SVS bank device node of big CPU > + compatible: "mediatek,mt8183-svs-cpu-big" > + operating-points-v2: OPP table hooked by SVS big CPU bank. > + SVS will optimze this OPP table voltage part. > + vcpu-big-supply: PMIC buck of big CPU > +- svs-cci: SVS bank device node of CCI > + compatible: "mediatek,mt8183-svs-cci" > + operating-points-v2: OPP table hooked by SVS CCI bank. > + SVS will optimze this OPP table voltage part. > + vcci-supply: PMIC buck of CCI > +- svs-gpu: SVS bank device node of GPU > + compatible: "mediatek,mt8183-svs-gpu" > + operating-points-v2: OPP table hooked by SVS GPU bank. > + SVS will optimze this OPP table voltage part. > + vgpu-supply: PMIC buck of GPU > + > +Example: > + > + svs: svs@1100b000 { > + compatible = "mediatek,mt8183-svs"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = ; > + clocks = <&infracfg CLK_INFRA_THERM>; > + clock-names = "main_clk"; > + nvmem-cells = <&svs_calibration>, <&thermal_calibration>; > + nvmem-cell-names = "svs-calibration-data", "calibration-data"; > + > + svs_cpu_little: svs-cpu-little { > + compatible = "mediatek,mt8183-svs-cpu-little"; > + operating-points-v2 = <&cluster0_opp>; > + vcpu-little-supply = <&mt6358_vproc12_reg>; > + }; I don't think this is a good binding. This information already exists elsewhere in the DT, so your driver should just look in those nodes. For example the regulator can be in the cpu nodes or the OPP table itself. Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C14ABC282DD for ; Wed, 8 Jan 2020 20:38:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83D9E2070E for ; Wed, 8 Jan 2020 20:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578515913; bh=xfWnOd0ixEmSnzOZ2K1ZrN99iyNkxjXxN6XgVWk9nCY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=EkHiYti8fi9Bebz+FjY32zLNgdlz1VTTowY7oJeARxZNqNbMdhDzVbk+T7wRU0Axh RRUMhpeacXKUgNV9vu2RuELxnpUOFhTyVu/M4UiIRvm7T7+rFNYkvpcGSYw/dlz5PA HbRLUMXFOUVLb0bMEwXQV27q37W67Ue0SkrV4Ty4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726437AbgAHUid (ORCPT ); Wed, 8 Jan 2020 15:38:33 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:42149 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbgAHUic (ORCPT ); Wed, 8 Jan 2020 15:38:32 -0500 Received: by mail-ot1-f66.google.com with SMTP id 66so4909476otd.9 for ; Wed, 08 Jan 2020 12:38:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fYbMCE8GKhztIwg7FUhSFbp5MPOuXQT9UONOLwZL9bI=; b=EA/yAFRJdOsf35CMdZHcTQrza/QoIuOcsZDmpjX6mvA+wa5iGfr1BaA4KdKHBeXdG1 HzdOvPh7OoSgXhhRnPdROqDY3I9CIIVQnuoXCwPDGx7mmQV9qCN3sdxpvFXzFAVQD3nk WjuQssLOT4vCHcgs651DyWNAuXXD7b+arn5h9o8LzxAoDT3Jz3y4FzZxD3ra5xVToeVW 6NXvzp2E06Eiz/o+RIY/aHLaiJodhvXp+Qzp/6m/WYfc3YIO0QR3dEEYlNxb1PqbzE/W wwTz8eDH7umPX1ktDihmSxTh5BCLFkG6xXwVUcv0aa+WPM9wpNJd/Iz9dq8QPZ/2OQbO Ga+A== X-Gm-Message-State: APjAAAUuVcTFCnMEsUH7cz4ZhZ0lz+JUL89pK/lm+7p50jm6/Pq7us13 cF0xsLgJBBWlVebJ0sT/dS6WuvI= X-Google-Smtp-Source: APXvYqzOyENdRNnY3lEhmdWEYVndriUZIFUq8OJ92Mgv6h2GiSMeDuShx00aqhCAgUHJpyon+BYKTw== X-Received: by 2002:a9d:1c95:: with SMTP id l21mr5535426ota.271.1578515911493; Wed, 08 Jan 2020 12:38:31 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id n25sm1428128oic.6.2020.01.08.12.38.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2020 12:38:30 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 220333 by rob-hp-laptop (DragonFly Mail Agent v0.11); Wed, 08 Jan 2020 14:38:29 -0600 Date: Wed, 8 Jan 2020 14:38:29 -0600 From: Rob Herring To: Roger Lu Cc: Kevin Hilman , Nicolas Boichat , Stephen Boyd , Fan Chen , HenryC Chen , YT Lee , Xiaoqing Liu , Charles Yang , Angus Lin , Mark Rutland , Matthias Brugger , Nishanth Menon , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v6 1/3] dt-bindings: soc: add mtk svs dt-bindings Message-ID: <20200108203829.GA18987@bogus> References: <20200107070154.1574-1-roger.lu@mediatek.com> <20200107070154.1574-2-roger.lu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200107070154.1574-2-roger.lu@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Jan 07, 2020 at 03:01:52PM +0800, Roger Lu wrote: > Document the binding for enabling mtk svs on MediaTek SoC. > > Signed-off-by: Roger Lu > --- > .../devicetree/bindings/power/mtk-svs.txt | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/mtk-svs.txt > > diff --git a/Documentation/devicetree/bindings/power/mtk-svs.txt b/Documentation/devicetree/bindings/power/mtk-svs.txt > new file mode 100644 > index 000000000000..9a3e81b9e1d2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/mtk-svs.txt > @@ -0,0 +1,76 @@ > +* Mediatek Smart Voltage Scaling (MTK SVS) > + > +This describes the device tree binding for the MTK SVS controller (bank) > +which helps provide the optimized CPU/GPU/CCI voltages. This device also > +needs thermal data to calculate thermal slope for accurately compensate > +the voltages when temperature change. > + > +Required properties: > +- compatible: > + - "mediatek,mt8183-svs" : For MT8183 family of SoCs > +- reg: Address range of the MTK SVS controller. > +- interrupts: IRQ for the MTK SVS controller. > +- clocks, clock-names: Clocks needed for the svs hardware. required > + clocks are: > + "main": Main clock for svs controller to work. > +- nvmem-cells: Phandle to the calibration data provided by a nvmem device. > +- nvmem-cell-names: Should be "svs-calibration-data" and "calibration-data" > + > +Subnodes: > +- svs-cpu-little: SVS bank device node of little CPU > + compatible: "mediatek,mt8183-svs-cpu-little" > + operating-points-v2: OPP table hooked by SVS little CPU bank. > + SVS will optimze this OPP table voltage part. > + vcpu-little-supply: PMIC buck of little CPU > +- svs-cpu-big: SVS bank device node of big CPU > + compatible: "mediatek,mt8183-svs-cpu-big" > + operating-points-v2: OPP table hooked by SVS big CPU bank. > + SVS will optimze this OPP table voltage part. > + vcpu-big-supply: PMIC buck of big CPU > +- svs-cci: SVS bank device node of CCI > + compatible: "mediatek,mt8183-svs-cci" > + operating-points-v2: OPP table hooked by SVS CCI bank. > + SVS will optimze this OPP table voltage part. > + vcci-supply: PMIC buck of CCI > +- svs-gpu: SVS bank device node of GPU > + compatible: "mediatek,mt8183-svs-gpu" > + operating-points-v2: OPP table hooked by SVS GPU bank. > + SVS will optimze this OPP table voltage part. > + vgpu-supply: PMIC buck of GPU > + > +Example: > + > + svs: svs@1100b000 { > + compatible = "mediatek,mt8183-svs"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = ; > + clocks = <&infracfg CLK_INFRA_THERM>; > + clock-names = "main_clk"; > + nvmem-cells = <&svs_calibration>, <&thermal_calibration>; > + nvmem-cell-names = "svs-calibration-data", "calibration-data"; > + > + svs_cpu_little: svs-cpu-little { > + compatible = "mediatek,mt8183-svs-cpu-little"; > + operating-points-v2 = <&cluster0_opp>; > + vcpu-little-supply = <&mt6358_vproc12_reg>; > + }; I don't think this is a good binding. This information already exists elsewhere in the DT, so your driver should just look in those nodes. For example the regulator can be in the cpu nodes or the OPP table itself. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFC4C282DD for ; Wed, 8 Jan 2020 20:38:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAF2020692 for ; Wed, 8 Jan 2020 20:38:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NaYuG3E0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAF2020692 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QF72mirwSreDMmvR1fblbWVvosiT/lBVE+rB0y5XPi4=; b=NaYuG3E0Km4ANT ri9z31MzHay5Zv7S7quNWPnwEJ2mxSWoWbR1CqcrS5V9p9UfSvQ+BNzBl9RtWfEuHnE/ubh6hWTLm oWcOtT21oJHXj7HW0T1TEgsK5G5bqv/hHI9uhLIx8iVhzBcqWdWROg9hHnJTOxkZPsluJ9ig0X4r2 OciHr7aQv/1+k12gD58TK+HBm0W9/F7fYe1UV7yHt88I68yR+wy5MRXu6rKPaepRiYnKFXSkgjF+o ScRSGpXmPSUYvjRcijCE1YAX4afZefT5hVvr6NriN8iA6QK/Dx4Tc3QMGn/hnJXmNnwSqRa/WVKR4 /A7Y+3MuxiYTEVHPbOQw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipI69-0000Y0-RC; Wed, 08 Jan 2020 20:38:37 +0000 Received: from mail-oi1-f193.google.com ([209.85.167.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipI66-0000W9-Gg for linux-arm-kernel@lists.infradead.org; Wed, 08 Jan 2020 20:38:35 +0000 Received: by mail-oi1-f193.google.com with SMTP id v140so3928790oie.0 for ; Wed, 08 Jan 2020 12:38:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fYbMCE8GKhztIwg7FUhSFbp5MPOuXQT9UONOLwZL9bI=; b=Xji3xVxzqWMnVAYhRuQMPwr7FXgWIkXGjK2UsoZQdbb9d3urtnpa8VvGGxa1/SSsNg iVyBfPA+FcfLcLDWiGHSk9smOM/BHAY5sBgjIAFICIKx/JYy4CV7gycMC9W8XdKCJYHA QwHn/XrF6D8cTAhYKn6Q+/29S3H5DSQCnDgFKL8Euz7K9ky0p2jwFv6hu3Y+0XW2Iog3 CwdQxuXZkkfEJ5KyuZQzbhD45VOVHhjb45Rta7pd9p+ZWiiDg+vyTRdSSo02L3WZr21E tvMcTo7IJPx1nlEg9EGBHiLo3btPNAZx1QeaB0GZJAfABaRSIPdlQmwH9Ep5ezyxdeju tJ+w== X-Gm-Message-State: APjAAAWYJSekRSsah803+emkY3Ri4hJq1Wc94ACLGk8Qnto5sEMy4Qwz 3WyF+ijYBbOulHZccMFId0fBaWo= X-Google-Smtp-Source: APXvYqw5wbLL5s1uroLrticx939/wOKmVOxq5P4wc6eYIYQ/Nh2GYcjCn0gTxawh3sF3p91N8oFT6Q== X-Received: by 2002:aca:1204:: with SMTP id 4mr364384ois.143.1578515912634; Wed, 08 Jan 2020 12:38:32 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y13sm1463895otk.40.2020.01.08.12.38.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2020 12:38:30 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 220333 by rob-hp-laptop (DragonFly Mail Agent v0.11); Wed, 08 Jan 2020 14:38:29 -0600 Date: Wed, 8 Jan 2020 14:38:29 -0600 From: Rob Herring To: Roger Lu Subject: Re: [PATCH v6 1/3] dt-bindings: soc: add mtk svs dt-bindings Message-ID: <20200108203829.GA18987@bogus> References: <20200107070154.1574-1-roger.lu@mediatek.com> <20200107070154.1574-2-roger.lu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200107070154.1574-2-roger.lu@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200108_123834_548075_269B8F93 X-CRM114-Status: GOOD ( 18.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Angus Lin , Kevin Hilman , Stephen Boyd , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, HenryC Chen , YT Lee , Fan Chen , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Xiaoqing Liu , Charles Yang , Matthias Brugger , Nishanth Menon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 07, 2020 at 03:01:52PM +0800, Roger Lu wrote: > Document the binding for enabling mtk svs on MediaTek SoC. > > Signed-off-by: Roger Lu > --- > .../devicetree/bindings/power/mtk-svs.txt | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/mtk-svs.txt > > diff --git a/Documentation/devicetree/bindings/power/mtk-svs.txt b/Documentation/devicetree/bindings/power/mtk-svs.txt > new file mode 100644 > index 000000000000..9a3e81b9e1d2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/mtk-svs.txt > @@ -0,0 +1,76 @@ > +* Mediatek Smart Voltage Scaling (MTK SVS) > + > +This describes the device tree binding for the MTK SVS controller (bank) > +which helps provide the optimized CPU/GPU/CCI voltages. This device also > +needs thermal data to calculate thermal slope for accurately compensate > +the voltages when temperature change. > + > +Required properties: > +- compatible: > + - "mediatek,mt8183-svs" : For MT8183 family of SoCs > +- reg: Address range of the MTK SVS controller. > +- interrupts: IRQ for the MTK SVS controller. > +- clocks, clock-names: Clocks needed for the svs hardware. required > + clocks are: > + "main": Main clock for svs controller to work. > +- nvmem-cells: Phandle to the calibration data provided by a nvmem device. > +- nvmem-cell-names: Should be "svs-calibration-data" and "calibration-data" > + > +Subnodes: > +- svs-cpu-little: SVS bank device node of little CPU > + compatible: "mediatek,mt8183-svs-cpu-little" > + operating-points-v2: OPP table hooked by SVS little CPU bank. > + SVS will optimze this OPP table voltage part. > + vcpu-little-supply: PMIC buck of little CPU > +- svs-cpu-big: SVS bank device node of big CPU > + compatible: "mediatek,mt8183-svs-cpu-big" > + operating-points-v2: OPP table hooked by SVS big CPU bank. > + SVS will optimze this OPP table voltage part. > + vcpu-big-supply: PMIC buck of big CPU > +- svs-cci: SVS bank device node of CCI > + compatible: "mediatek,mt8183-svs-cci" > + operating-points-v2: OPP table hooked by SVS CCI bank. > + SVS will optimze this OPP table voltage part. > + vcci-supply: PMIC buck of CCI > +- svs-gpu: SVS bank device node of GPU > + compatible: "mediatek,mt8183-svs-gpu" > + operating-points-v2: OPP table hooked by SVS GPU bank. > + SVS will optimze this OPP table voltage part. > + vgpu-supply: PMIC buck of GPU > + > +Example: > + > + svs: svs@1100b000 { > + compatible = "mediatek,mt8183-svs"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = ; > + clocks = <&infracfg CLK_INFRA_THERM>; > + clock-names = "main_clk"; > + nvmem-cells = <&svs_calibration>, <&thermal_calibration>; > + nvmem-cell-names = "svs-calibration-data", "calibration-data"; > + > + svs_cpu_little: svs-cpu-little { > + compatible = "mediatek,mt8183-svs-cpu-little"; > + operating-points-v2 = <&cluster0_opp>; > + vcpu-little-supply = <&mt6358_vproc12_reg>; > + }; I don't think this is a good binding. This information already exists elsewhere in the DT, so your driver should just look in those nodes. For example the regulator can be in the cpu nodes or the OPP table itself. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel