All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andr? Draszik" <git@andred.net>
To: yocto@yoctoproject.org
Subject: [yocto][meta-gplv2][PATCH 2/2 v3] diffutils: use malloc() and realloc() from libc as-is
Date: Wed,  8 Jan 2020 21:06:57 +0000	[thread overview]
Message-ID: <20200108210657.22975-1-git@andred.net> (raw)
In-Reply-To: <15E7F58933AE7ECD.24134@lists.yoctoproject.org>

From: Andre' Draszik <git@andred.net>

diffutils' version of autoconf tries to run a test
program to determine if malloc() and realloc() behave
like in glibc, i.e. returning non-NULL when given 0 as
size. Running a test program doesn't work when cross-
compiling, so it defaults to assuming different
behaviour and compiles wrappers around malloc() &
realloc().

Given they behave the same in musl (these days), and
given uClibc isn't supported anymore, we can specify
the test-result, and avoid having to use diffutil's
replacement functions.

jm_cv_func_working_malloc and jm_cv_func_working_realloc
are similar to ac_cv_func_malloc_0_nonnull and
ac_cv_func_realloc_0_nonnull, which oe-core sets in
the site configuration in meta/site/, except that the
former two are the flags for the older version of
autoconf used by this package.

Signed-off-by: André Draszik <git@andred.net>

---
v3:
* update commit message
* don't make this musl specific

v2:
* switch to CACHED_CONFIGUREVARS instead of EXTRA_OECONF
---
 recipes-extended/diffutils/diffutils_2.8.1.bb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/recipes-extended/diffutils/diffutils_2.8.1.bb b/recipes-extended/diffutils/diffutils_2.8.1.bb
index 4aad28f..7c43c4b 100644
--- a/recipes-extended/diffutils/diffutils_2.8.1.bb
+++ b/recipes-extended/diffutils/diffutils_2.8.1.bb
@@ -16,6 +16,11 @@ SRC_URI = "${GNU_MIRROR}/diffutils/diffutils-${PV}.tar.gz \
 SRC_URI[md5sum] = "71f9c5ae19b60608f6c7f162da86a428"
 SRC_URI[sha256sum] = "c5001748b069224dd98bf1bb9ee877321c7de8b332c8aad5af3e2a7372d23f5a"
 
+CACHED_CONFIGUREVARS = "\
+    jm_cv_func_working_malloc=yes \
+    jm_cv_func_working_realloc=yes \
+"
+
 do_configure_prepend () {
 	chmod u+w ${S}/po/Makefile.in.in
 }
-- 
2.23.0.rc1


           reply	other threads:[~2020-01-08 21:07 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <15E7F58933AE7ECD.24134@lists.yoctoproject.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200108210657.22975-1-git@andred.net \
    --to=git@andred.net \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.