From: Al Viro <viro@zeniv.linux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Kirill Tkhai <ktkhai@virtuozzo.com>, Jens Axboe <axboe@kernel.dk>,
Willem de Bruijn <willemb@google.com>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Johannes Berg <johannes.berg@intel.com>,
Pedro Tammela <pctammela@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net-next] [v2] socket: fix unused-function warning
Date: Wed, 8 Jan 2020 21:56:04 +0000 [thread overview]
Message-ID: <20200108215604.GI8904@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200108214454.3950090-1-arnd@arndb.de>
On Wed, Jan 08, 2020 at 10:44:43PM +0100, Arnd Bergmann wrote:
> When procfs is disabled, the fdinfo code causes a harmless
> warning:
>
> net/socket.c:1000:13: error: 'sock_show_fdinfo' defined but not used [-Werror=unused-function]
> static void sock_show_fdinfo(struct seq_file *m, struct file *f)
>
> Move the function definition up so we can use a single #ifdef
> around it.
Looks sane...
next prev parent reply other threads:[~2020-01-08 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 21:44 [PATCH] [net-next] [v2] socket: fix unused-function warning Arnd Bergmann
2020-01-08 21:56 ` Al Viro [this message]
2020-01-08 23:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108215604.GI8904@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=johannes.berg@intel.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pctammela@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.