From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F662C282DD for ; Thu, 9 Jan 2020 15:05:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B02F2067D for ; Thu, 9 Jan 2020 15:05:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730857AbgAIPFs (ORCPT ); Thu, 9 Jan 2020 10:05:48 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:41998 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728346AbgAIPFs (ORCPT ); Thu, 9 Jan 2020 10:05:48 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipZNZ-004vJb-Do; Thu, 09 Jan 2020 15:05:45 +0000 Date: Thu, 9 Jan 2020 15:05:45 +0000 From: Al Viro To: Carlos Maiolino Cc: linux-fsdevel@vger.kernel.org, hch@lst.de Subject: Re: [PATCH V8 0/5] Refactor ioctl_fibmap() internal interface Message-ID: <20200109150545.GJ8904@ZenIV.linux.org.uk> References: <20200109133045.382356-1-cmaiolino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109133045.382356-1-cmaiolino@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jan 09, 2020 at 02:30:40PM +0100, Carlos Maiolino wrote: > Hi, > > This series refactor the internal structure of FIBMAP so that the filesystem can > properly report errors back to VFS, and also simplifies its usage by > standardizing all ->bmap() method usage via bmap() function. > > The last patch is a bug fix for ioctl_fibmap() calls with negative block values. > > > Viro spotted a mistake in patch 4/5 on the previous version, where bmap() > return value was not being propagated back to userland, breaking its ABI. > > So, this new version, only has a change on patch 4/5 to fix this problem. Applied and pushed (#work.misc, #for-next)