From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 372D2C282DD for ; Thu, 9 Jan 2020 18:08:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A241206ED for ; Thu, 9 Jan 2020 18:08:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J1cJufe6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A241206ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8BnmZGmmHzQkFNsuEMYXl5PNJKViuSk9thwV1ab5Q38=; b=J1cJufe6ChKH0j RDCS6l14EwS6nhRmo3geVG4cIYpQu9BryobXlJprf/0wWq0CcWNdtqoqLAL46ZoNdvfivtf5NGgqT iiTFyKWF8moj0sgLWWt13so+f2F4Zx/GTsNGBMl8pvPW7rlv4ZERn7WgaalFjJvegkUOy8IwCsHth BBB9cObZ6ILSJOVDLv6BpU6dyOWmpbgc+EIwQP6q8PayuP1fhCzUotVnkJYRjvHc7ZvE4CbY5paqc KwhVhPv1ElMrq+oN94NOljA0Zk829BOLkOrUWn6c3qR4BMD6Hnq/3beP2JvoI2cxWYBO13RKYdYws V/FreDcpJxmO7LZtau8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipcEd-0002W7-P6; Thu, 09 Jan 2020 18:08:43 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipcEb-0002Vm-ED for linux-mtd@lists.infradead.org; Thu, 09 Jan 2020 18:08:42 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 1D997C000B; Thu, 9 Jan 2020 18:08:39 +0000 (UTC) Date: Thu, 9 Jan 2020 19:08:38 +0100 From: Miquel Raynal To: Chuanhong Guo Subject: Re: [PATCH] mtd: nand: spi: rework detect procedure for different read id op Message-ID: <20200109190838.7028c8d9@xps13> In-Reply-To: <20200109075551.357179-1-gch981213@gmail.com> References: <20200109075551.357179-1-gch981213@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200109_100841_616481_0AD42585 X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , linux-mtd@lists.infradead.org, Vignesh Raghavendra , linux-kernel@vger.kernel.org, Boris Brezillon Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQ2h1YW5ob25nLAoKQ2h1YW5ob25nIEd1byA8Z2NoOTgxMjEzQGdtYWlsLmNvbT4gd3JvdGUg b24gVGh1LCAgOSBKYW4gMjAyMCAxNTo1NDowMAorMDgwMDoKCj4gQ3VycmVudGx5IHRoZXJlIGFy ZSAzIGRpZmZlcmVudCB2YXJpYW50cyBvZiByZWFkX2lkIGltcGxlbWVudGF0aW9uOgo+IDEuIG9w Y29kZSBvbmx5LiBGb3VuZCBpbiBHRDVGeEdRNHhGLgo+IDIuIG9wY29kZSArIDEgYWRkciBieXRl LiBGb3VuZCBpbiBHRDVHeEdRNHhBL0UKPiAzLiBvcGNvZGUgKyAxIGR1bW15IGJ5dGUuIEZvdW5k IGluIG90aGVyIGN1cnJlbnRseSBzdXBwb3J0ZWQgY2hpcHMuCj4gCj4gT3JpZ2luYWwgaW1wbGVt ZW50YXRpb24gd2FzIGZvciB2YXJpYW50IDEgYW5kIGxldCBkZXRlY3QgZnVuY3Rpb24KPiBvZiBj aGlwcyB3aXRoIHZhcmlhbnQgMiBhbmQgMyB0byBpZ25vcmUgdGhlIGZpcnN0IGJ5dGUuIFRoaXMg aXNuJ3QKPiByb2J1c3Q6Cj4gCj4gMS4gRm9yIGNoaXBzIG9mIHZhcmlhbnQgMiwgaWYgU1BJIG1h c3RlciBkb2Vzbid0IGtlZXAgTU9TSSBsb3cKPiBkdXJpbmcgcmVhZCwgY2hpcCB3aWxsIGdldCBh IHJhbmRvbSBpZCBvZmZzZXQsIGFuZCB0aGUgZW50aXJlIGlkCj4gYnVmZmVyIHdpbGwgc2hpZnQg YnkgdGhhdCBvZmZzZXQsIGNhdXNpbmcgZGV0ZWN0IGZhaWx1cmUuCj4gCj4gMi4gRm9yIGNoaXBz IG9mIHZhcmlhbnQgMSwgaWYgaXQgaGFwcGVucyB0byBnZXQgYSBkZXZpZCB0aGF0IGVxdWFscwo+ IHRvIG1hbnVmYWN0dXJlIGlkIG9mIHZhcmlhbnQgMiBvciAzIGNoaXBzLCBpdCdsbCBnZXQgaW5j b3JyZWN0bHkKPiBkZXRlY3RlZC4KPiAKPiBUaGlzIHBhdGNoIHJld29ya3MgZGV0ZWN0IHByb2Nl ZHVyZSB0byBhZGRyZXNzIHByb2JsZW1zIGFib3ZlLiBOZXcKPiBsb2dpYyBkbyBkZXRlY3Rpb24g Zm9yIGFsbCB2YXJpYW50cyBzZXBhcmF0ZWRseSwgaW4gMS0yLTMgb3JkZXIuCj4gU2luY2UgYWxs IGN1cnJlbnQgZGV0ZWN0IG1ldGhvZHMgZG8gZXhhY3RseSB0aGUgc2FtZSBpZCBtYXRjaGluZwo+ IHByb2NlZHVyZSwgdW5pZnkgdGhlbSBpbnRvIGNvcmUuYyBhbmQgcmVtb3ZlIGRldGVjdCBtZXRo b2QgZnJvbQo+IG1hbnVmYWN0dXJlX29wcy4KPiAKPiBUZXN0ZWQgb24gR0Q1RjFHUTRVQVlJRyBh bmQgVzI1TjAxR1ZaRUlHLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENodWFuaG9uZyBHdW8gPGdjaDk4 MTIxM0BnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYyAgICAg ICB8IDg5ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiAgZHJpdmVycy9tdGQvbmFu ZC9zcGkvZ2lnYWRldmljZS5jIHwgNDYgKysrKysrLS0tLS0tLS0tLQo+ICBkcml2ZXJzL210ZC9u YW5kL3NwaS9tYWNyb25peC5jICAgfCAyNSArKy0tLS0tLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9z cGkvbWljcm9uLmMgICAgIHwgMjQgKystLS0tLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvc3BpL3Bh cmFnb24uYyAgICB8IDIzICsrLS0tLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvc3BpL3Rvc2hpYmEu YyAgICB8IDI1ICsrLS0tLS0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3NwaS93aW5ib25kLmMgICAg fCAyOSArKy0tLS0tLS0tCj4gIGluY2x1ZGUvbGludXgvbXRkL3NwaW5hbmQuaCAgICAgICB8IDI0 ICsrKystLS0tLQo+ICA4IGZpbGVzIGNoYW5nZWQsIDExMCBpbnNlcnRpb25zKCspLCAxNzUgZGVs ZXRpb25zKC0pCgpOaWNlIGRpZmZzdGF0LCBhbmQgbmljZSBpbXBsZW1lbnRhdGlvbiBJTUhPLgoK SSdtIGZpbmUgd2l0aCB0aGUgcGF0Y2ggYnV0IEkgd291bGQgbG92ZSB0byBoZWFyIEJvcmlzJyB2 b2ljZSBvbiB0aGlzLgoKUmV2aWV3ZWQtYnk6IE1pcXVlbCBSYXluYWwgPG1pcXVlbC5yYXluYWxA Ym9vdGxpbi5jb20+CgpPbmUgbWlub3Igbml0IGJlbG93LgoKCj4gQEAgLTIxNSwxNSArMjA0LDIy IEBAIHN0cnVjdCBzcGluYW5kX21hbnVmYWN0dXJlcl9vcHMgewo+ICAgKiBzdHJ1Y3Qgc3BpbmFu ZF9tYW51ZmFjdHVyZXIgLSBTUEkgTkFORCBtYW51ZmFjdHVyZXIgaW5zdGFuY2UKPiAgICogQGlk OiBtYW51ZmFjdHVyZXIgSUQKPiAgICogQG5hbWU6IG1hbnVmYWN0dXJlciBuYW1lCj4gKyAqIEBk ZXZpZF9sZW46IG51bWJlciBvZiBieXRlcyBpbiBkZXZpY2UgSUQKPiArICogQHNwaW5hbmRfdGFi bGU6IGFycmF5IHdpdGggaW5mbyBmb3Igc3BpIG5hbmRzIHVuZGVyIGN1cnJlbnQgbWFudWZhY3R1 cmVyCgpUaGlzIGRlc2NyaXB0aW9uIGlzIG5vdCB2ZXJ5IGNsZWFyIHRvIG1lLgpBbmQgYWxzbyBz L3NwaSBuYW5kcy9TUEktTkFORHMvCgo+ICsgKiBAbmNoaXBzOiBudW1iZXIgb2YgY2hpcHMgYXZh aWxhYmxlIGluIHNwaW5hbmRfdGFibGUKPiAgICogQG9wczogbWFudWZhY3R1cmVyIG9wZXJhdGlv bnMKPiAgICovCj4gIHN0cnVjdCBzcGluYW5kX21hbnVmYWN0dXJlciB7Cj4gIAl1OCBpZDsKPiAg CWNoYXIgKm5hbWU7Cj4gKwl1OCBkZXZpZF9sZW47Cj4gKwljb25zdCBzdHJ1Y3Qgc3BpbmFuZF9p bmZvICpzcGluYW5kX3RhYmxlOwo+ICsJc2l6ZV90IG5jaGlwczsKPiAgCWNvbnN0IHN0cnVjdCBz cGluYW5kX21hbnVmYWN0dXJlcl9vcHMgKm9wczsKPiAgfTsKPiAgCj4gIC8qIFNQSSBOQU5EIG1h bnVmYWN0dXJlcnMgKi8KPiArZXh0ZXJuIGNvbnN0IHN0cnVjdCBzcGluYW5kX21hbnVmYWN0dXJl ciBnaWdhZGV2aWNlX3NwaW5hbmRfbWFudWZhY3R1cmVyXzFhX2lkOwo+ICBleHRlcm4gY29uc3Qg c3RydWN0IHNwaW5hbmRfbWFudWZhY3R1cmVyIGdpZ2FkZXZpY2Vfc3BpbmFuZF9tYW51ZmFjdHVy ZXI7Cj4gIGV4dGVybiBjb25zdCBzdHJ1Y3Qgc3BpbmFuZF9tYW51ZmFjdHVyZXIgbWFjcm9uaXhf c3BpbmFuZF9tYW51ZmFjdHVyZXI7Cj4gIGV4dGVybiBjb25zdCBzdHJ1Y3Qgc3BpbmFuZF9tYW51 ZmFjdHVyZXIgbWljcm9uX3NwaW5hbmRfbWFudWZhY3R1cmVyOwoKVGhhbmtzLApNaXF1w6hsCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGlu dXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9678FC282DD for ; Thu, 9 Jan 2020 18:08:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65D5D20721 for ; Thu, 9 Jan 2020 18:08:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388408AbgAISIl convert rfc822-to-8bit (ORCPT ); Thu, 9 Jan 2020 13:08:41 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47307 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728653AbgAISIl (ORCPT ); Thu, 9 Jan 2020 13:08:41 -0500 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 1D997C000B; Thu, 9 Jan 2020 18:08:39 +0000 (UTC) Date: Thu, 9 Jan 2020 19:08:38 +0100 From: Miquel Raynal To: Chuanhong Guo Cc: linux-mtd@lists.infradead.org, Boris Brezillon , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: nand: spi: rework detect procedure for different read id op Message-ID: <20200109190838.7028c8d9@xps13> In-Reply-To: <20200109075551.357179-1-gch981213@gmail.com> References: <20200109075551.357179-1-gch981213@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chuanhong, Chuanhong Guo wrote on Thu, 9 Jan 2020 15:54:00 +0800: > Currently there are 3 different variants of read_id implementation: > 1. opcode only. Found in GD5FxGQ4xF. > 2. opcode + 1 addr byte. Found in GD5GxGQ4xA/E > 3. opcode + 1 dummy byte. Found in other currently supported chips. > > Original implementation was for variant 1 and let detect function > of chips with variant 2 and 3 to ignore the first byte. This isn't > robust: > > 1. For chips of variant 2, if SPI master doesn't keep MOSI low > during read, chip will get a random id offset, and the entire id > buffer will shift by that offset, causing detect failure. > > 2. For chips of variant 1, if it happens to get a devid that equals > to manufacture id of variant 2 or 3 chips, it'll get incorrectly > detected. > > This patch reworks detect procedure to address problems above. New > logic do detection for all variants separatedly, in 1-2-3 order. > Since all current detect methods do exactly the same id matching > procedure, unify them into core.c and remove detect method from > manufacture_ops. > > Tested on GD5F1GQ4UAYIG and W25N01GVZEIG. > > Signed-off-by: Chuanhong Guo > --- > drivers/mtd/nand/spi/core.c | 89 +++++++++++++++++++++++-------- > drivers/mtd/nand/spi/gigadevice.c | 46 ++++++---------- > drivers/mtd/nand/spi/macronix.c | 25 ++------- > drivers/mtd/nand/spi/micron.c | 24 ++------- > drivers/mtd/nand/spi/paragon.c | 23 ++------ > drivers/mtd/nand/spi/toshiba.c | 25 ++------- > drivers/mtd/nand/spi/winbond.c | 29 ++-------- > include/linux/mtd/spinand.h | 24 ++++----- > 8 files changed, 110 insertions(+), 175 deletions(-) Nice diffstat, and nice implementation IMHO. I'm fine with the patch but I would love to hear Boris' voice on this. Reviewed-by: Miquel Raynal One minor nit below. > @@ -215,15 +204,22 @@ struct spinand_manufacturer_ops { > * struct spinand_manufacturer - SPI NAND manufacturer instance > * @id: manufacturer ID > * @name: manufacturer name > + * @devid_len: number of bytes in device ID > + * @spinand_table: array with info for spi nands under current manufacturer This description is not very clear to me. And also s/spi nands/SPI-NANDs/ > + * @nchips: number of chips available in spinand_table > * @ops: manufacturer operations > */ > struct spinand_manufacturer { > u8 id; > char *name; > + u8 devid_len; > + const struct spinand_info *spinand_table; > + size_t nchips; > const struct spinand_manufacturer_ops *ops; > }; > > /* SPI NAND manufacturers */ > +extern const struct spinand_manufacturer gigadevice_spinand_manufacturer_1a_id; > extern const struct spinand_manufacturer gigadevice_spinand_manufacturer; > extern const struct spinand_manufacturer macronix_spinand_manufacturer; > extern const struct spinand_manufacturer micron_spinand_manufacturer; Thanks, Miquèl