From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Sameer Pujar <spujar@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: tegra-aconnect: remove PM_CLK dependency
Date: Fri, 10 Jan 2020 12:32:31 +0100 [thread overview]
Message-ID: <20200110113231.GC2233456@ulmo> (raw)
In-Reply-To: <55217434-2a50-7abe-25c3-6f4f90d8ba34@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
On Thu, Jun 20, 2019 at 05:02:27PM +0100, Jon Hunter wrote:
>
> On 20/06/2019 16:51, Sameer Pujar wrote:
> > aconnect bus driver does not use pm-clk interface now and hence the
> > dependency is removed from Kconfig.
> >
> > Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> > ---
> > drivers/bus/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> > index 1851112..4587ef2 100644
> > --- a/drivers/bus/Kconfig
> > +++ b/drivers/bus/Kconfig
> > @@ -128,7 +128,6 @@ config TEGRA_ACONNECT
> > tristate "Tegra ACONNECT Bus Driver"
> > depends on ARCH_TEGRA_210_SOC
> > depends on OF && PM
> > - select PM_CLK
> > help
> > Driver for the Tegra ACONNECT bus which is used to interface with
> > the devices inside the Audio Processing Engine (APE) for Tegra210.
>
> Thanks. We should probably populate the 'Fixes:' tag for this to show
> which commit this fixes. Otherwise ...
>
> Acked-by: Jon Hunter <jonathanh@nvidia.com>
Looks like this was never applied. I don't recollect that there was a
specific reason why we shouldn't, so I went ahead and applied this after
adding:
Fixes: 0d7dab926130 ("bus: tegra-aconnect: use devm_clk_*() helpers")
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-01-10 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 15:51 [PATCH] bus: tegra-aconnect: remove PM_CLK dependency Sameer Pujar
2019-06-20 15:51 ` Sameer Pujar
2019-06-20 16:02 ` Jon Hunter
2019-06-20 16:02 ` Jon Hunter
2020-01-10 11:32 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110113231.GC2233456@ulmo \
--to=thierry.reding@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=spujar@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.