From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2932EC33CA2 for ; Fri, 10 Jan 2020 11:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED7042077C for ; Fri, 10 Jan 2020 11:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727763AbgAJLhQ (ORCPT ); Fri, 10 Jan 2020 06:37:16 -0500 Received: from foss.arm.com ([217.140.110.172]:42818 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727457AbgAJLhP (ORCPT ); Fri, 10 Jan 2020 06:37:15 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 498D01063; Fri, 10 Jan 2020 03:37:15 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EA9CA3F534; Fri, 10 Jan 2020 03:37:13 -0800 (PST) Date: Fri, 10 Jan 2020 11:37:11 +0000 From: Sudeep Holla To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, Brian Norris , Marc Zyngier , Douglas Anderson , Robin Murphy , Heiko Stuebner , Sudeep Holla , Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: Re: [PATCH v1] arch_topology: Adjust initial CPU capacities with current freq Message-ID: <20200110113711.GB39451@bogus> References: <20200109075214.31943-1-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109075214.31943-1-jeffy.chen@rock-chips.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 09, 2020 at 03:52:14PM +0800, Jeffy Chen wrote: > The CPU freqs are not supposed to change before cpufreq policies > properly registered, meaning that they should be used to calculate the > initial CPU capacities. > > Doing this helps choosing the best CPU during early boot, especially > for the initramfs decompressing. > > Signed-off-by: Jeffy Chen [...] > @@ -146,10 +153,15 @@ bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu) > return false; > } > } > - capacity_scale = max(cpu_capacity, capacity_scale); > raw_capacity[cpu] = cpu_capacity; > pr_debug("cpu_capacity: %pOF cpu_capacity=%u (raw)\n", > cpu_node, raw_capacity[cpu]); > + > + cpu_clk = of_clk_get(cpu_node, 0); > + if (!PTR_ERR_OR_ZERO(cpu_clk)) > + per_cpu(max_freq, cpu) = clk_get_rate(cpu_clk) / 1000; > + > + clk_put(cpu_clk); I don't like to assume DVFS to be supplied only using 'clk'. So NACK! We have other non-clk mechanism for CPU DVFS and this needs to simply use cpufreq APIs to get frequency value if required. -- Regards, Sudeep