From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E0DC33CA2 for ; Fri, 10 Jan 2020 12:41:12 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73B602072E for ; Fri, 10 Jan 2020 12:41:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aEXo+Y+I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73B602072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 77706883F5; Fri, 10 Jan 2020 12:41:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1-0qPyVwSCYY; Fri, 10 Jan 2020 12:41:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id E51A2882AC; Fri, 10 Jan 2020 12:41:10 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C6C9EC1796; Fri, 10 Jan 2020 12:41:10 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3ABC9C0881 for ; Fri, 10 Jan 2020 12:41:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 25650882B6 for ; Fri, 10 Jan 2020 12:41:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id epfGlhnr3V5L for ; Fri, 10 Jan 2020 12:41:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by hemlock.osuosl.org (Postfix) with ESMTPS id 882B1882AC for ; Fri, 10 Jan 2020 12:41:08 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id b22so810682pls.12 for ; Fri, 10 Jan 2020 04:41:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KdKUDe5VNtZZyWUDsEVdrhShf2Kcu/VrtdXGE+9fTXo=; b=aEXo+Y+Ie5rmicBedqlm+l0xcucSqrT0flZYEl8YMu8DkFlvzVXCDfNNBt0Ss7lIxo Ee6QISm89zpDn37usCnsQkHlOScps8LfSO+fn02Z8bMAO/Om7/QL03ogwBfHRxQ/b90p BD0vwMHX7I1oywX/wtQ4z7CWLumArREiGtSx7sFxv/iZuwHJl8srnYQkAlwAP6CA13C+ q4JtK15TFGnjxhw+GpDudO0ScQWna7BEvHzLoM1SLIdMMYuC79rUla8uak+ryyjU52PB KPxrj6LMdZmVwlp0CqjledxBozinckQdFyzr4R/PNh2/7L+AFJgb2gnaaTp/SNhu8tb9 R0wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KdKUDe5VNtZZyWUDsEVdrhShf2Kcu/VrtdXGE+9fTXo=; b=CMeXUs2ewYBz9L+vM8XwsshRcuXIJXl4mQw/AxgvqUvgEorhySbTF+dj6DG7TIPjE9 yaDoBpESS4ocMBrn4UoeyI4n1YD4v+Gz1zN39Uv2ruMwMf1TnwvP8uTGsDli4+37fmxt vUfLW3ucXJqfP4XxjPXK8hAAn2wMuwkkc5W4H0wN7o+9yi8ilbGHqE2nqgEyj3PNtrMf bGzRb0ZcG5VKVR0UtzjYEe4rBd9/H6sgw950QUZu5gES5gDBicIBIyvTpx8oiKQHfswr NZNuddpjIThodjLnd7gIHW1NjNeZvFvRBdSlO35wQjkEpsPv9iTeyPdSJYNFe9zR06+N WnCA== X-Gm-Message-State: APjAAAU6J0v1vJ1Ej+mdaBycvQqhaFHL3wKQ+E/T5BlErb2zb7mfWmnE CmNF7INGJR9iNB7FmwtcW/8= X-Google-Smtp-Source: APXvYqz1hwPwNDFF8rpc5BstYqeYvTPUUxNEteYq7zFknzooAoSivNVQ2BUO0MS/yigWPRMlbviL0A== X-Received: by 2002:a17:902:ab8c:: with SMTP id f12mr4195297plr.268.1578660068150; Fri, 10 Jan 2020 04:41:08 -0800 (PST) Received: from localhost.localdomain ([103.211.17.220]) by smtp.googlemail.com with ESMTPSA id i11sm2890922pjg.0.2020.01.10.04.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2020 04:41:07 -0800 (PST) From: Amol Grover To: Santosh Shilimkar Date: Fri, 10 Jan 2020 18:02:13 +0530 Message-Id: <20200110123212.26756-1-frextrite@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Cc: "Paul E . McKenney" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Joel Fernandes , linux-kernel-mentees@lists.linuxfoundation.org Subject: [Linux-kernel-mentees] [PATCH] drivers: soc: ti: knav_qmss_queue: Pass lockdep expression to RCU lists X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" inst->handles is traversed using list_for_each_entry_rcu outside an RCU read-side critical section but under the protection of knav_dev_lock. Hence, add corresponding lockdep expression to silence false-positive lockdep warnings, and harden RCU lists. Add macro for the corresponding lockdep expression to make the code clean and concise. Signed-off-by: Amol Grover --- drivers/soc/ti/knav_qmss_queue.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index 1ccc9064e1eb..888dc091c63b 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -25,6 +25,8 @@ static struct knav_device *kdev; static DEFINE_MUTEX(knav_dev_lock); +#define knav_dev_lock_held() \ + lockdep_is_held(&knav_dev_lock) /* Queue manager register indices in DTS */ #define KNAV_QUEUE_PEEK_REG_INDEX 0 @@ -52,8 +54,9 @@ static DEFINE_MUTEX(knav_dev_lock); #define knav_queue_idx_to_inst(kdev, idx) \ (kdev->instances + (idx << kdev->inst_shift)) -#define for_each_handle_rcu(qh, inst) \ - list_for_each_entry_rcu(qh, &inst->handles, list) +#define for_each_handle_rcu(qh, inst) \ + list_for_each_entry_rcu(qh, &inst->handles, list, \ + rcu_read_lock_held() || knav_dev_lock_held()) #define for_each_instance(idx, inst, kdev) \ for (idx = 0, inst = kdev->instances; \ -- 2.24.1 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1FC8C33CA2 for ; Fri, 10 Jan 2020 12:41:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F5352072E for ; Fri, 10 Jan 2020 12:41:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ro8L3Bqf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aEXo+Y+I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F5352072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=fDUePsfen1FIJusZ8wFcD7TkKSa9BmjSRpfbfI3U4Vk=; b=ro8L3BqfULRQlu vaJIApsPBjrqcitnKx/PvxywDuM46QNMIbNUDTuDkoA7Z2uQfKVX/Ia+6dkRPcLT0lpYwgSWl7Sjd CWCUzMT6MQzHVfyVMWjVZ1G/0s0O7VAN72eroU20KhTzVUTYGJTKqu+T6fb8A851YLZ96Tg+cvgzX kp00D/6G9rSIhw++ZYiHMUwjuITLW504LVrd/jQXVJf02WfmVwyscRb0fK01Y6meFLnn439iSVwhL ZDWXRB6vMbG7EgP6b0IWaauctkV/udog6dXM8qPO5kuiL1BSlrYcz6IKDd0l9lz/eANkhrXlsgml2 ONmLGqesv138QFqiJSZw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iptbE-0000Ls-M4; Fri, 10 Jan 2020 12:41:12 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iptbB-0000Kt-HL for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 12:41:10 +0000 Received: by mail-pl1-x644.google.com with SMTP id a6so829598plm.3 for ; Fri, 10 Jan 2020 04:41:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KdKUDe5VNtZZyWUDsEVdrhShf2Kcu/VrtdXGE+9fTXo=; b=aEXo+Y+Ie5rmicBedqlm+l0xcucSqrT0flZYEl8YMu8DkFlvzVXCDfNNBt0Ss7lIxo Ee6QISm89zpDn37usCnsQkHlOScps8LfSO+fn02Z8bMAO/Om7/QL03ogwBfHRxQ/b90p BD0vwMHX7I1oywX/wtQ4z7CWLumArREiGtSx7sFxv/iZuwHJl8srnYQkAlwAP6CA13C+ q4JtK15TFGnjxhw+GpDudO0ScQWna7BEvHzLoM1SLIdMMYuC79rUla8uak+ryyjU52PB KPxrj6LMdZmVwlp0CqjledxBozinckQdFyzr4R/PNh2/7L+AFJgb2gnaaTp/SNhu8tb9 R0wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KdKUDe5VNtZZyWUDsEVdrhShf2Kcu/VrtdXGE+9fTXo=; b=UaghgrbxqgGZRJR4Wd2ntyCX1GLMmQUADwhN9AgaIuXB3cQfArY0v/aomScC5ItP+J +shyjsofSlPzOywnS+7AxH+uxmj0Wv2eioJjCCmfsjhvYqP3Qwd/iwKtjIgh+0PApdUx TqVOSInwF3lZRYHEfsrmD4deMcUQgK2+NNYAgZ4WxxtmPcciaMVpkbE6aQhzEDevYyPw mDUH6akkAeA9YIygCc/LrarxA13xaPMiBueIXuRd3AKN1k6Re/WA+Y3p4cTYp+SHTdrc 2R0cx2LeM0g++k7EtQIZCotGCLTf+uRsxkuvTHlNxRez3bb22aBEX0ScWdRAmeLmWK4G nu4w== X-Gm-Message-State: APjAAAUO2OOg0kZseI40cUujgNl3Bx/QtqD3yC3RL5lwyWpnVji7oubk zWswoIZbTD3iJ9+qj6EDWaM= X-Google-Smtp-Source: APXvYqz1hwPwNDFF8rpc5BstYqeYvTPUUxNEteYq7zFknzooAoSivNVQ2BUO0MS/yigWPRMlbviL0A== X-Received: by 2002:a17:902:ab8c:: with SMTP id f12mr4195297plr.268.1578660068150; Fri, 10 Jan 2020 04:41:08 -0800 (PST) Received: from localhost.localdomain ([103.211.17.220]) by smtp.googlemail.com with ESMTPSA id i11sm2890922pjg.0.2020.01.10.04.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2020 04:41:07 -0800 (PST) From: Amol Grover To: Santosh Shilimkar Subject: [PATCH] drivers: soc: ti: knav_qmss_queue: Pass lockdep expression to RCU lists Date: Fri, 10 Jan 2020 18:02:13 +0530 Message-Id: <20200110123212.26756-1-frextrite@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_044109_575046_D573B23B X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Paul E . McKenney" , Amol Grover , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Joel Fernandes , linux-kernel-mentees@lists.linuxfoundation.org, Madhuparna Bhowmik Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org inst->handles is traversed using list_for_each_entry_rcu outside an RCU read-side critical section but under the protection of knav_dev_lock. Hence, add corresponding lockdep expression to silence false-positive lockdep warnings, and harden RCU lists. Add macro for the corresponding lockdep expression to make the code clean and concise. Signed-off-by: Amol Grover --- drivers/soc/ti/knav_qmss_queue.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index 1ccc9064e1eb..888dc091c63b 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -25,6 +25,8 @@ static struct knav_device *kdev; static DEFINE_MUTEX(knav_dev_lock); +#define knav_dev_lock_held() \ + lockdep_is_held(&knav_dev_lock) /* Queue manager register indices in DTS */ #define KNAV_QUEUE_PEEK_REG_INDEX 0 @@ -52,8 +54,9 @@ static DEFINE_MUTEX(knav_dev_lock); #define knav_queue_idx_to_inst(kdev, idx) \ (kdev->instances + (idx << kdev->inst_shift)) -#define for_each_handle_rcu(qh, inst) \ - list_for_each_entry_rcu(qh, &inst->handles, list) +#define for_each_handle_rcu(qh, inst) \ + list_for_each_entry_rcu(qh, &inst->handles, list, \ + rcu_read_lock_held() || knav_dev_lock_held()) #define for_each_instance(idx, inst, kdev) \ for (idx = 0, inst = kdev->instances; \ -- 2.24.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5049CC33CA2 for ; Fri, 10 Jan 2020 12:41:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AF4F2072E for ; Fri, 10 Jan 2020 12:41:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aEXo+Y+I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728225AbgAJMlJ (ORCPT ); Fri, 10 Jan 2020 07:41:09 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:38919 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727949AbgAJMlI (ORCPT ); Fri, 10 Jan 2020 07:41:08 -0500 Received: by mail-pl1-f195.google.com with SMTP id g6so823230plp.6 for ; Fri, 10 Jan 2020 04:41:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KdKUDe5VNtZZyWUDsEVdrhShf2Kcu/VrtdXGE+9fTXo=; b=aEXo+Y+Ie5rmicBedqlm+l0xcucSqrT0flZYEl8YMu8DkFlvzVXCDfNNBt0Ss7lIxo Ee6QISm89zpDn37usCnsQkHlOScps8LfSO+fn02Z8bMAO/Om7/QL03ogwBfHRxQ/b90p BD0vwMHX7I1oywX/wtQ4z7CWLumArREiGtSx7sFxv/iZuwHJl8srnYQkAlwAP6CA13C+ q4JtK15TFGnjxhw+GpDudO0ScQWna7BEvHzLoM1SLIdMMYuC79rUla8uak+ryyjU52PB KPxrj6LMdZmVwlp0CqjledxBozinckQdFyzr4R/PNh2/7L+AFJgb2gnaaTp/SNhu8tb9 R0wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KdKUDe5VNtZZyWUDsEVdrhShf2Kcu/VrtdXGE+9fTXo=; b=NkCVzEFJfnzfd+1Z6rklzRpOdheVcBjRxs1xWisyvjNMTBZJ36V1PUWhBKLRAqrDur 4UBQxVU/OhG+UpHXtbzKgw17JBp7D/yGh9ynB0XCKZvT9PWaN0mwxq97WetEMDCcI5d4 rNmBk1IEPIQ8695+pmZjBgL7hDeBL4FfAwYHen3Jcd3+4aWFcBZCUPZtRqjpPb9baFWl N7dgYotMoY5Vz51TEPT67R+7WFeKv339f4EJ/PXBYxzAiJiMO3H2aaWEbdz1UW1b9Cvb LrDBcliorgumjhSWrGCY8fIxrdYARMPzyeOsKH0N5bRLMNoeCwbo7GY4shMDiyDuFc2P QYMQ== X-Gm-Message-State: APjAAAWHdkF7qwTUSyrXNKrhWMXmCp/r7etRPBvD+YLV3uI4W4vIfDzf pVIm4OJrqPtaGx2SSoYyTes= X-Google-Smtp-Source: APXvYqz1hwPwNDFF8rpc5BstYqeYvTPUUxNEteYq7zFknzooAoSivNVQ2BUO0MS/yigWPRMlbviL0A== X-Received: by 2002:a17:902:ab8c:: with SMTP id f12mr4195297plr.268.1578660068150; Fri, 10 Jan 2020 04:41:08 -0800 (PST) Received: from localhost.localdomain ([103.211.17.220]) by smtp.googlemail.com with ESMTPSA id i11sm2890922pjg.0.2020.01.10.04.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2020 04:41:07 -0800 (PST) From: Amol Grover To: Santosh Shilimkar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel-mentees@lists.linuxfoundation.org, Joel Fernandes , Madhuparna Bhowmik , "Paul E . McKenney" , Amol Grover Subject: [PATCH] drivers: soc: ti: knav_qmss_queue: Pass lockdep expression to RCU lists Date: Fri, 10 Jan 2020 18:02:13 +0530 Message-Id: <20200110123212.26756-1-frextrite@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org inst->handles is traversed using list_for_each_entry_rcu outside an RCU read-side critical section but under the protection of knav_dev_lock. Hence, add corresponding lockdep expression to silence false-positive lockdep warnings, and harden RCU lists. Add macro for the corresponding lockdep expression to make the code clean and concise. Signed-off-by: Amol Grover --- drivers/soc/ti/knav_qmss_queue.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index 1ccc9064e1eb..888dc091c63b 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -25,6 +25,8 @@ static struct knav_device *kdev; static DEFINE_MUTEX(knav_dev_lock); +#define knav_dev_lock_held() \ + lockdep_is_held(&knav_dev_lock) /* Queue manager register indices in DTS */ #define KNAV_QUEUE_PEEK_REG_INDEX 0 @@ -52,8 +54,9 @@ static DEFINE_MUTEX(knav_dev_lock); #define knav_queue_idx_to_inst(kdev, idx) \ (kdev->instances + (idx << kdev->inst_shift)) -#define for_each_handle_rcu(qh, inst) \ - list_for_each_entry_rcu(qh, &inst->handles, list) +#define for_each_handle_rcu(qh, inst) \ + list_for_each_entry_rcu(qh, &inst->handles, list, \ + rcu_read_lock_held() || knav_dev_lock_held()) #define for_each_instance(idx, inst, kdev) \ for (idx = 0, inst = kdev->instances; \ -- 2.24.1