From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C3CC33CA2 for ; Fri, 10 Jan 2020 12:48:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EF8C2072E for ; Fri, 10 Jan 2020 12:48:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578660517; bh=PrOwLV4tQ+lI1OTRTBOIvMq4rzUtK4hs298T1zbtacE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WfUO3cs70o07vmzJD6mYqbgGwphwzmuYsvd7JawmaO5wPUe6inUeG/j8Xop+XXYm9 JdD3b8dOj8/pO/6R8DCDMlHUGyAlOro8r8mYA+SBZWVX36hFSVNp08mIW3V85MkyFC nDNglP98LaudweJmOCXygB0Ld9sQZu3puCIKU5P0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbgAJMsg (ORCPT ); Fri, 10 Jan 2020 07:48:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:56674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728074AbgAJMsg (ORCPT ); Fri, 10 Jan 2020 07:48:36 -0500 Received: from localhost (83-84-126-242.cable.dynamic.v4.ziggo.nl [83.84.126.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6AD220721; Fri, 10 Jan 2020 12:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578660514; bh=PrOwLV4tQ+lI1OTRTBOIvMq4rzUtK4hs298T1zbtacE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SqTugStLNX+pRuf7gCMwoCYvksuMTTptT58RIF20ZMu0BuGuSKdAgAOCm2EpLitWS vOKTErvPU5Vix3nOBAjLY2i/QSuzMn9A8/SjgDVkeP91isX2HSNZxtKNab0JneFEDr 0PKqLX4fOdY06u/Xr50selEkwSjtOc5hITYJORCc= Date: Fri, 10 Jan 2020 13:48:32 +0100 From: Greg Kroah-Hartman To: Alexander X Sverdlin Cc: devel@driverdev.osuosl.org, Aaro Koskinen , Ralf Baechle , netdev@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH] staging: octeon: Drop on uncorrectable alignment or FCS error Message-ID: <20200110124832.GA1090147@kroah.com> References: <20200108161042.253618-1-alexander.sverdlin@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200108161042.253618-1-alexander.sverdlin@nokia.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 08, 2020 at 05:10:42PM +0100, Alexander X Sverdlin wrote: > From: Alexander Sverdlin > > Currently in case of alignment or FCS error if the packet cannot be > corrected it's still not dropped. Report the error properly and drop the > packet while making the code around a little bit more readable. > > Fixes: 80ff0fd3ab ("Staging: Add octeon-ethernet driver files.") > Signed-off-by: Alexander Sverdlin > --- > drivers/staging/octeon/ethernet-rx.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) This driver is now deleted from the tree, sorry. greg k-h