From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Suren Baghdasaryan <surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>,
"Johannes Weiner"
<hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
"Topi Miettinen"
<toiwoton-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Li Zefan" <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
"cgroups mailinglist"
<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
security-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org,
"Security Officers"
<security-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Lennart Poettering"
<lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org>,
"Oleg Nesterov" <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
james.hsu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linger.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
"Tom Cherry" <tomcherry-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
"Roman Gushchin" <guro-b10kYP2dOMg@public.gmane.org>
Subject: Re: [PATCH 3/3 cgroup/for-5.2-fixes] cgroup: Include dying leaders with live threads in PROCS iterations
Date: Fri, 10 Jan 2020 14:15:53 -0800 [thread overview]
Message-ID: <20200110221553.GD2677547@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <CAJuCfpHPRfV5KDM74JtDepdUJ2G+-3-A3XV+Fzr3Lkbj9nR-Cg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, Jan 10, 2020 at 02:14:19PM -0800, Suren Baghdasaryan wrote:
> > Yeah, the current behavior isn't quite consistent with the
> > documentation and what we prolly wanna do is allowing destroying a
> > cgroup with only dead processes in it. That said, the correct (or at
> > least workable) signal which indicates that a cgroup is ready for
> > removal is cgroup.events::populated being zero, which is a poll(2)able
> > event.
>
> Unfortunately it would not be workable for us as it's only available
> for cgroup v2 controllers.
> I can think of other ways to fix it in the userspace but there might
> be other cgroup API users which are be broken after this change. I
> would prefer to fix it in the kernel if at all possible rather than
> chasing all possible users.
Yeah, the right thing to do is allowing destruction of cgroups w/ only
dead processes in it.
--
tejun
next prev parent reply other threads:[~2020-01-10 22:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87blznagrl.fsf@xmission.com>
[not found] ` <1956727d-1ee8-92af-1e00-66ae4921b075@gmail.com>
[not found] ` <87zhn6923n.fsf@xmission.com>
[not found] ` <e407a8e7-7780-f08f-320a-a0f2c954d253@gmail.com>
[not found] ` <20190529003601.GN374014@devbig004.ftw2.facebook.com>
[not found] ` <e45d974b-5eff-f781-291f-ddf5e9679e4c@gmail.com>
[not found] ` <20190530183556.GR374014@devbig004.ftw2.facebook.com>
[not found] ` <20190530183637.GS374014@devbig004.ftw2.facebook.com>
[not found] ` <20190530183700.GT374014@devbig004.ftw2.facebook.com>
[not found] ` <20190607170952.GE30727@blackbody.suse.cz>
[not found] ` <20190611185742.GH3341036@devbig004.ftw2.facebook.com>
[not found] ` <20190611185742.GH3341036-LpCCV3molIbIZ9tKgghJQw2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2020-01-10 21:47 ` [PATCH 3/3 cgroup/for-5.2-fixes] cgroup: Include dying leaders with live threads in PROCS iterations Suren Baghdasaryan
[not found] ` <CAJuCfpGkAsmp5B=fNz38fLE8pYaMCG=uLDSSBFByNOtWD20zVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-01-10 21:56 ` Tejun Heo
[not found] ` <20200110215648.GC2677547-LpCCV3molIbIZ9tKgghJQw2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2020-01-10 22:14 ` Suren Baghdasaryan
[not found] ` <CAJuCfpHPRfV5KDM74JtDepdUJ2G+-3-A3XV+Fzr3Lkbj9nR-Cg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-01-10 22:15 ` Tejun Heo [this message]
[not found] ` <20200110221553.GD2677547-LpCCV3molIbIZ9tKgghJQw2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2020-01-10 22:50 ` Suren Baghdasaryan
2020-01-10 23:16 ` Michal Koutný
2020-01-11 0:00 ` Suren Baghdasaryan
[not found] ` <CAJuCfpG-sn0wPM9GRnCjrmytf=mDC3smsRRd=XQBLAK6ZKoAUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-01-11 0:55 ` Suren Baghdasaryan
[not found] ` <CAJuCfpFeiH_8MbX3qeAKCz_z+XXYp9M2KrnkOsBoN5jGoV7=eg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-01-16 4:26 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110221553.GD2677547@devbig004.ftw2.facebook.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=guro-b10kYP2dOMg@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=james.hsu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org \
--cc=linger.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mkoutny-IBi9RG/b67k@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=security-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org \
--cc=security-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=toiwoton-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tomcherry-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.