From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [linux-next:master 7285/7838] drivers/nvmem/core.c:354:31: sparse: sparse: incorrect type in return expression (different base types)
Date: Sat, 11 Jan 2020 10:26:27 +0800 [thread overview]
Message-ID: <202001111002.KODcsif7%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4895 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 6c09d7dbb7d366122d0218bc7487e0a1e6cca6ed
commit: 2a127da461a9d8d97782d6e82b227041393eb4d2 [7285/7838] nvmem: add support for the write-protect pin
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-129-g341daf20-dirty
git checkout 2a127da461a9d8d97782d6e82b227041393eb4d2
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/nvmem/core.c:354:31: sparse: sparse: incorrect type in return expression (different base types)
>> drivers/nvmem/core.c:354:31: sparse: expected struct nvmem_device *
>> drivers/nvmem/core.c:354:31: sparse: got long
vim +354 drivers/nvmem/core.c
320
321 /**
322 * nvmem_register() - Register a nvmem device for given nvmem_config.
323 * Also creates an binary entry in /sys/bus/nvmem/devices/dev-name/nvmem
324 *
325 * @config: nvmem device configuration with which nvmem device is created.
326 *
327 * Return: Will be an ERR_PTR() on error or a valid pointer to nvmem_device
328 * on success.
329 */
330
331 struct nvmem_device *nvmem_register(const struct nvmem_config *config)
332 {
333 struct nvmem_device *nvmem;
334 int rval;
335
336 if (!config->dev)
337 return ERR_PTR(-EINVAL);
338
339 nvmem = kzalloc(sizeof(*nvmem), GFP_KERNEL);
340 if (!nvmem)
341 return ERR_PTR(-ENOMEM);
342
343 rval = ida_simple_get(&nvmem_ida, 0, 0, GFP_KERNEL);
344 if (rval < 0) {
345 kfree(nvmem);
346 return ERR_PTR(rval);
347 }
348 if (config->wp_gpio)
349 nvmem->wp_gpio = config->wp_gpio;
350 else
351 nvmem->wp_gpio = gpiod_get_optional(config->dev, "wp",
352 GPIOD_OUT_HIGH);
353 if (IS_ERR(nvmem->wp_gpio))
> 354 return PTR_ERR(nvmem->wp_gpio);
355
356
357 kref_init(&nvmem->refcnt);
358 INIT_LIST_HEAD(&nvmem->cells);
359
360 nvmem->id = rval;
361 nvmem->owner = config->owner;
362 if (!nvmem->owner && config->dev->driver)
363 nvmem->owner = config->dev->driver->owner;
364 nvmem->stride = config->stride ?: 1;
365 nvmem->word_size = config->word_size ?: 1;
366 nvmem->size = config->size;
367 nvmem->dev.type = &nvmem_provider_type;
368 nvmem->dev.bus = &nvmem_bus_type;
369 nvmem->dev.parent = config->dev;
370 nvmem->priv = config->priv;
371 nvmem->type = config->type;
372 nvmem->reg_read = config->reg_read;
373 nvmem->reg_write = config->reg_write;
374 if (!config->no_of_node)
375 nvmem->dev.of_node = config->dev->of_node;
376
377 if (config->id == -1 && config->name) {
378 dev_set_name(&nvmem->dev, "%s", config->name);
379 } else {
380 dev_set_name(&nvmem->dev, "%s%d",
381 config->name ? : "nvmem",
382 config->name ? config->id : nvmem->id);
383 }
384
385 nvmem->read_only = device_property_present(config->dev, "read-only") ||
386 config->read_only || !nvmem->reg_write;
387
388 nvmem->dev.groups = nvmem_sysfs_get_groups(nvmem, config);
389
390 device_initialize(&nvmem->dev);
391
392 dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", config->name);
393
394 rval = device_add(&nvmem->dev);
395 if (rval)
396 goto err_put_device;
397
398 if (config->compat) {
399 rval = nvmem_sysfs_setup_compat(nvmem, config);
400 if (rval)
401 goto err_device_del;
402 }
403
404 if (config->cells) {
405 rval = nvmem_add_cells(nvmem, config->cells, config->ncells);
406 if (rval)
407 goto err_teardown_compat;
408 }
409
410 rval = nvmem_add_cells_from_table(nvmem);
411 if (rval)
412 goto err_remove_cells;
413
414 rval = nvmem_add_cells_from_of(nvmem);
415 if (rval)
416 goto err_remove_cells;
417
418 blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem);
419
420 return nvmem;
421
422 err_remove_cells:
423 nvmem_device_remove_all_cells(nvmem);
424 err_teardown_compat:
425 if (config->compat)
426 nvmem_sysfs_remove_compat(nvmem, config);
427 err_device_del:
428 device_del(&nvmem->dev);
429 err_put_device:
430 put_device(&nvmem->dev);
431
432 return ERR_PTR(rval);
433 }
434 EXPORT_SYMBOL_GPL(nvmem_register);
435
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
next reply other threads:[~2020-01-11 2:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 2:26 kbuild test robot [this message]
2020-01-11 10:25 ` [linux-next:master 7285/7838] drivers/nvmem/core.c:354:31: sparse: sparse: incorrect type in return expression (different base types) Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001111002.KODcsif7%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.