From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 11 Jan 2020 15:35:37 +0100 Subject: [Buildroot] [PATCH 1/1] package/poppler: really disable test programs In-Reply-To: <20200111115054.864819-1-fontaine.fabrice@gmail.com> References: <20200111115054.864819-1-fontaine.fabrice@gmail.com> Message-ID: <20200111153537.66974300@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Sat, 11 Jan 2020 12:50:54 +0100 Fabrice Fontaine wrote: > Signed-off-by: Fabrice Fontaine > --- > ...1-CMakeLists.txt-fix-BUILD_CPP_TESTS.patch | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 package/poppler/0001-CMakeLists.txt-fix-BUILD_CPP_TESTS.patch > > diff --git a/package/poppler/0001-CMakeLists.txt-fix-BUILD_CPP_TESTS.patch b/package/poppler/0001-CMakeLists.txt-fix-BUILD_CPP_TESTS.patch > new file mode 100644 > index 0000000000..476676199a > --- /dev/null > +++ b/package/poppler/0001-CMakeLists.txt-fix-BUILD_CPP_TESTS.patch > @@ -0,0 +1,32 @@ > +From ccc5f765c37b2d65e2e0b64d92326997f90acb3e Mon Sep 17 00:00:00 2001 > +From: Fabrice Fontaine > +Date: Sat, 11 Jan 2020 12:37:07 +0100 > +Subject: [PATCH] CMakeLists.txt: fix BUILD_CPP_TESTS > + > +Do not build programs under the test directory if BUILD_CPP_TESTS is OFF > +as this directory contains multiple C++ test executables What is the problem with C++ executables, since poppler depends on C++ anyway ? Of course, it is good to disable building tests if possible, but I'm just curious to understand the motivation for the change: did you encounter a build failure? Or it is just that you realized the tests were being built while they should not? Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com