Re: [RFC PATCH V2 08/12] fs/xfs: Add lock/unlock mode to xfs

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4002 bytes --]

Hi,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on xfs-linux/for-next]
[also build test ERROR on linux/master linus/master v5.5-rc5]
[cannot apply to djwong-xfs/djwong-devel next-20200110]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/ira-weiny-intel-com/Enable-per-file-directory-DAX-operations-V2/20200111-095526
base:   https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs/xfs/xfs_inode.c: In function 'xfs_isilocked':
>> fs/xfs/xfs_inode.c:394:43: error: macro "percpu_rwsem_is_held" passed 2 arguments, but takes just 1
        percpu_rwsem_is_held(&ip->i_dax_sem, 0);
                                              ^
>> fs/xfs/xfs_inode.c:394:5: error: 'percpu_rwsem_is_held' undeclared (first use in this function); did you mean 'percpu_ref_is_zero'?
        percpu_rwsem_is_held(&ip->i_dax_sem, 0);
        ^~~~~~~~~~~~~~~~~~~~
        percpu_ref_is_zero
   fs/xfs/xfs_inode.c:394:5: note: each undeclared identifier is reported only once for each function it appears in
>> fs/xfs/xfs_inode.c:395:26: error: passing argument 1 of 'rwsem_is_locked' from incompatible pointer type [-Werror=incompatible-pointer-types]
      return rwsem_is_locked(&ip->i_dax_sem);
                             ^
   In file included from include/linux/mm_types.h:11:0,
                    from include/linux/mmzone.h:21,
                    from include/linux/gfp.h:6,
                    from include/linux/xarray.h:14,
                    from include/linux/radix-tree.h:18,
                    from include/linux/fs.h:15,
                    from include/linux/iversion.h:5,
                    from fs/xfs/xfs_inode.c:6:
   include/linux/rwsem.h:63:19: note: expected 'struct rw_semaphore *' but argument is of type 'struct percpu_rw_semaphore *'
    static inline int rwsem_is_locked(struct rw_semaphore *sem)
                      ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/percpu_rwsem_is_held +394 fs/xfs/xfs_inode.c

   365	
   366	#if defined(DEBUG) || defined(XFS_WARN)
   367	int
   368	xfs_isilocked(
   369		xfs_inode_t		*ip,
   370		uint			lock_flags)
   371	{
   372		if (lock_flags & (XFS_ILOCK_EXCL|XFS_ILOCK_SHARED)) {
   373			if (!(lock_flags & XFS_ILOCK_SHARED))
   374				return !!ip->i_lock.mr_writer;
   375			return rwsem_is_locked(&ip->i_lock.mr_lock);
   376		}
   377	
   378		if (lock_flags & (XFS_MMAPLOCK_EXCL|XFS_MMAPLOCK_SHARED)) {
   379			if (!(lock_flags & XFS_MMAPLOCK_SHARED))
   380				return !!ip->i_mmaplock.mr_writer;
   381			return rwsem_is_locked(&ip->i_mmaplock.mr_lock);
   382		}
   383	
   384		if (lock_flags & (XFS_IOLOCK_EXCL|XFS_IOLOCK_SHARED)) {
   385			if (!(lock_flags & XFS_IOLOCK_SHARED))
   386				return !debug_locks ||
   387					lockdep_is_held_type(&VFS_I(ip)->i_rwsem, 0);
   388			return rwsem_is_locked(&VFS_I(ip)->i_rwsem);
   389		}
   390	
   391		if (lock_flags & (XFS_DAX_EXCL|XFS_DAX_SHARED)) {
   392			if (!(lock_flags & XFS_DAX_SHARED))
   393				return !debug_locks ||
 > 394					percpu_rwsem_is_held(&ip->i_dax_sem, 0);
 > 395			return rwsem_is_locked(&ip->i_dax_sem);
   396		}
   397	
   398		ASSERT(0);
   399		return 0;
   400	}
   401	#endif
   402	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28789 bytes --]