From: Wei Yang <richardw.yang@linux.intel.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com,
akpm@linux-foundation.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kirill.shutemov@linux.intel.com, yang.shi@linux.alibaba.com,
alexander.duyck@gmail.com, rientjes@google.com
Subject: Re: [Patch v2] mm: thp: grab the lock before manipulation defer list
Date: Mon, 13 Jan 2020 16:23:08 +0800 [thread overview]
Message-ID: <20200113082308.GB27972@richard> (raw)
In-Reply-To: <20200113073614.jo2txcmazwlesl7b@box.shutemov.name>
On Mon, Jan 13, 2020 at 10:36:14AM +0300, Kirill A. Shutemov wrote:
>On Mon, Jan 13, 2020 at 08:44:57AM +0800, Wei Yang wrote:
>> >> It is possible two page in the same pgdate or memcg grab page lock
>> >> respectively and then access the same defer queue concurrently.
>>
>> If my understanding is correct, you agree with my statement?
>
>Which one? If the one above then no. list_empty only accesses list_head
>for the struct page, not the queue.
>
Ah, I get your point.
>--
> Kirill A. Shutemov
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2020-01-13 8:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 14:30 [Patch v2] mm: thp: grab the lock before manipulation defer list Wei Yang
2020-01-09 18:52 ` David Rientjes
2020-01-09 18:58 ` Michal Hocko
2020-01-11 0:03 ` Kirill A. Shutemov
2020-01-12 2:28 ` Wei Yang
2020-01-12 22:57 ` Kirill A. Shutemov
2020-01-13 0:44 ` Wei Yang
2020-01-13 7:36 ` Kirill A. Shutemov
2020-01-13 7:36 ` Kirill A. Shutemov
2020-01-13 8:23 ` Wei Yang [this message]
2020-01-14 9:31 ` Michal Hocko
2020-01-14 9:31 ` Michal Hocko
2020-01-14 10:31 ` Kirill A. Shutemov
2020-01-14 10:59 ` Kirill A. Shutemov
2020-01-14 20:57 ` David Rientjes
2020-01-15 1:19 ` Wei Yang
2020-01-15 1:07 ` Wei Yang
2020-01-15 1:07 ` Wei Yang
2020-01-15 3:26 ` David Rientjes
2020-01-15 3:26 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113082308.GB27972@richard \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.