From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============0146879648085008899=="
MIME-Version: 1.0
From: Krzysztof Kozlowski <krzk@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 1/2] i2c: Enable compile testing for some of drivers
Date: Mon, 13 Jan 2020 11:46:54 +0100
Message-ID: <20200113102733.GA1965@pi3>
In-Reply-To: <202001090146.Z0aZqj3N%lkp@intel.com>
List-Id: <oe-kbuild-all.lists.linux.dev>

--===============0146879648085008899==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 09, 2020 at 01:21:28AM +0800, kbuild test robot wrote:
> Hi Krzysztof,
> =

> I love your patch! Perhaps something to improve:
> =

> [auto build test WARNING on wsa/i2c/for-next]
> [also build test WARNING on v5.5-rc5 next-20200106]
> [if your patch is applied to the wrong git tree, please drop us a note to=
 help
> improve the system. BTW, we also suggest to use '--base' option to specif=
y the
> base tree in git format-patch, please see https://stackoverflow.com/a/374=
06982]
> =

> url:    https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/i2c-=
Enable-compile-testing-for-some-of-drivers/20200107-164808
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c=
/for-next
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.1-129-g341daf20-dirty
>         make ARCH=3Dx86_64 allmodconfig
>         make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> =

> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> =

> =

> sparse warnings: (new ones prefixed by >>)
> =

> >> drivers/i2c/busses/i2c-stu300.c:446:17: sparse: sparse: cast removes a=
ddress space '<asn:2>' of expression

I fixed this already here:
https://lore.kernel.org/lkml/20191230172751.17985-4-krzk(a)kernel.org/

Best regards,
Krzysztof


> =

> vim +446 drivers/i2c/busses/i2c-stu300.c
> =

> 18904c0ecdf2cf Linus Walleij 2009-06-13  421  =

> 18904c0ecdf2cf Linus Walleij 2009-06-13  422  /*
> 18904c0ecdf2cf Linus Walleij 2009-06-13  423   * Waits for the busy bit t=
o go low by repeated polling.
> 18904c0ecdf2cf Linus Walleij 2009-06-13  424   */
> 18904c0ecdf2cf Linus Walleij 2009-06-13  425  #define BUSY_RELEASE_ATTEMP=
TS 10
> 18904c0ecdf2cf Linus Walleij 2009-06-13  426  static int stu300_wait_whil=
e_busy(struct stu300_dev *dev)
> 18904c0ecdf2cf Linus Walleij 2009-06-13  427  {
> 18904c0ecdf2cf Linus Walleij 2009-06-13  428  	unsigned long timeout;
> 18904c0ecdf2cf Linus Walleij 2009-06-13  429  	int i;
> 18904c0ecdf2cf Linus Walleij 2009-06-13  430  =

> 18904c0ecdf2cf Linus Walleij 2009-06-13  431  	for (i =3D 0; i < BUSY_REL=
EASE_ATTEMPTS; i++) {
> 18904c0ecdf2cf Linus Walleij 2009-06-13  432  		timeout =3D jiffies + STU=
300_TIMEOUT;
> 18904c0ecdf2cf Linus Walleij 2009-06-13  433  =

> 18904c0ecdf2cf Linus Walleij 2009-06-13  434  		while (!time_after(jiffie=
s, timeout)) {
> 18904c0ecdf2cf Linus Walleij 2009-06-13  435  			/* Is not busy? */
> 18904c0ecdf2cf Linus Walleij 2009-06-13  436  			if ((stu300_r8(dev->virt=
base + I2C_SR1) &
> 18904c0ecdf2cf Linus Walleij 2009-06-13  437  			     I2C_SR1_BUSY_IND) =
=3D=3D 0)
> 18904c0ecdf2cf Linus Walleij 2009-06-13  438  				return 0;
> 18904c0ecdf2cf Linus Walleij 2009-06-13  439  			msleep(1);
> 18904c0ecdf2cf Linus Walleij 2009-06-13  440  		}
> 18904c0ecdf2cf Linus Walleij 2009-06-13  441  =

> 18904c0ecdf2cf Linus Walleij 2009-06-13  442  		dev_err(&dev->pdev->dev, =
"transaction timed out "
> 18904c0ecdf2cf Linus Walleij 2009-06-13  443  			"waiting for device to b=
e free (not busy). "
> 18904c0ecdf2cf Linus Walleij 2009-06-13  444  		       "Attempt: %d\n", i=
+1);
> 18904c0ecdf2cf Linus Walleij 2009-06-13  445  =

> 18904c0ecdf2cf Linus Walleij 2009-06-13 @446  		dev_err(&dev->pdev->dev, =
"base address =3D "
> 18904c0ecdf2cf Linus Walleij 2009-06-13  447  			"0x%08x, reinit hardware=
\n", (u32) dev->virtbase);
> 18904c0ecdf2cf Linus Walleij 2009-06-13  448  =

> 18904c0ecdf2cf Linus Walleij 2009-06-13  449  		(void) stu300_init_hw(dev=
);
> 18904c0ecdf2cf Linus Walleij 2009-06-13  450  	}
> 18904c0ecdf2cf Linus Walleij 2009-06-13  451  =

> 18904c0ecdf2cf Linus Walleij 2009-06-13  452  	dev_err(&dev->pdev->dev, "=
giving up after %d attempts "
> 18904c0ecdf2cf Linus Walleij 2009-06-13  453  		"to reset the bus.\n",  B=
USY_RELEASE_ATTEMPTS);
> 18904c0ecdf2cf Linus Walleij 2009-06-13  454  =

> 18904c0ecdf2cf Linus Walleij 2009-06-13  455  	return -ETIMEDOUT;
> 18904c0ecdf2cf Linus Walleij 2009-06-13  456  }
> 18904c0ecdf2cf Linus Walleij 2009-06-13  457  =

> =

> :::::: The code at line 446 was first introduced by commit
> :::::: 18904c0ecdf2cf22347da2adc4b273e9570333d8 i2c: ST DDC I2C U300 bus =
driver v3
> =

> :::::: TO: Linus Walleij <linus.walleij@stericsson.com>
> :::::: CC: Ben Dooks <ben-linux@fluff.org>
> =

> ---
> 0-DAY kernel test infrastructure                 Open Source Technology C=
enter
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corp=
oration
--===============0146879648085008899==--