From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/olsr: add netjson plugin
Date: Mon, 13 Jan 2020 12:31:12 +0100 [thread overview]
Message-ID: <20200113123112.28bdfa95@windsurf> (raw)
In-Reply-To: <20200112222754.3769908-1-fontaine.fabrice@gmail.com>
On Sun, 12 Jan 2020 23:27:54 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Add netjson plugin, available since version 0.9.5 and
> https://github.com/OLSR/olsrd/commit/64c00288f8e87d314a723e20c2dd69f1165f1645
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/olsr/olsr.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks. While reviewing this patch, I noticed
olsr.mk uses shell "for" loops for the build/installation of plugins.
Unfortunately, it is done in a way that will ignore errors if one of
the plugins fails to build or install, which is not great. It would be
nice to change these loops to make "foreach" loops, which will
automatically abort if one iteration of the loop returns a non-zero
error code.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-01-13 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 22:27 [Buildroot] [PATCH 1/1] package/olsr: add netjson plugin Fabrice Fontaine
2020-01-13 11:31 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113123112.28bdfa95@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.