From: Greg KH <greg@kroah.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable <stable@vger.kernel.org>,
Martin Jansen <martin.jansen@opticon.com>
Subject: Re: [PATCH] USB: serial: opticon: fix control-message timeouts
Date: Mon, 13 Jan 2020 19:25:46 +0100 [thread overview]
Message-ID: <20200113182546.GF411698@kroah.com> (raw)
In-Reply-To: <20200113172213.30869-1-johan@kernel.org>
On Mon, Jan 13, 2020 at 06:22:13PM +0100, Johan Hovold wrote:
> The driver was issuing synchronous uninterruptible control requests
> without using a timeout. This could lead to the driver hanging
> on open() or tiocmset() due to a malfunctioning (or malicious) device
> until the device is physically disconnected.
>
> The USB upper limit of five seconds per request should be more than
> enough.
>
> Fixes: 309a057932ab ("USB: opticon: add rts and cts support")
> Cc: stable <stable@vger.kernel.org> # 2.6.39
> Cc: Martin Jansen <martin.jansen@opticon.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2020-01-13 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 17:22 [PATCH] USB: serial: opticon: fix control-message timeouts Johan Hovold
2020-01-13 18:25 ` Greg KH [this message]
2020-01-14 11:07 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113182546.GF411698@kroah.com \
--to=greg@kroah.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.jansen@opticon.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.