From: Jiri Pirko <jiri@resnulli.us>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jakub Kicinski <kubakici@wp.pl>,
Yunsheng Lin <linyunsheng@huawei.com>,
Alex Vesker <valex@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] devlink region trigger support
Date: Mon, 13 Jan 2020 19:33:04 +0100 [thread overview]
Message-ID: <20200113183304.GI2131@nanopsycho> (raw)
In-Reply-To: <28bc8945-6c55-2ad3-963a-156efe616038@intel.com>
Mon, Jan 13, 2020 at 07:16:51PM CET, jacob.e.keller@intel.com wrote:
>On 1/13/2020 3:34 AM, Jakub Kicinski wrote:
>> On Mon, 13 Jan 2020 09:39:50 +0800, Yunsheng Lin wrote:
>>> I am not sure I understand "live region" here, what is the usecase of live
>>> region?
>>
>> Reading registers of a live system without copying them to a snapshot
>> first. Some chips have so many registers it's impractical to group them
>> beyond "registers of IP block X", if that. IMHO that fits nicely with
>> regions, health is grouped by event, so we'd likely want to dump for
>> example one or two registers from the MAC there, while the entire set
>> of MAC registers can be exposed as a region.
>>
>
>Right. I'm actually wondering about this as well. Region snapshots are
>captured in whole and stored and then returned through the devlink
>region commands.
Well, driver does not have to support snapshots for particular region,
only live reading. Yes, this needs to be implemented.
>
>This could be problematic if you wanted to expose a larger chunk of
>registers or addressable sections of flash contents, as the size of the
>contents goes beyond a single page.
>
>If we instead focus regions onto the live-read aspect, the API can
>simply be a request to read a segment of the region. Then, the driver
>could perform the read of that chunk and report it back.
Yep.
next prev parent reply other threads:[~2020-01-13 18:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 19:33 [PATCH v2 0/3] devlink region trigger support Jacob Keller
2020-01-09 19:33 ` [PATCH v2 1/3] devlink: add callback to trigger region snapshots Jacob Keller
2020-01-09 19:33 ` [PATCH v2 1/1] devlink: add support for DEVLINK_CMD_REGION_TRIGGER Jacob Keller
2020-01-09 19:33 ` [PATCH v2 2/3] devlink: introduce command to trigger region snapshot Jacob Keller
2020-01-09 19:33 ` [PATCH v2 3/3] netdevsim: support triggering snapshot through devlink Jacob Keller
2020-01-09 20:13 ` [PATCH v2 0/3] devlink region trigger support Jacob Keller
2020-01-10 4:10 ` Yunsheng Lin
2020-01-10 17:52 ` Jacob Keller
2020-01-11 1:51 ` Yunsheng Lin
2020-01-12 20:45 ` Jakub Kicinski
2020-01-12 21:18 ` Alex Vesker
2020-01-13 1:39 ` Yunsheng Lin
2020-01-13 11:34 ` Jakub Kicinski
2020-01-13 18:16 ` Jacob Keller
2020-01-13 18:33 ` Jiri Pirko [this message]
2020-01-13 16:58 ` Jiri Pirko
2020-01-13 18:22 ` Jacob Keller
2020-01-13 18:33 ` Jiri Pirko
2020-01-14 8:33 ` Yunsheng Lin
2020-01-14 20:04 ` Jacob Keller
2020-01-15 8:36 ` Yunsheng Lin
2020-01-10 9:40 ` Jiri Pirko
2020-01-10 17:54 ` Jacob Keller
2020-01-10 18:47 ` Jakub Kicinski
2020-01-10 18:57 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113183304.GI2131@nanopsycho \
--to=jiri@resnulli.us \
--cc=jacob.e.keller@intel.com \
--cc=kubakici@wp.pl \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.