From: Tony Lindgren <tony@atomide.com>
To: Faiz Abbas <faiz_abbas@ti.com>, Keerthy <j-keerthy@ti.com>,
Dave Gerlach <d-gerlach@ti.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
mark.rutland@arm.com, robh+dt@kernel.org, bcousson@baylibre.com,
kishon@ti.com
Subject: Re: [PATCH] arm: dts: Move am33xx and am43xx mmc nodes to sdhci-omap driver
Date: Mon, 13 Jan 2020 10:44:44 -0800 [thread overview]
Message-ID: <20200113184444.GO5885@atomide.com> (raw)
In-Reply-To: <ab908007-fd7d-9dd5-c822-f4058c793d7d@ti.com>
Hi,
* Faiz Abbas <faiz_abbas@ti.com> [200109 13:57]:
> Hi,
>
> On 06/01/20 4:45 pm, Faiz Abbas wrote:
> > Move mmc nodes to be compatible with the sdhci-omap driver. The following
> > modifications are required for omap_hsmmc specific properties:
> >
> > ti,non-removable: convert to the generic mmc non-removable
> > ti,needs-special-reset: co-opted into the sdhci-omap driver
> > ti,dual-volt: removed. Legacy property not used in am335x or am43xx
> > ti,needs-special-hs-handling: removed. Legacy property not used in am335x or am43xx
> >
> > Also since the sdhci-omap driver does not support runtime PM, explicitly
> > disable the mmc3 instance in the dtsi.
> >
> > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> > ---
> >
> > Driver modifications have been posted separately:
> > https://patchwork.kernel.org/project/linux-mmc/list/?series=224053
> >
> > Tested on: am335x-evm, am335x-boneblack, am335x-sk, am335x-bone, am437x-idk,
> > am43xx-gp-evm, am43xx-epos-evm.
> >
> > I need some help with testing all other am335x variants and SDIO cards.
> >
> > Here's a branch for testing: https://github.com/faizinator/linux/tree/sdhci-omap_v4_2
> >
>
> Tony, can you help test some of these boards?
I have your branch above a quick boot test on bbb and am437x-idk and both
detected MMC just fine :)
I guess up to Dave and Keerthy to check if this conversion can be done
without missing runtime PM support, any comments?
I guess it should not be hard implement runtime PM support for
autosuspend in sdhci-omap.c?
Regards,
Tony
prev parent reply other threads:[~2020-01-13 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 11:15 [PATCH] arm: dts: Move am33xx and am43xx mmc nodes to sdhci-omap driver Faiz Abbas
2020-01-06 11:15 ` Faiz Abbas
2020-01-09 13:58 ` Faiz Abbas
2020-01-09 13:58 ` Faiz Abbas
2020-01-13 18:44 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113184444.GO5885@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=j-keerthy@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.