From: Rob Herring <robh@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: guillaume La Roque <glaroque@baylibre.com>,
marcel@holtmann.org, johan.hedberg@gmail.com,
devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org,
nsaenzjulienne@suse.de, linux-kernel@vger.kernel.org,
khilman@baylibre.com
Subject: Re: [PATCH v6 1/2] dt-bindings: net: bluetooth: add interrupts properties
Date: Mon, 13 Jan 2020 16:37:25 -0600 [thread overview]
Message-ID: <20200113223725.GA22169@bogus> (raw)
In-Reply-To: <20200109132917.GM30908@localhost>
On Thu, Jan 09, 2020 at 02:29:17PM +0100, Johan Hovold wrote:
> On Thu, Jan 09, 2020 at 02:13:23PM +0100, guillaume La Roque wrote:
> >
> > On 1/9/20 11:53 AM, Johan Hovold wrote:
> > > On Thu, Jan 09, 2020 at 11:42:56AM +0100, Guillaume La Roque wrote:
> > >> add interrupts and interrupt-names as optional properties
> > >> to support host-wakeup by interrupt properties instead of
> > >> host-wakeup-gpios.
> > >>
> > >> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> > >> ---
> > >> Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 4 +++-
> > >> 1 file changed, 3 insertions(+), 1 deletion(-)
> > >>
> > >> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > >> index c44a30dbe43d..d33bbc998687 100644
> > >> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > >> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > >> @@ -37,7 +37,9 @@ Optional properties:
> > >> - pcm-frame-type: short, long
> > >> - pcm-sync-mode: slave, master
> > >> - pcm-clock-mode: slave, master
> > >> -
> > >> + - interrupts: must be one, used to wakeup the host processor if
> > >> + gpiod_to_irq function not supported
> > >> + - interrupt-names: must be "host-wakeup"
> > > Looks like you forgot to address Rob's comment. If I understood him
> > > correctly you either need to stick with "host-wakeup-gpios" (and fix
> > > your platform) or deprecate it in favour of "interrupts":
> > >
> > > https://lkml.kernel.org/r/20191218203818.GA8009@bogus
> >
> > not forgot marcel ask me a v6
>
> Not much point in sending v6 before addressing feedback on v5.
> Especially as Marcel asked for a v6 with acks. ;)
>
> > for rob comment ok but it's not possible to support gpiod_to_irq on my
> > platform.
> >
> > if i deprecated it i need to update all DT with good interrupt number
> > right?
>
> Not sure. Perhaps just updating the binding is enough. Rob?
Correct. Just need to reflect in the binding which way is preferred. If
it's a case of update all the dts files, then we often just don't
document the old way.
Rob
next prev parent reply other threads:[~2020-01-13 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 10:42 [PATCH v6 0/2] add support of interrupt for host wakeup from devicetree in BCM HCI driver Guillaume La Roque
2020-01-09 10:42 ` [PATCH v6 1/2] dt-bindings: net: bluetooth: add interrupts properties Guillaume La Roque
2020-01-09 10:53 ` Johan Hovold
2020-01-09 13:13 ` guillaume La Roque
2020-01-09 13:29 ` Johan Hovold
2020-01-13 22:37 ` Rob Herring [this message]
2020-01-09 10:42 ` [PATCH v6 2/2] bluetooth: hci_bcm: enable IRQ capability from devicetree Guillaume La Roque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113223725.GA22169@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=johan.hedberg@gmail.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.