From: Sudeep Holla <sudeep.holla@arm.com>
To: "Zengtao (B)" <prime.zeng@hisilicon.com>
Cc: Linuxarm <linuxarm@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v2] cpu-topology: Skip the exist but not possible cpu nodes
Date: Tue, 14 Jan 2020 10:29:56 +0000 [thread overview]
Message-ID: <20200114102956.GB10403@bogus> (raw)
In-Reply-To: <678F3D1BB717D949B966B68EAEB446ED340E59BA@DGGEMM506-MBX.china.huawei.com>
On Tue, Jan 14, 2020 at 01:42:25AM +0000, Zengtao (B) wrote:
> Could you help to explain here?
> I understand there are two abnormal cases:
> 1. The cpu node exist in the device tree, but not a possible cpu.
> This case can be caught by of_cpu_node_to_id's return value.
Yes if of_cpu_node_to_id returns -ENODEV, it means there's no logical
CPU associated with this DT node.
> 2. The cpu node does not exist. This case can be caught by above logic. Or
> do you think of_parse_phandle's return value is enough?
Again yes, there's nothing extra needed.
The only change you need is to consider -ENODEV while handling the case(1)
--
Regards,
Sudeep
next prev parent reply other threads:[~2020-01-14 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 6:53 [PATCH v2] cpu-topology: Skip the exist but not possible cpu nodes Zeng Tao
2020-01-13 10:19 ` Sudeep Holla
2020-01-13 12:06 ` Zengtao (B)
2020-01-13 12:21 ` Sudeep Holla
2020-01-14 1:42 ` Zengtao (B)
2020-01-14 10:29 ` Sudeep Holla [this message]
2020-01-14 12:17 ` Zengtao (B)
2020-01-14 14:48 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114102956.GB10403@bogus \
--to=sudeep.holla@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.