From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07678C33C9E for ; Tue, 14 Jan 2020 18:06:04 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD37E214AF for ; Tue, 14 Jan 2020 18:06:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="e21hwtLh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD37E214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1irQZQ-00059p-C9; Tue, 14 Jan 2020 18:05:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1irQZO-00059k-IS for xen-devel@lists.xenproject.org; Tue, 14 Jan 2020 18:05:38 +0000 X-Inumbo-ID: 72bfd550-36f8-11ea-b89f-bc764e2007e4 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 72bfd550-36f8-11ea-b89f-bc764e2007e4; Tue, 14 Jan 2020 18:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1579025129; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=crf+I3wnXQ44AOltWJZ4HXcnTWZ7HnfpUxIZ9muk0MY=; b=e21hwtLhIWjyuoNwh4CRqfNnBI5PUKwSJZ/BnqF4DkmPDw9I6XYuj4zo FZmV9+xmnVTWQL1c5aIoxzxKSVbjG56Tlp2j9KlbCF6cxtb5tpSEV4E2S osmvMmMch1ZNhAk/B5ImhZ83B5/FS9DKAVBmhbUXsDTgtUs+f4v6er3MQ 0=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Sc3x1A6ID8s2CRScL6qhKxLOGme1y5VckC7IpP3FcCYuozqQgeLOBq5bi3GutB0/k9Jr+AM8RA mU85K38Cx6AHDCJrfOyNYaekmecteLwAasW/qnzbYI/JTz2nNowJ6DBTcM3GD857w6wHs7ItyB UpKil7h9e9V7Kl+DmQssouvx0GpMt/q8h+KeuP4d8vT+ZuAkYgXyennTr7jzIyA4+16qzA7idK QPlUNfnA23yAJeN611WaAszBuoKJT930wcyrXNLTy/rbPg6a/kmtIQk/ubIJMsfod6yRFdfh/4 HZM= X-SBRS: 2.7 X-MesageID: 11335295 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,319,1574139600"; d="scan'208";a="11335295" Date: Tue, 14 Jan 2020 19:04:57 +0100 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= To: Jason Andryuk Message-ID: <20200114180457.GG11756@Air-de-Roger> References: <57dc1083d20a469785f05a2e5250a820@AMSPEX02CL02.citrite.net> <20190322030936.fkiajz5ifgaejkd4@MacBook-Air-de-Roger.local> <20200114100406.GF11756@Air-de-Roger> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL01.citrite.net (10.69.22.125) Subject: Re: [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Andrew Cooper , Paul Durrant , "marmarek@invisiblethingslab.com" , "qemu-devel@nongnu.org" , Simon Gaiser , Anthony Perard , "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gVHVlLCBKYW4gMTQsIDIwMjAgYXQgMDk6NDE6NDZBTSAtMDUwMCwgSmFzb24gQW5kcnl1ayB3 cm90ZToKPiBPbiBUdWUsIEphbiAxNCwgMjAyMCBhdCA1OjA0IEFNIFJvZ2VyIFBhdSBNb25uw6kg PHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToKPiA+Cj4gPiBPbiBNb24sIEphbiAxMywgMjAy MCBhdCAwMjowMTo0N1BNIC0wNTAwLCBKYXNvbiBBbmRyeXVrIHdyb3RlOgo+ID4gPiBPbiBGcmks IE1hciAyMiwgMjAxOSBhdCAzOjQzIFBNIEphc29uIEFuZHJ5dWsgPGphbmRyeXVrQGdtYWlsLmNv bT4gd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiBPbiBUaHUsIE1hciAyMSwgMjAxOSBhdCAxMTowOSBQ TSBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4gd3JvdGU6Cj4gPiA+ID4g Pgo+ID4gPiA+ID4gVGhlIHBhdGNoIGJlbG93IHNob3VsZCBwcmV2ZW50IGh2bWxvYWRlciBmcm9t IHBsYWNpbmcgbXVsdGlwbGUgQkFScyBvbgo+ID4gPiA+ID4gdGhlIHNhbWUgcGFnZSwgY291bGQg eW91IGdpdmUgaXQgYSB0cnk/Cj4gPiA+ID4gPgo+ID4gPiA+ID4gTm90ZSB0aGF0IHRoaXMgaXMg bm90IGdvaW5nIHRvIHByZXZlbnQgdGhlIGd1ZXN0IGZyb20gbW92aW5nIHRob3NlCj4gPiA+ID4g PiBCQVJzIGFyb3VuZCBhbmQgcGxhY2UgdGhlbSBpbiB0aGUgc2FtZSBwYWdlLCB0aHVzIGJyZWFr aW5nIHRoZSBpbml0aWFsCj4gPiA+ID4gPiBwbGFjZW1lbnQgZG9uZSBieSBodm1sb2FkZXIuCj4g PiA+ID4gPgo+ID4gPiA+ID4gVGhhbmtzLCBSb2dlci4KPiA+ID4gPgo+ID4gPiA+IEhpLCBSb2dl ci4KPiA+ID4gPgo+ID4gPiA+IEkndmUgbWluaW1hbGx5IHRlc3RlZCB0aGlzLiAgWWVzLCB0aGlz IHBhdGNoIHNlZW1zIHRvIHBsYWNlIHNtYWxsIEJBUnMKPiA+ID4gPiBpbnRvIHNlcGFyYXRlIHBh Z2VzLiAgVGhlIGxpbnV4IHN0dWJkb20gYW5kIFFFTVUgdGhlbiB1c2UgdGhlIHNwYWNpbmcKPiA+ ID4gPiBhcyBwcm92aWRlZCBieSBodm1sb2FkZXIuCj4gPiA+Cj4gPiA+IFJvZ2VyLAo+ID4gPgo+ ID4gPiBXb3VsZCB5b3UgbWluZCBzdWJtaXR0aW5nIHRoaXMgcGF0Y2ggdG8gWGVuPwo+ID4KPiA+ IEhtLCBJJ20gaGFsZiBtaW5kZWQgcmVnYXJkaW5nIHRoaXMgcGF0Y2guIEl0IGZlZWxzIG1vcmUg bGlrZSBhIGJhbmRhaWQKPiA+IHRoYW4gYSBwcm9wZXIgc29sdXRpb24uIE1hcHBpbmcgQkFScyBu b3QgbXVsdGlwbGUgb2YgcGFnZS1zaXplcyBpcwo+ID4gZGFuZ2Vyb3VzIGJlY2F1c2UgQUZBSUsg dGhlcmUncyBubyBlbnRpdHkgdGhhdCBhc3NlcnRzIHRoZXJlIGlzbid0IGFueQo+ID4gb3RoZXIg QkFSIGZyb20gYSBkaWZmZXJlbnQgZGV2aWNlIG9uIHRoZSBzYW1lIHBhZ2UsIGFuZCBoZW5jZSB5 b3UKPiA+IG1pZ2h0IGVuZCB1cCBtYXBwaW5nIHNvbWUgTU1JTyByZWdpb24gZnJvbSBhbm90aGVy IGRldmljZQo+ID4gaW5hZHZlcnRlbnRseS4KPiAKPiBXZSBoYXZlIHRoZSBndWVzdCwgbGludXgg c3R1YmRvbSB3aXRoIHFlbXUsICYgZG9tMC4gQXJlIHlvdSBjb25jZXJuZWQKPiB0aGF0IGFsbCBv ZiB0aGVtIG5lZWQgYSBtaW5pbXVtIG9mIHBhZ2UgYWxpZ25tZW50PwoKTm8sIG5vdCByZWFsbHku IFRoZSBoYXJkd2FyZSBkb21haW4gKGRvbTAgaW4gbm9ybWFsIGRlcGxveW1lbnRzKQpzaG91bGQg YmUgdGhlIG9uZSB0aGF0IG1ha2VzIHN1cmUgdGhlcmUgYXJlIG5vIEJBUnMgc2hhcmluZyBwaHlz aWNhbApwYWdlcy4KCj4gTGludXggUENJIHN1YnN5dGVtIGhhcyBhbiBvcHRpb24gcmVzb3VyY2Vf YWxpZ25tZW50IHRoYXQgY2FuIGJlCj4gYXBwbGllZCB0byBlaXRoZXIgYSBzaW5nbGUgZGV2aWNl IG9yIGFsbCBkZXZpY2VzLiAgQm9vdGluZyB3aXRoCj4gcGNpPXJlc291cmNlX2FsaWdtZW50PTQw OTYgd2lsbCBhbGlnbiBlYWNoIGRldmljZSB0byBhIHBhZ2UuICBEbyB5b3UKPiB0aGluayBwY2li YWNrIHNob3VsZCBmb3JjZSByZXNvdXJjZV9hbGlnbm1lbnQ9NDA5NiBmb3IgZG9tMD8KCklkZWFs bHkgWGVuIHNob3VsZCBrZWVwIHRyYWNrIG9mIHRoZSBCQVJzIHBvc2l0aW9uIGFuZCBzaXplIGFu ZCByZWZ1c2UKdG8gcGFzc3Rocm91Z2ggZGV2aWNlcyB0aGF0IGhhdmUgQkFScyBzaGFyaW5nIGEg cGFnZSB3aXRoIG90aGVyCmRldmljZXMgQkFScy4KCj4gQXJlCj4gdGhlcmUgb3RoZXIgTU1JTyBy YW5nZXMgdG8gYmUgY29uY2VybmVkIGFib3V0IGFkamFjZW50IHRvIEJBUnM/CgpJSVJDIHlvdSBj YW4gaGF2ZSB0d28gQkFScyBvZiBkaWZmZXJlbnQgZGV2aWNlcyBpbiB0aGUgc2FtZSA0SyBwYWdl LApCQVJzIGFyZSBvbmx5IGFsaWduZWQgdG8gaXQncyBzaXplLCBzbyBCQVJzIHNtYWxsZXIgdGhh biA0SyBhcmUgbm90CnJlcXVpcmVkIHRvIGJlIHBhZ2UgYWxpZ25lZC4KCj4gT24gbXkgb25lIHRl c3QgbWFjaGluZSB3aXRoIGEgQkFSIHNtYWxsZXIgdGhhbiA0MDk2LCB0aGUgZmlybXdhcmUKPiBh bHJlYWR5IHNldHMgYW4gYWxpZ25tZW50IG9mIDQwOTYuICBMaW51eCBkb20wIHNlZW1zIHRvIGtl ZXAgdGhlCj4gZmlybXdhcmUgQkFSIGFsaWdubWVudCBieSBkZWZhdWx0LgoKVGhlIFBDSSBzcGVj IHJlY29tbWVuZCBCQVJzIHRvIGJlIHNpemVkIHRvIGEgbXVsdGlwbGUgb2YgYSBwYWdlIHNpemUs IGJ1dApzYWRseSB0aGF0J3Mgbm90IGEgbWFuZGF0b3J5IHJlcXVpcmVtZW50LgoKV2lsbCBzdWJt aXQgdGhlIHBhdGNoIG5vdywgdGhhbmtzIGZvciB0aGUgcGluZywgSSBjb21wbGV0ZWx5IGZvcmdv dAphYm91dCB0aGlzIFRCSC4KClJvZ2VyLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E16AC33CB2 for ; Tue, 14 Jan 2020 18:06:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4E9E2465A for ; Tue, 14 Jan 2020 18:06:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="CReMT7Gh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4E9E2465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irQa2-0004Em-3p for qemu-devel@archiver.kernel.org; Tue, 14 Jan 2020 13:06:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49474) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irQZL-0003hF-VG for qemu-devel@nongnu.org; Tue, 14 Jan 2020 13:05:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irQZH-0008Dt-OL for qemu-devel@nongnu.org; Tue, 14 Jan 2020 13:05:35 -0500 Received: from esa6.hc3370-68.iphmx.com ([216.71.155.175]:62274) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irQZH-0008DL-El for qemu-devel@nongnu.org; Tue, 14 Jan 2020 13:05:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1579025131; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=crf+I3wnXQ44AOltWJZ4HXcnTWZ7HnfpUxIZ9muk0MY=; b=CReMT7Gh6EdV5cdxtpvgDd9J1A4B7J6OPlkeeoHmAO44TsHN/aMtEusG PuRAbD90g2ooJqKn54tPoY6LRJEtSz5IbDP0mVvhtC1BemsjciRG91Bc5 IqBIUqLmJbz0zc6N8hHJTzvaDjXGf3YXE7S2wb7JBbuWBw3adWOTIu1pu k=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Sc3x1A6ID8s2CRScL6qhKxLOGme1y5VckC7IpP3FcCYuozqQgeLOBq5bi3GutB0/k9Jr+AM8RA mU85K38Cx6AHDCJrfOyNYaekmecteLwAasW/qnzbYI/JTz2nNowJ6DBTcM3GD857w6wHs7ItyB UpKil7h9e9V7Kl+DmQssouvx0GpMt/q8h+KeuP4d8vT+ZuAkYgXyennTr7jzIyA4+16qzA7idK QPlUNfnA23yAJeN611WaAszBuoKJT930wcyrXNLTy/rbPg6a/kmtIQk/ubIJMsfod6yRFdfh/4 HZM= X-SBRS: 2.7 X-MesageID: 11335295 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,319,1574139600"; d="scan'208";a="11335295" Date: Tue, 14 Jan 2020 19:04:57 +0100 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= To: Jason Andryuk Subject: Re: [Xen-devel] [PATCH 6/6] xen-pt: Round pci regions sizes to XEN_PAGE_SIZE Message-ID: <20200114180457.GG11756@Air-de-Roger> References: <57dc1083d20a469785f05a2e5250a820@AMSPEX02CL02.citrite.net> <20190322030936.fkiajz5ifgaejkd4@MacBook-Air-de-Roger.local> <20200114100406.GF11756@Air-de-Roger> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL01.citrite.net (10.69.22.125) X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 216.71.155.175 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Andrew Cooper , Paul Durrant , "marmarek@invisiblethingslab.com" , "qemu-devel@nongnu.org" , Simon Gaiser , Anthony Perard , "xen-devel@lists.xenproject.org" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jan 14, 2020 at 09:41:46AM -0500, Jason Andryuk wrote: > On Tue, Jan 14, 2020 at 5:04 AM Roger Pau Monné wrote: > > > > On Mon, Jan 13, 2020 at 02:01:47PM -0500, Jason Andryuk wrote: > > > On Fri, Mar 22, 2019 at 3:43 PM Jason Andryuk wrote: > > > > > > > > On Thu, Mar 21, 2019 at 11:09 PM Roger Pau Monné wrote: > > > > > > > > > > The patch below should prevent hvmloader from placing multiple BARs on > > > > > the same page, could you give it a try? > > > > > > > > > > Note that this is not going to prevent the guest from moving those > > > > > BARs around and place them in the same page, thus breaking the initial > > > > > placement done by hvmloader. > > > > > > > > > > Thanks, Roger. > > > > > > > > Hi, Roger. > > > > > > > > I've minimally tested this. Yes, this patch seems to place small BARs > > > > into separate pages. The linux stubdom and QEMU then use the spacing > > > > as provided by hvmloader. > > > > > > Roger, > > > > > > Would you mind submitting this patch to Xen? > > > > Hm, I'm half minded regarding this patch. It feels more like a bandaid > > than a proper solution. Mapping BARs not multiple of page-sizes is > > dangerous because AFAIK there's no entity that asserts there isn't any > > other BAR from a different device on the same page, and hence you > > might end up mapping some MMIO region from another device > > inadvertently. > > We have the guest, linux stubdom with qemu, & dom0. Are you concerned > that all of them need a minimum of page alignment? No, not really. The hardware domain (dom0 in normal deployments) should be the one that makes sure there are no BARs sharing physical pages. > Linux PCI subsytem has an option resource_alignment that can be > applied to either a single device or all devices. Booting with > pci=resource_aligment=4096 will align each device to a page. Do you > think pciback should force resource_alignment=4096 for dom0? Ideally Xen should keep track of the BARs position and size and refuse to passthrough devices that have BARs sharing a page with other devices BARs. > Are > there other MMIO ranges to be concerned about adjacent to BARs? IIRC you can have two BARs of different devices in the same 4K page, BARs are only aligned to it's size, so BARs smaller than 4K are not required to be page aligned. > On my one test machine with a BAR smaller than 4096, the firmware > already sets an alignment of 4096. Linux dom0 seems to keep the > firmware BAR alignment by default. The PCI spec recommend BARs to be sized to a multiple of a page size, but sadly that's not a mandatory requirement. Will submit the patch now, thanks for the ping, I completely forgot about this TBH. Roger.