From: Borislav Petkov <bp@alien8.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Colin Ian King <colin.king@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode/amd: fix uninitalized structure cp
Date: Wed, 15 Jan 2020 12:42:52 +0000 [thread overview]
Message-ID: <20200115124252.GD20975@zn.tnic> (raw)
In-Reply-To: <20200115042507.GE3719@kadam>
On Wed, Jan 15, 2020 at 07:25:07AM +0300, Dan Carpenter wrote:
> It's probably complaining that cp.name[] isn't initialized.
That is possible.
> UBSan will probably generate a warning at runtime when we do:
>
> *ret = cp;
>
> But otherwise it's harmless.
Yes, because we don't do anything with cpio_data.name.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Colin Ian King <colin.king@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode/amd: fix uninitalized structure cp
Date: Wed, 15 Jan 2020 13:42:52 +0100 [thread overview]
Message-ID: <20200115124252.GD20975@zn.tnic> (raw)
In-Reply-To: <20200115042507.GE3719@kadam>
On Wed, Jan 15, 2020 at 07:25:07AM +0300, Dan Carpenter wrote:
> It's probably complaining that cp.name[] isn't initialized.
That is possible.
> UBSan will probably generate a warning at runtime when we do:
>
> *ret = cp;
>
> But otherwise it's harmless.
Yes, because we don't do anything with cpio_data.name.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-01-15 12:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 11:15 [PATCH] x86/microcode/amd: fix uninitalized structure cp Colin King
2020-01-14 11:38 ` Borislav Petkov
2020-01-14 11:38 ` Borislav Petkov
2020-01-14 11:51 ` Colin Ian King
2020-01-14 11:58 ` Thomas Gleixner
2020-01-14 11:58 ` Thomas Gleixner
2020-01-14 12:01 ` Borislav Petkov
2020-01-14 12:01 ` Borislav Petkov
2020-01-14 12:03 ` Colin Ian King
2020-01-14 12:10 ` Borislav Petkov
2020-01-14 12:10 ` Borislav Petkov
2020-01-14 14:08 ` Colin Ian King
2020-01-14 15:01 ` Borislav Petkov
2020-01-14 15:01 ` Borislav Petkov
2020-01-15 4:25 ` Dan Carpenter
2020-01-15 4:25 ` Dan Carpenter
2020-01-15 12:42 ` Borislav Petkov [this message]
2020-01-15 12:42 ` Borislav Petkov
2020-01-16 9:44 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115124252.GD20975@zn.tnic \
--to=bp@alien8.de \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.