Re: [PATCH 3/3] i2c: parport: move include file into main source

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]


> > +module_param(type, int, 0);
> > +MODULE_PARM_DESC(type,
> > +	"Type of adapter:\n"
> > +	" 0 = Philips adapter\n"
> > +	" 1 = home brew teletext adapter\n"
> > +	" 2 = Velleman K8000 adapter\n"
> > +	" 3 = ELV adapter\n"
> > +	" 4 = ADM1032 evaluation board\n"
> > +	" 5 = ADM1025, ADM1030 and ADM1031 evaluation boards\n"
> > +	" 6 = Barco LPT->DVI (K5800236) adapter\n"
> > +	" 7 = One For All JP1 parallel port adapter\n"
> > +	" 8 = VCT-jig\n"
> > +);
> 
> Isn't it considered a better practice to keep the module_param (and
> MODULE_PARM_DESC) close to the declaration of the variable itself so
> that correctness can be easily verified and changing the type later
> would be easier?

I tried it for both module parameters and it looks much better, in deed.
So, fixed it while applying, thanks for the suggestions!

Applied to for-next!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]