From: Lee Jones <lee.jones@linaro.org>
To: Prashant Malani <pmalani@chromium.org>
Cc: enric.balletbo@collabora.com, groeck@chromium.org,
bleung@chromium.org, sre@kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v6 2/3] mfd: cros_ec: Add cros-usbpd-notify subdevice
Date: Thu, 16 Jan 2020 13:33:47 +0000 [thread overview]
Message-ID: <20200116133347.GQ325@dell> (raw)
In-Reply-To: <20200114232219.93171-2-pmalani@chromium.org>
On Tue, 14 Jan 2020, Prashant Malani wrote:
> Add the cros-usbpd-notify driver as a subdevice on platforms that
> support the EC_FEATURE_USB_PD EC feature flag and don't have the
> ACPI PD notification device defined.
>
> This driver allows other cros-ec devices to receive PD event
> notifications from the Chrome OS Embedded Controller (EC) via a
> notification chain.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
>
> Changes in v6:
> - No changes.
Just replied to v5:
Looks good to me. Could we have some Chromium reviews please?
> Changes in v5:
> - Updated the IS_ENABLED() check to check for CONFIG_OF instead of
> !CONFIG_ACPI according to upstream comments.
>
> Changes in v4:
> - Removed #ifndef usage; instead, moved cros-usbpd-notify to a separate
> mfd_cell and used an IS_ENABLED() check.
> - Changed commit title and description slightly to reflect change in
> code.
> drivers/mfd/cros_ec_dev.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-01-16 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 23:22 [PATCH v6 1/3] platform: chrome: Add cros-usbpd-notify driver Prashant Malani
2020-01-14 23:22 ` [PATCH v6 2/3] mfd: cros_ec: Add cros-usbpd-notify subdevice Prashant Malani
2020-01-16 13:33 ` Lee Jones [this message]
2020-01-16 19:42 ` Benson Leung
2020-01-17 11:34 ` Lee Jones
2020-01-14 23:22 ` [PATCH v6 3/3] power: supply: cros-ec-usbpd-charger: Fix host events Prashant Malani
2020-01-16 19:45 ` Benson Leung
2020-01-16 22:09 ` Prashant Malani
2020-01-16 19:51 ` [PATCH v6 1/3] platform: chrome: Add cros-usbpd-notify driver Benson Leung
2020-01-16 22:06 ` Prashant Malani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116133347.GQ325@dell \
--to=lee.jones@linaro.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.