From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D38B2C33CB3 for ; Thu, 16 Jan 2020 17:19:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A727E22522 for ; Thu, 16 Jan 2020 17:19:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iMpomwRv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389055AbgAPRTA (ORCPT ); Thu, 16 Jan 2020 12:19:00 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:39071 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391518AbgAPRSi (ORCPT ); Thu, 16 Jan 2020 12:18:38 -0500 Received: by mail-wm1-f65.google.com with SMTP id 20so4642032wmj.4 for ; Thu, 16 Jan 2020 09:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Van5iMUPt75Dhp2RA0mDMd4+WxnU2QI6ZEJAQ+mejQs=; b=iMpomwRv1n5m6cC/trOhTKhG0pWracgFeD6R+Xo3/4Ocb5RJOh7SK1LHxmH98TpaQu uNN3uyYZGaUeqEEbqkKex9LUjf/5sUHp2YpBaQ8ud+byMq+696VVVt7/5n9yWjbaJAiM TeI0KrcW/7OUwTxUBYaKPI1vBrA8Pk8UgutPXznm0VjKzXpYCzD2ocwHRdlX0xumYVNF AnntV8WcQyVuexGRFUPGg5PjHPjnvniSCcc6XGF5t2avoN8FDY2Ayqf56wcs8BsFZdOz THFw8SAy0Z66lgQiNC/vHgvdxeMxwBwzdRLmdR0luKsGw3oSsBjUE2MpQ7trCSQmcHl0 ksrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Van5iMUPt75Dhp2RA0mDMd4+WxnU2QI6ZEJAQ+mejQs=; b=FrswTNOfEkkHXnb5VpIGwnR7TofP//aB6aTXhExNksr1MWKWtvRkl9cYSjNV8ICRRH cFKuXs2WXnbqerwUuMJSawRrwoduTQwyGm92mOzo61npdzRv3o+KRaUki3yYFtVbRWE7 d7au9ia7b5K2EF9yxRJGAN224F54kqmtmB1aSzXF9EFEF4M3mnC2/ojA7MqikDXd9ih4 +m4H8w6ibrFhW8hnSSu6U6JazAtmn5KL/QMXF4OdZbN12SXPRl0JJRGr5AEh+QcHCYZt ZZnO6U3RPrFp3+VLDZ4p7U/VToRjw9dNS3FrcNwQQgTGhlNRX8X7mWPUpjpPGnkHaZqI yqwQ== X-Gm-Message-State: APjAAAW05gGmA8rGpdcfqBoa8xyOJTeCFCTnWJhIn7mm4m8jGfHSRlsJ B9TRoKZCyPY24kiThHAzUWg= X-Google-Smtp-Source: APXvYqxGbFzg1+E3KjvOSAkunWkYSJziwphagJqZy6A+i3OVyXyZ86rgeQsBMNhijAYyIONrTl1/CA== X-Received: by 2002:a1c:2504:: with SMTP id l4mr99959wml.134.1579195116155; Thu, 16 Jan 2020 09:18:36 -0800 (PST) Received: from localhost.localdomain ([188.25.254.226]) by smtp.gmail.com with ESMTPSA id q3sm31279962wrn.33.2020.01.16.09.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 09:18:35 -0800 (PST) From: Vladimir Oltean To: davem@davemloft.net Cc: netdev@vger.kernel.org, claudiu.manoil@nxp.com, po.liu@nxp.com, Vladimir Oltean Subject: [PATCH net-next] enetc: Don't print from enetc_sched_speed_set when link goes down Date: Thu, 16 Jan 2020 19:18:28 +0200 Message-Id: <20200116171828.2016-1-olteanv@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladimir Oltean It is not an error to unplug a cable from the ENETC port even with TSN offloads, so don't spam the log with link-related messages from the tc-taprio offload subsystem, a single notification is sufficient: [10972.351859] fsl_enetc 0000:00:00.0 eno0: Qbv PSPEED set speed link down. [10972.360241] fsl_enetc 0000:00:00.0 eno0: Link is Down Fixes: 2e47cb415f0a ("enetc: update TSN Qbv PSPEED set according to adjust link speed") Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/freescale/enetc/enetc_qos.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c index 00382b7c5bd8..0c6bf3a55a9a 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c @@ -36,7 +36,6 @@ void enetc_sched_speed_set(struct net_device *ndev) case SPEED_10: default: pspeed = ENETC_PMR_PSPEED_10M; - netdev_err(ndev, "Qbv PSPEED set speed link down.\n"); } priv->speed = speed; -- 2.17.1