From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D4EC33CB3 for ; Thu, 16 Jan 2020 17:44:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AAA724763 for ; Thu, 16 Jan 2020 17:44:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="AZV+Eqb0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AAA724763 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1is9Bh-0002Kr-RR; Thu, 16 Jan 2020 17:44:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1is9Bg-0002Km-W2 for xen-devel@lists.xenproject.org; Thu, 16 Jan 2020 17:44:09 +0000 X-Inumbo-ID: cb649a8f-3887-11ea-8794-12813bfff9fa Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cb649a8f-3887-11ea-8794-12813bfff9fa; Thu, 16 Jan 2020 17:44:08 +0000 (UTC) Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F4E42474C; Thu, 16 Jan 2020 17:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196648; bh=RA0gC3u+M4VuPADWnkOULAiiEkP0hcTg7uSzVZvtwbA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AZV+Eqb0bmlM6fnx3v/Ua9ASgRQK+paOmBnmuBZ9n71ix5myYSKhJ4/xgLuOum57o TQXXH7luXwMZ0tRvlnWlQnXlW9DirT+TL0TiUz/9t0vHl5oTq2e7vSYSddkvctW2+F eJjcHWuCaScZ9E9JyaHOvMTGlVKUBTNflPm3vv1E= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Thu, 16 Jan 2020 12:40:54 -0500 Message-Id: <20200116174251.24326-57-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116174251.24326-1-sashal@kernel.org> References: <20200116174251.24326-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Subject: [Xen-devel] [PATCH AUTOSEL 4.4 057/174] xen, cpu_hotplug: Prevent an out of bounds access X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Sasha Levin , Dan Carpenter , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" RnJvbTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgoKWyBVcHN0cmVh bSBjb21taXQgMjAxNjc2MDk1ZGRhN2U1YjMxYTVlMWQxMTZkMTBmYzIyOTg1MDc1ZSBdCgpUaGUg ImNwdSIgdmFyaWFibGUgY29tZXMgZnJvbSB0aGUgc3NjYW5mKCkgc28gU21hdGNoIG1hcmtzIGl0 IGFzCnVudHJ1c3RlZCBkYXRhLiAgV2UgY2FuJ3QgcGFzcyBhIGhpZ2hlciB2YWx1ZSB0aGFuICJu cl9jcHVfaWRzIiB0bwpjcHVfcG9zc2libGUoKSBvciBpdCByZXN1bHRzIGluIGFuIG91dCBvZiBi b3VuZHMgYWNjZXNzLgoKRml4ZXM6IGQ2OGQ4MmFmZDRjOCAoInhlbjogaW1wbGVtZW50IENQVSBo b3RwbHVnZ2luZyIpClNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJA b3JhY2xlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4K U2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPgpTaWduZWQtb2Zm LWJ5OiBTYXNoYSBMZXZpbiA8c2FzaGFsQGtlcm5lbC5vcmc+Ci0tLQogZHJpdmVycy94ZW4vY3B1 X2hvdHBsdWcuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxl dGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL2NwdV9ob3RwbHVnLmMgYi9kcml2ZXJz L3hlbi9jcHVfaG90cGx1Zy5jCmluZGV4IGY0ZTU5YzQ0NTk2NC4uMTcwNTRkNjk1NDExIDEwMDY0 NAotLS0gYS9kcml2ZXJzL3hlbi9jcHVfaG90cGx1Zy5jCisrKyBiL2RyaXZlcnMveGVuL2NwdV9o b3RwbHVnLmMKQEAgLTUzLDcgKzUzLDcgQEAgc3RhdGljIGludCB2Y3B1X29ubGluZSh1bnNpZ25l ZCBpbnQgY3B1KQogfQogc3RhdGljIHZvaWQgdmNwdV9ob3RwbHVnKHVuc2lnbmVkIGludCBjcHUp CiB7Ci0JaWYgKCFjcHVfcG9zc2libGUoY3B1KSkKKwlpZiAoY3B1ID49IG5yX2NwdV9pZHMgfHwg IWNwdV9wb3NzaWJsZShjcHUpKQogCQlyZXR1cm47CiAKIAlzd2l0Y2ggKHZjcHVfb25saW5lKGNw dSkpIHsKLS0gCjIuMjAuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4t ZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33506C33CAF for ; Thu, 16 Jan 2020 17:56:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 048D12077B for ; Thu, 16 Jan 2020 17:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579197365; bh=RA0gC3u+M4VuPADWnkOULAiiEkP0hcTg7uSzVZvtwbA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=t/OA/Y0znq0j68AfTkwjYJ+q3KNNxd8SVP+CM1zHR3UmrG5d94D0xltJTkS3PP8Yb YvLLRLJ7EpD//XVeJmioe+8hlC0Rg+a0mQ4/87AqYdOmRfoVArngA96ztCb74UBpLE rOik0lFab2m82xYPapO3EclWvWRpCfqG7z9Pyl40= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394508AbgAPR4D (ORCPT ); Thu, 16 Jan 2020 12:56:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:34848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394068AbgAPRoI (ORCPT ); Thu, 16 Jan 2020 12:44:08 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F4E42474C; Thu, 16 Jan 2020 17:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196648; bh=RA0gC3u+M4VuPADWnkOULAiiEkP0hcTg7uSzVZvtwbA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AZV+Eqb0bmlM6fnx3v/Ua9ASgRQK+paOmBnmuBZ9n71ix5myYSKhJ4/xgLuOum57o TQXXH7luXwMZ0tRvlnWlQnXlW9DirT+TL0TiUz/9t0vHl5oTq2e7vSYSddkvctW2+F eJjcHWuCaScZ9E9JyaHOvMTGlVKUBTNflPm3vv1E= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Juergen Gross , Sasha Levin , xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 4.4 057/174] xen, cpu_hotplug: Prevent an out of bounds access Date: Thu, 16 Jan 2020 12:40:54 -0500 Message-Id: <20200116174251.24326-57-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116174251.24326-1-sashal@kernel.org> References: <20200116174251.24326-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 201676095dda7e5b31a5e1d116d10fc22985075e ] The "cpu" variable comes from the sscanf() so Smatch marks it as untrusted data. We can't pass a higher value than "nr_cpu_ids" to cpu_possible() or it results in an out of bounds access. Fixes: d68d82afd4c8 ("xen: implement CPU hotplugging") Signed-off-by: Dan Carpenter Reviewed-by: Juergen Gross Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/cpu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c index f4e59c445964..17054d695411 100644 --- a/drivers/xen/cpu_hotplug.c +++ b/drivers/xen/cpu_hotplug.c @@ -53,7 +53,7 @@ static int vcpu_online(unsigned int cpu) } static void vcpu_hotplug(unsigned int cpu) { - if (!cpu_possible(cpu)) + if (cpu >= nr_cpu_ids || !cpu_possible(cpu)) return; switch (vcpu_online(cpu)) { -- 2.20.1