From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Barani Muthukumaran <bmuthuku@codeaurora.org>,
Gaurav Kashyap <gaurkash@codeaurora.org>,
linux-api@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] fscrypt: reserve flags for hardware-wrapped keys feature
Date: Fri, 17 Jan 2020 11:40:54 -0500 [thread overview]
Message-ID: <20200117164054.GD448999@mit.edu> (raw)
In-Reply-To: <20200117081246.GA16846@infradead.org>
On Fri, Jan 17, 2020 at 12:12:46AM -0800, Christoph Hellwig wrote:
> On Thu, Jan 16, 2020 at 11:20:08AM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Reserve flags for the hardware-wrapped keys feature which is being
> > worked on [1]. FSCRYPT_POLICY_FLAG_HW_WRAPPED_KEY will denote that the
> > encryption policy needs a hardware-wrapped key to be unlocked.
> > FSCRYPT_ADD_KEY_FLAG_HW_WRAPPED will denote that the key being added is
> > a hardware-wrapped key.
> >
> > This reservation is tentative, and these codepoints may be reused if the
> > feature is not upstreamed.
>
> NAK. While the feature itself sounds really useful we don't just
> reserve format bits for code not upstream.
I disagree; saving a codepoint to avoid accidental collision of a
feature bit is a good and proper thing to do.
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
- Ted
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-mtd@lists.infradead.org,
Barani Muthukumaran <bmuthuku@codeaurora.org>,
Gaurav Kashyap <gaurkash@codeaurora.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-api@vger.kernel.org
Subject: Re: [PATCH] fscrypt: reserve flags for hardware-wrapped keys feature
Date: Fri, 17 Jan 2020 11:40:54 -0500 [thread overview]
Message-ID: <20200117164054.GD448999@mit.edu> (raw)
In-Reply-To: <20200117081246.GA16846@infradead.org>
On Fri, Jan 17, 2020 at 12:12:46AM -0800, Christoph Hellwig wrote:
> On Thu, Jan 16, 2020 at 11:20:08AM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Reserve flags for the hardware-wrapped keys feature which is being
> > worked on [1]. FSCRYPT_POLICY_FLAG_HW_WRAPPED_KEY will denote that the
> > encryption policy needs a hardware-wrapped key to be unlocked.
> > FSCRYPT_ADD_KEY_FLAG_HW_WRAPPED will denote that the key being added is
> > a hardware-wrapped key.
> >
> > This reservation is tentative, and these codepoints may be reused if the
> > feature is not upstreamed.
>
> NAK. While the feature itself sounds really useful we don't just
> reserve format bits for code not upstream.
I disagree; saving a codepoint to avoid accidental collision of a
feature bit is a good and proper thing to do.
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Barani Muthukumaran <bmuthuku@codeaurora.org>,
Gaurav Kashyap <gaurkash@codeaurora.org>,
linux-api@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] fscrypt: reserve flags for hardware-wrapped keys feature
Date: Fri, 17 Jan 2020 11:40:54 -0500 [thread overview]
Message-ID: <20200117164054.GD448999@mit.edu> (raw)
In-Reply-To: <20200117081246.GA16846@infradead.org>
On Fri, Jan 17, 2020 at 12:12:46AM -0800, Christoph Hellwig wrote:
> On Thu, Jan 16, 2020 at 11:20:08AM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Reserve flags for the hardware-wrapped keys feature which is being
> > worked on [1]. FSCRYPT_POLICY_FLAG_HW_WRAPPED_KEY will denote that the
> > encryption policy needs a hardware-wrapped key to be unlocked.
> > FSCRYPT_ADD_KEY_FLAG_HW_WRAPPED will denote that the key being added is
> > a hardware-wrapped key.
> >
> > This reservation is tentative, and these codepoints may be reused if the
> > feature is not upstreamed.
>
> NAK. While the feature itself sounds really useful we don't just
> reserve format bits for code not upstream.
I disagree; saving a codepoint to avoid accidental collision of a
feature bit is a good and proper thing to do.
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
- Ted
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-01-17 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 19:20 [PATCH] fscrypt: reserve flags for hardware-wrapped keys feature Eric Biggers
2020-01-16 19:20 ` Eric Biggers
2020-01-16 19:20 ` [f2fs-dev] " Eric Biggers
[not found] ` <20200116192008.35766-1-ebiggers-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-17 8:12 ` Christoph Hellwig
2020-01-17 8:12 ` Christoph Hellwig
2020-01-17 8:12 ` [f2fs-dev] " Christoph Hellwig
2020-01-17 8:12 ` Christoph Hellwig
2020-01-17 16:40 ` Theodore Y. Ts'o [this message]
2020-01-17 16:40 ` [f2fs-dev] " Theodore Y. Ts'o
2020-01-17 16:40 ` Theodore Y. Ts'o
2020-01-17 16:56 ` Greg KH
2020-01-17 16:56 ` Greg KH
2020-01-17 16:56 ` [f2fs-dev] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117164054.GD448999@mit.edu \
--to=tytso@mit.edu \
--cc=bmuthuku@codeaurora.org \
--cc=ebiggers@kernel.org \
--cc=gaurkash@codeaurora.org \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.