All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Fwd: [martineau:kbuild-mptcp 22/38] subflow.c:undefined reference to `__crypto_memneq'
Date: Sat, 18 Jan 2020 01:05:36 +0100	[thread overview]
Message-ID: <20200118000536.GY795@breakpoint.cc> (raw)

[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]

----- Forwarded message from kbuild test robot <lkp(a)intel.com> -----

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/martineau/linux.git kbuild-mptcp
head:   c4ccdd8177fb3d8123dd294ae93ee2dac1f43f32
commit: ccd5b6ef8fd4b37a7721231a55482523b07d7ef9 [22/38] mptcp: Add handling of incoming MP_JOIN requests
config: xtensa-common_defconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout ccd5b6ef8fd4b37a7721231a55482523b07d7ef9
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>

All errors (new ones prefixed by >>):

   net/mptcp/subflow.o: In function `subflow_ulp_release':
>> subflow.c:(.text+0x41c): undefined reference to `__crypto_memneq'
   net/mptcp/subflow.o: In function `subflow_syn_recv_sock':
   subflow.c:(.text+0x53a): undefined reference to `__crypto_memneq'

Hmpf.  The .config has CONFIG_CRYPTO=n and then the symbol doesn't
exist.

So we have two choices:
- select CRYPTO from Kconfig
- use plain memcmp as before (might reveal info about key though)
- copypaste a similar function into mptcp.

What do you think?

                 reply	other threads:[~2020-01-18  0:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200118000536.GY795@breakpoint.cc \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.