Re: [dpdk-dev] [PATCH v4] doc: introduce openwrt how-to guide

[Ye Xiaolong <xiaolong.ye@intel.com>]

Hi, John

Thanks for your review.

On 01/17, Mcnamara, John wrote:
>Hi,
>
>Overall looks good. Some notes below:
>
>> +
>> +.. note::
>> +
>> +For compiling the NUMA lib, run libtool --version to ensure the
>> +libtool version >= 2.2, otherwise the compilation will fail with errors.
>
>
>This continuation line isn't indented and raised a build error:
>
>    $ make doc-guides-html
>    sphinx processing guides-html...
>    /work/dpdk_docs/doc/guides/howto/openwrt.rst:80: WARNING:
>    Explicit markup ends without a blank line; unexpected unindent.
>
>Also you should used spaces not tabs for indentation in the docs.

Got it.

>
>> +If you are using Windows PC, you can use some free and opensource raw
>> +disk image writer program such as
>> +``Win32 Disk Imager`` and ``Etcher`` to write OpenWrt image
>> +(openwrt-x86-64-combined-ext4.img) to a USB flash driver or USB SDcard
>> with SDcard or a Sata hard drivre or SSD from your PC.
>
>Typo: drive
>
>I'll send you a few other suggested minor corrections.

I'll send a new version after I correct all the suggestions.

Thanks,
Xiaolong

>
>John
>