From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE03C32771 for ; Sat, 18 Jan 2020 04:07:43 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35AEA2192A for ; Sat, 18 Jan 2020 04:07:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="he/HqRKh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35AEA2192A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0C42B86A29; Sat, 18 Jan 2020 04:07:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JfvP2X_eJoL1; Sat, 18 Jan 2020 04:07:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id A27DC86A14; Sat, 18 Jan 2020 04:07:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 96AA5C1D81; Sat, 18 Jan 2020 04:07:42 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id F38BFC077D for ; Sat, 18 Jan 2020 04:07:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id EF896221B2 for ; Sat, 18 Jan 2020 04:07:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h9Eda2t90Pdd for ; Sat, 18 Jan 2020 04:07:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by silver.osuosl.org (Postfix) with ESMTPS id B469A20410 for ; Sat, 18 Jan 2020 04:07:39 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id n96so4047446pjc.3 for ; Fri, 17 Jan 2020 20:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PIRa3Me1MuVP3scCn41TBw4mEuh3lRWcGYrwRLyuooo=; b=he/HqRKhdajTtzeAyutff/zMg8NhVoykxV8x8Lct0t2F+5QE+FJpEcsML/xjMv9DhO d21j+fpDGqrbXw7sgfg6XBrVGM6pQXGxJYD69E/6oWwKB7VW+++zgPYaSn6XywzMLSic VrvW06fTfC36SWN63zIYrFvMYdjpmV/s0tNervXM7wL3DGp12Jm6dMqd4bVx05KuYPdH Gd9EbcwrRuP4JMT2O4ovdHD0R/moQ3zufVkLenWPKEFpBhvmVvhkMShTlNKhDwbit67H esBV168gY1H3UlDETGjx4uJ9oVKusU7pZha/xjH/cr/GBjdEE+U64cDt/Q8XyCV5tT5T FDUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PIRa3Me1MuVP3scCn41TBw4mEuh3lRWcGYrwRLyuooo=; b=gwSqDMGBhoMEvza/mFF6QFGKz+Fm4vDzGWaRcsI86R8FUZ5GHH4XvSEZ6lgYyrXGsd OEnDMDKlgcnDCWrX61L6x1QgdGDLJQ/O1gBYAnX8f5nHzCtSwdBFxaw8aIBUBn2AsPpv liFptRGzy1G//mRJbqUeUa32/VOZ0YSMq3s9bAhqEutLQJf+02TalgBEqdNbZk2T2/pB tkRT7RhJ6E/FOy4BuZNpW8M+52JFs7HcFKDpfCvVbVN5nkKKSp6wHARo5yHqPv6RT0UW PY6tdJh0YaM2lfMeQu8uzAhx8cd0KbPqpedFVhUUcBuSjYWDmdonCpiYiLLxdZqaRojA OMDQ== X-Gm-Message-State: APjAAAXPh4P4ZaIJJTj0kUfExv76xDOWbGrhQ1t9BorYdzfFyqkJeivx QpcD4/9tpcqhn10KJcp6nus= X-Google-Smtp-Source: APXvYqzn4rsu/9mzBMbb1i9gkk/w2Y1AZ9IYMLGgk0U3+gBrOS0TVCTIxhXEQRQCTFVx+2cV2J+Y+g== X-Received: by 2002:a17:902:b212:: with SMTP id t18mr2853630plr.135.1579320459261; Fri, 17 Jan 2020 20:07:39 -0800 (PST) Received: from workstation-portable ([146.196.37.181]) by smtp.gmail.com with ESMTPSA id c18sm30565333pfr.40.2020.01.17.20.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 20:07:38 -0800 (PST) Date: Sat, 18 Jan 2020 09:37:30 +0530 From: Amol Grover To: Olof Johansson Message-ID: <20200118040730.GA6783@workstation-portable> References: <20200117133048.31708-1-frextrite@gmail.com> <5d77df7f-8693-0232-dbfe-0acfc37e040f@oracle.com> <20200117192555.baoxu4xd7krxgfjz@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200117192555.baoxu4xd7krxgfjz@localhost> User-Agent: Mutt/1.12.2 (2019-09-21) Cc: "Paul E . McKenney" , santosh.shilimkar@oracle.com, linux-kernel@vger.kernel.org, arm-soc , Santosh Shilimkar , Joel Fernandes , linux-kernel-mentees@lists.linuxfoundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: [Linux-kernel-mentees] [PATCH v2] drivers: soc: ti: knav_qmss_queue: Pass lockdep expression to RCU lists X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Fri, Jan 17, 2020 at 11:25:55AM -0800, Olof Johansson wrote: > On Fri, Jan 17, 2020 at 10:24:04AM -0800, santosh.shilimkar@oracle.com wrote: > > On 1/17/20 5:30 AM, Amol Grover wrote: > > > inst->handles is traversed using list_for_each_entry_rcu > > > outside an RCU read-side critical section but under the protection > > > of knav_dev_lock. > > > > > > Hence, add corresponding lockdep expression to silence false-positive > > > lockdep warnings, and harden RCU lists. > > > > > > Add macro for the corresponding lockdep expression. > > > > > > Signed-off-by: Amol Grover > > > --- > > > v2: > > > - Remove rcu_read_lock_held() from lockdep expression since it is > > > implicitly checked for. > > > > > Looks fine to me. > > > > Hi Olof, Arnd, > > Can you please pick this one and apply to your driver-soc branch ? > > I already sent out pull request and hence the request. > > Hi, > > Can you please email the whole patch with sign-off to > soc@kernel.org? Otherwise it won't end up in patchwork, which is how we track > patches and pull requests these days. > Thank you Santosh and Olof. I'm resending the patch to soc@kernel.org as well. Thanks Amol > > Thanks, > > -Olof _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFFCC32771 for ; Sat, 18 Jan 2020 04:07:55 +0000 (UTC) Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 241F52192A for ; Sat, 18 Jan 2020 04:07:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BTVIbDZv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="he/HqRKh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 241F52192A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lhWAnLh9WkyYf5CLGVG9UGGzIVEJ5CsdoSv/uQaKVPs=; b=BTVIbDZvPv474L cs+iBWK01dGqWrFB21+/n7/4rdvRMHxyLHzc4o8h32hPl83KkmkG6lJXcbE1SiyuZD8mEQnrNI86b FHxiUIa/tNbuTHCd4zf6bMfxhrl5EQew0rHV3wyY24rQy5VrowKbzWPomS4H6Ejyz0Pn40mzuoxXc 1/WMQ1eZGcgzB6L0G21PAPGPDgVXWFi62Tk9lyXO5Wj2WerQPa8k8rPbvIlqs8dPD6udqOeCwDDZG kLHihO13opGNANahPNg5dC+PvmdZSLwFjZae0hpwXOuGnJ0RIv+AwBStxyXM0jt/hhN/Fovc7I9d9 ZHkvuca3gUFN/fSaDlfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1isfOk-0006oR-3G; Sat, 18 Jan 2020 04:07:46 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1isfOf-0006o0-St for linux-arm-kernel@lists.infradead.org; Sat, 18 Jan 2020 04:07:44 +0000 Received: by mail-pj1-x1044.google.com with SMTP id a6so4052114pjh.2 for ; Fri, 17 Jan 2020 20:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PIRa3Me1MuVP3scCn41TBw4mEuh3lRWcGYrwRLyuooo=; b=he/HqRKhdajTtzeAyutff/zMg8NhVoykxV8x8Lct0t2F+5QE+FJpEcsML/xjMv9DhO d21j+fpDGqrbXw7sgfg6XBrVGM6pQXGxJYD69E/6oWwKB7VW+++zgPYaSn6XywzMLSic VrvW06fTfC36SWN63zIYrFvMYdjpmV/s0tNervXM7wL3DGp12Jm6dMqd4bVx05KuYPdH Gd9EbcwrRuP4JMT2O4ovdHD0R/moQ3zufVkLenWPKEFpBhvmVvhkMShTlNKhDwbit67H esBV168gY1H3UlDETGjx4uJ9oVKusU7pZha/xjH/cr/GBjdEE+U64cDt/Q8XyCV5tT5T FDUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PIRa3Me1MuVP3scCn41TBw4mEuh3lRWcGYrwRLyuooo=; b=FbxM+zROlBjs9azfV5D7f3Bl71Cbb2qUWxBABhXkwaCV12TmtyVgEjr1our2ABuQbe eM+gOaL/CcL7Lfe1+UuJUxsHdmEGEQpzxK2nER1GWVQU15Ivd/Y6GfFLpoaKu3kDgNmE +IOna3a2F5aY+1hNFdLK4JO6UcpEa0+kfba0ZMgwrwoCeYnKhSzI+C9neiDqwbOK3VHe D3DpfFuMYMIf7r9dkW5l5CNX+mijg2aOkW5a92xSVC8l+VT9HhQYZq/aFk9E0w/maVc4 kx84LwNAip1O8vICAD90YHaimSIDvddiJHGLtqryqFr/1F06+dZeLlpC9onUzUNipoQn 4Z+g== X-Gm-Message-State: APjAAAWYfJorNKjxneHpzH4iPs1OW5a2ZOQIURoNxaGihmLoPLIl4xPx AuxGz8v2vBSwTWRtCXVYNOqeig/o X-Google-Smtp-Source: APXvYqzn4rsu/9mzBMbb1i9gkk/w2Y1AZ9IYMLGgk0U3+gBrOS0TVCTIxhXEQRQCTFVx+2cV2J+Y+g== X-Received: by 2002:a17:902:b212:: with SMTP id t18mr2853630plr.135.1579320459261; Fri, 17 Jan 2020 20:07:39 -0800 (PST) Received: from workstation-portable ([146.196.37.181]) by smtp.gmail.com with ESMTPSA id c18sm30565333pfr.40.2020.01.17.20.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 20:07:38 -0800 (PST) Date: Sat, 18 Jan 2020 09:37:30 +0530 From: Amol Grover To: Olof Johansson Subject: Re: [PATCH v2] drivers: soc: ti: knav_qmss_queue: Pass lockdep expression to RCU lists Message-ID: <20200118040730.GA6783@workstation-portable> References: <20200117133048.31708-1-frextrite@gmail.com> <5d77df7f-8693-0232-dbfe-0acfc37e040f@oracle.com> <20200117192555.baoxu4xd7krxgfjz@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200117192555.baoxu4xd7krxgfjz@localhost> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200117_200741_962205_C753AEA2 X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Paul E . McKenney" , santosh.shilimkar@oracle.com, linux-kernel@vger.kernel.org, arm-soc , Madhuparna Bhowmik , Santosh Shilimkar , Joel Fernandes , linux-kernel-mentees@lists.linuxfoundation.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 17, 2020 at 11:25:55AM -0800, Olof Johansson wrote: > On Fri, Jan 17, 2020 at 10:24:04AM -0800, santosh.shilimkar@oracle.com wrote: > > On 1/17/20 5:30 AM, Amol Grover wrote: > > > inst->handles is traversed using list_for_each_entry_rcu > > > outside an RCU read-side critical section but under the protection > > > of knav_dev_lock. > > > > > > Hence, add corresponding lockdep expression to silence false-positive > > > lockdep warnings, and harden RCU lists. > > > > > > Add macro for the corresponding lockdep expression. > > > > > > Signed-off-by: Amol Grover > > > --- > > > v2: > > > - Remove rcu_read_lock_held() from lockdep expression since it is > > > implicitly checked for. > > > > > Looks fine to me. > > > > Hi Olof, Arnd, > > Can you please pick this one and apply to your driver-soc branch ? > > I already sent out pull request and hence the request. > > Hi, > > Can you please email the whole patch with sign-off to > soc@kernel.org? Otherwise it won't end up in patchwork, which is how we track > patches and pull requests these days. > Thank you Santosh and Olof. I'm resending the patch to soc@kernel.org as well. Thanks Amol > > Thanks, > > -Olof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F27C32771 for ; Sat, 18 Jan 2020 04:07:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E37F2192A for ; Sat, 18 Jan 2020 04:07:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="he/HqRKh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727033AbgAREHk (ORCPT ); Fri, 17 Jan 2020 23:07:40 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:55236 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726566AbgAREHk (ORCPT ); Fri, 17 Jan 2020 23:07:40 -0500 Received: by mail-pj1-f65.google.com with SMTP id kx11so4047155pjb.4 for ; Fri, 17 Jan 2020 20:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PIRa3Me1MuVP3scCn41TBw4mEuh3lRWcGYrwRLyuooo=; b=he/HqRKhdajTtzeAyutff/zMg8NhVoykxV8x8Lct0t2F+5QE+FJpEcsML/xjMv9DhO d21j+fpDGqrbXw7sgfg6XBrVGM6pQXGxJYD69E/6oWwKB7VW+++zgPYaSn6XywzMLSic VrvW06fTfC36SWN63zIYrFvMYdjpmV/s0tNervXM7wL3DGp12Jm6dMqd4bVx05KuYPdH Gd9EbcwrRuP4JMT2O4ovdHD0R/moQ3zufVkLenWPKEFpBhvmVvhkMShTlNKhDwbit67H esBV168gY1H3UlDETGjx4uJ9oVKusU7pZha/xjH/cr/GBjdEE+U64cDt/Q8XyCV5tT5T FDUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PIRa3Me1MuVP3scCn41TBw4mEuh3lRWcGYrwRLyuooo=; b=e4IxjhRy0syf2au0NAmaZlA0e+5M6DGFt9uKK+H8KWptXSmLEiyLtpQ0x/9k+IFLbO 9TH8L7abJpAHnj1yKfiTeHYb/7E4ZFlyOaTu1uDLxmv/fUdxe+AwTSGuaLGymAigbzo9 EDroO1qdk5MpPTG9TUnlYhYOoSesTHvSAaLNdBP/HpKeMXhJ8Ikb/m0j9Vf7KCviJ3+t eEiUR7Tbwd3MwXoIKdhwTq3DPgM+4Nda8n/0SPAx5zD9krV8Mq0Ejz2/wDJiVQ+PdQVz 5H+quuUi4Pc4Zu1LViLUbFqYkA1XyvybwHKn2ZWvcXYwpPTu1bt6RhkRojVF+lhzyOcg p8Ew== X-Gm-Message-State: APjAAAUkZVl0aN0HnrydQDtoEZo3YFImaIYF14Zg2gTTM1VS7xWlVCZo p7p8rcLWUDMp+2t8yrHnwu8= X-Google-Smtp-Source: APXvYqzn4rsu/9mzBMbb1i9gkk/w2Y1AZ9IYMLGgk0U3+gBrOS0TVCTIxhXEQRQCTFVx+2cV2J+Y+g== X-Received: by 2002:a17:902:b212:: with SMTP id t18mr2853630plr.135.1579320459261; Fri, 17 Jan 2020 20:07:39 -0800 (PST) Received: from workstation-portable ([146.196.37.181]) by smtp.gmail.com with ESMTPSA id c18sm30565333pfr.40.2020.01.17.20.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 20:07:38 -0800 (PST) Date: Sat, 18 Jan 2020 09:37:30 +0530 From: Amol Grover To: Olof Johansson Cc: santosh.shilimkar@oracle.com, arm-soc , Santosh Shilimkar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel-mentees@lists.linuxfoundation.org, Joel Fernandes , Madhuparna Bhowmik , "Paul E . McKenney" Subject: Re: [PATCH v2] drivers: soc: ti: knav_qmss_queue: Pass lockdep expression to RCU lists Message-ID: <20200118040730.GA6783@workstation-portable> References: <20200117133048.31708-1-frextrite@gmail.com> <5d77df7f-8693-0232-dbfe-0acfc37e040f@oracle.com> <20200117192555.baoxu4xd7krxgfjz@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200117192555.baoxu4xd7krxgfjz@localhost> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 17, 2020 at 11:25:55AM -0800, Olof Johansson wrote: > On Fri, Jan 17, 2020 at 10:24:04AM -0800, santosh.shilimkar@oracle.com wrote: > > On 1/17/20 5:30 AM, Amol Grover wrote: > > > inst->handles is traversed using list_for_each_entry_rcu > > > outside an RCU read-side critical section but under the protection > > > of knav_dev_lock. > > > > > > Hence, add corresponding lockdep expression to silence false-positive > > > lockdep warnings, and harden RCU lists. > > > > > > Add macro for the corresponding lockdep expression. > > > > > > Signed-off-by: Amol Grover > > > --- > > > v2: > > > - Remove rcu_read_lock_held() from lockdep expression since it is > > > implicitly checked for. > > > > > Looks fine to me. > > > > Hi Olof, Arnd, > > Can you please pick this one and apply to your driver-soc branch ? > > I already sent out pull request and hence the request. > > Hi, > > Can you please email the whole patch with sign-off to > soc@kernel.org? Otherwise it won't end up in patchwork, which is how we track > patches and pull requests these days. > Thank you Santosh and Olof. I'm resending the patch to soc@kernel.org as well. Thanks Amol > > Thanks, > > -Olof