From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE99C33CB6 for ; Sat, 18 Jan 2020 05:27:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0885C24686 for ; Sat, 18 Jan 2020 05:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579325249; bh=Su46dTvr6LjbK97+KpEmyjmd9MCvkLqGMyfTWsk56iA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=L9jkD8ZvgMgmmd2wXvaHM/aeP40GIw62qXF5Y9fFlhp5SEB+xLfDdEFl/6EY0im9S ljVypHqxBKQKR0Wjrk+EyO4iUKiG9lb72m3waybQT7N2jJdnK2GC8Ng69UtcX2DUdk 9eYxsvLn38ETslCU+ousCmBm432ocriXcUm/zihs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725536AbgARF11 (ORCPT ); Sat, 18 Jan 2020 00:27:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:45494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbgARF11 (ORCPT ); Sat, 18 Jan 2020 00:27:27 -0500 Received: from sol.localdomain (unknown [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BAD820748; Sat, 18 Jan 2020 05:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579325246; bh=Su46dTvr6LjbK97+KpEmyjmd9MCvkLqGMyfTWsk56iA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MFIjHfQvc0kv0Ya/20xHIdfC6o2bof5u5eJqd9/VwJTPA9YcLj8x1k0vYihsxVLtW t1a4NJrrFEzd69isqDax6lXJWaafYGXjS953uoZ94rGPWCAsJxRPKpvc74B6onf6sr FOJFhvTtB6DdCiGovue/tD35DIjmdgbzT+VmQa00= Date: Fri, 17 Jan 2020 21:27:20 -0800 From: Eric Biggers To: Christoph Hellwig Cc: Satya Tangirala , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Barani Muthukumaran , Kuohong Wang , Kim Boojin Subject: Re: [PATCH v6 6/9] scsi: ufs: Add inline encryption support to UFS Message-ID: <20200118052720.GD3290@sol.localdomain> References: <20191218145136.172774-1-satyat@google.com> <20191218145136.172774-7-satyat@google.com> <20200117135808.GB5670@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200117135808.GB5670@infradead.org> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Jan 17, 2020 at 05:58:08AM -0800, Christoph Hellwig wrote: > On Wed, Dec 18, 2019 at 06:51:33AM -0800, Satya Tangirala wrote: > > Wire up ufshcd.c with the UFS Crypto API, the block layer inline > > encryption additions and the keyslot manager. > > I think this patch should be merged into the previous patch, as the > previous one isn't useful without wiring it up. > Satya actually did this originally but then one of the UFS maintainers requested the separate patches for (1) new registers, (2) ufshcd-crypto, and (3) ufshcd.c: https://lore.kernel.org/linux-block/SN6PR04MB49259F70346E2055C9E0F401FC310@SN6PR04MB4925.namprd04.prod.outlook.com/ So, he's not going to be able to make everyone happy :-) I personally would be fine with either way. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D7EDC33CB1 for ; Sat, 18 Jan 2020 05:27:36 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F062A20748; Sat, 18 Jan 2020 05:27:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="c/o7B/kf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="d0bCgd/h"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="MFIjHfQv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F062A20748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1isgdz-0007JX-K5; Sat, 18 Jan 2020 05:27:35 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1isgdy-0007JJ-C7 for linux-f2fs-devel@lists.sourceforge.net; Sat, 18 Jan 2020 05:27:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kgaaQQV/8TESFr/mGWbUKrA5yBGkNgIeIfCOJ3wZtoM=; b=c/o7B/kflyewwkwVvYU1sMbv0m s1bcxl7xed9uXee2Ha5hSo+wL7OWO8WPmJR3ULOf7jPeJ7J0sDrhT6bNpPgkwKX7KE0bKYenaPn+O xsdEfP/XzP8nogOnAbLGfBT/jmZg8hPlwOMZGMrujred0MnLVBHaqet+KCc1fzLTXEwY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kgaaQQV/8TESFr/mGWbUKrA5yBGkNgIeIfCOJ3wZtoM=; b=d0bCgd/hudZS5kGZQy628Ex/70 GvtvCX6irxUiHcA8dnhNJsyge4FYa76hHZrknruwxiaX+X+U5muL4Ux5kSk4cBdQB6hCOFakFF9Kr H+PugNKRGESj3ER4tPG/J75j2mgPD+qkmau27ZhoAxj4z48MU+EX8pZL4g7pmjO+xVbA=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1isgdx-008wKg-64 for linux-f2fs-devel@lists.sourceforge.net; Sat, 18 Jan 2020 05:27:34 +0000 Received: from sol.localdomain (unknown [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BAD820748; Sat, 18 Jan 2020 05:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579325246; bh=Su46dTvr6LjbK97+KpEmyjmd9MCvkLqGMyfTWsk56iA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MFIjHfQvc0kv0Ya/20xHIdfC6o2bof5u5eJqd9/VwJTPA9YcLj8x1k0vYihsxVLtW t1a4NJrrFEzd69isqDax6lXJWaafYGXjS953uoZ94rGPWCAsJxRPKpvc74B6onf6sr FOJFhvTtB6DdCiGovue/tD35DIjmdgbzT+VmQa00= Date: Fri, 17 Jan 2020 21:27:20 -0800 From: Eric Biggers To: Christoph Hellwig Message-ID: <20200118052720.GD3290@sol.localdomain> References: <20191218145136.172774-1-satyat@google.com> <20191218145136.172774-7-satyat@google.com> <20200117135808.GB5670@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200117135808.GB5670@infradead.org> X-Headers-End: 1isgdx-008wKg-64 Subject: Re: [f2fs-dev] [PATCH v6 6/9] scsi: ufs: Add inline encryption support to UFS X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, Kim Boojin , Kuohong Wang , Barani Muthukumaran , linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, Satya Tangirala Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Jan 17, 2020 at 05:58:08AM -0800, Christoph Hellwig wrote: > On Wed, Dec 18, 2019 at 06:51:33AM -0800, Satya Tangirala wrote: > > Wire up ufshcd.c with the UFS Crypto API, the block layer inline > > encryption additions and the keyslot manager. > > I think this patch should be merged into the previous patch, as the > previous one isn't useful without wiring it up. > Satya actually did this originally but then one of the UFS maintainers requested the separate patches for (1) new registers, (2) ufshcd-crypto, and (3) ufshcd.c: https://lore.kernel.org/linux-block/SN6PR04MB49259F70346E2055C9E0F401FC310@SN6PR04MB4925.namprd04.prod.outlook.com/ So, he's not going to be able to make everyone happy :-) I personally would be fine with either way. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel