From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4014EC33CB6 for ; Sat, 18 Jan 2020 13:18:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 163C22468D for ; Sat, 18 Jan 2020 13:18:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="ZwOTVUgj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Se8pfQuf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 163C22468D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 194026E07D; Sat, 18 Jan 2020 13:18:40 +0000 (UTC) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3724F6E07D for ; Sat, 18 Jan 2020 13:18:39 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9A6B221C08; Sat, 18 Jan 2020 08:18:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 18 Jan 2020 08:18:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=DRHAHJguT0zUvuL+HVAIgaDuT2H 2OklHFj7eOTL2buQ=; b=ZwOTVUgjw+v6z8Bwo66ELXgACYkpuH5IXBOnnR+EXIF MhVc9hgm/YTxCyyB6ax/p0J02hl7Pg5tAH+8co+df5iEtLSMLjD0fLdV4UaL2V5G GRIjLqJ5SlkjXrTtc0a0VGPAhfpPdr+xZVutRe7irHPnNSIwr5bz1LVK+NwgrtgJ bgEKT9bfu4m5TFWAc9KP8rPU0/jXpaypRyoUX/UyKOeINOucyhv73u+nP2kW3zLD VJrC2VUA3Fo8ny0jBaO5lwig3P86bQBV/MaPS60GhAE81CERkRsRv09J7XRuseys i1Zrsuxp1dxopbv3HrfCMvbXNsq2UzZSjAyXI/ZFL3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=DRHAHJ guT0zUvuL+HVAIgaDuT2H2OklHFj7eOTL2buQ=; b=Se8pfQufQYd6K+LP1Jmq3v DszalQzijDvVM0b4lB06ljsdV2kXyA8NCtj1Ts/vfKKzn4qE7bmNmBy3TXwLCMiU 45+Lzt+jjJhF9NZjDo1f8EDDvdf7G2A5GP+bwhhyc+dQZ7alSADiEqGlAmEQLcPO U8VwB0qhOElvK1++AzmXwPQirijmYCiL4BQg82cAUGITgvB50BR2/Fi4gPtZcba9 sgeLtP9APAalHE3QwbIPpHzO5f9Zspk1r8QXBHANLz69o3wSO06pRYFiccvMkg3Z 42BZXp9uz9Dd3UoTuxrKIaSkVlo0h7Isb8PDUpURuujrKsHX8ywBSh1lFqvqG76Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddtgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghgucfm jfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeefjedrjedurddugeefrdduje dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (170.143.71.37.rev.sfr.net [37.71.143.170]) by mail.messagingengine.com (Postfix) with ESMTPA id 080A430608AD; Sat, 18 Jan 2020 08:18:36 -0500 (EST) Date: Sat, 18 Jan 2020 14:18:35 +0100 From: Greg KH To: Dan Carpenter Subject: Re: [PATCH AUTOSEL 5.4 002/205] drm/panfrost: Add missing check for pfdev->regulator Message-ID: <20200118131835.GA4734@kroah.com> References: <20200116164300.6705-1-sashal@kernel.org> <20200116164300.6705-2-sashal@kernel.org> <20200117161226.GA8472@arm.com> <20200117165909.GA1949937@kroah.com> <20200118081845.GF19765@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200118081845.GF19765@kadam> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Steven Price , "stable@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Jan 18, 2020 at 11:18:45AM +0300, Dan Carpenter wrote: > On Fri, Jan 17, 2020 at 05:59:09PM +0100, Greg KH wrote: > > On Fri, Jan 17, 2020 at 04:12:27PM +0000, Steven Price wrote: > > > On Thu, Jan 16, 2020 at 04:39:37PM +0000, Sasha Levin wrote: > > > > From: Steven Price > > > > > > > > [ Upstream commit 52282163dfa651849e905886845bcf6850dd83c2 ] > > > > > > This commit is effectively already in 5.4. Confusingly there were two > > > versions of this upstream: > > > > > > 52282163dfa6 ("drm/panfrost: Add missing check for pfdev->regulator") > > > c90f30812a79 ("drm/panfrost: Add missing check for pfdev->regulator") > > > > > > It got merged both through a -fixes branch and through the normal merge > > > window. The two copies caused a bad merge in mainline and this was > > > effectively reverted in commit 603e398a3db2 ("drm/panfrost: Remove NULL > > > check for regulator"). > > > > > > c90f30812a79 is included in v5.4 so should already be in any v5.4.y > > > release. > > > > Have I mentioned this month just how much I hate the way the DRM tree > > handles stable patches like this? This kind of fallout is a pain for > > stable maintainers, I dred every time I see a drm patch tagged for > > stable. > > > > But we've been over this all before :( > > Another example is: > > 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl") > 0d352a3a8a1f ("drm/v3d: don't leak bin job if v3d_job_init fails.") > > Two fixes for a memory leak were merged so now it's a double free. I > sent a patch on Jan 10 but no one responded. Have a link to the patch? I can't seem to find it :( _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE88C3F68F for ; Sat, 18 Jan 2020 13:18:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D6FC24698 for ; Sat, 18 Jan 2020 13:18:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="ZwOTVUgj"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Se8pfQuf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729148AbgARNSj (ORCPT ); Sat, 18 Jan 2020 08:18:39 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51797 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728688AbgARNSj (ORCPT ); Sat, 18 Jan 2020 08:18:39 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9A6B221C08; Sat, 18 Jan 2020 08:18:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 18 Jan 2020 08:18:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=DRHAHJguT0zUvuL+HVAIgaDuT2H 2OklHFj7eOTL2buQ=; b=ZwOTVUgjw+v6z8Bwo66ELXgACYkpuH5IXBOnnR+EXIF MhVc9hgm/YTxCyyB6ax/p0J02hl7Pg5tAH+8co+df5iEtLSMLjD0fLdV4UaL2V5G GRIjLqJ5SlkjXrTtc0a0VGPAhfpPdr+xZVutRe7irHPnNSIwr5bz1LVK+NwgrtgJ bgEKT9bfu4m5TFWAc9KP8rPU0/jXpaypRyoUX/UyKOeINOucyhv73u+nP2kW3zLD VJrC2VUA3Fo8ny0jBaO5lwig3P86bQBV/MaPS60GhAE81CERkRsRv09J7XRuseys i1Zrsuxp1dxopbv3HrfCMvbXNsq2UzZSjAyXI/ZFL3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=DRHAHJ guT0zUvuL+HVAIgaDuT2H2OklHFj7eOTL2buQ=; b=Se8pfQufQYd6K+LP1Jmq3v DszalQzijDvVM0b4lB06ljsdV2kXyA8NCtj1Ts/vfKKzn4qE7bmNmBy3TXwLCMiU 45+Lzt+jjJhF9NZjDo1f8EDDvdf7G2A5GP+bwhhyc+dQZ7alSADiEqGlAmEQLcPO U8VwB0qhOElvK1++AzmXwPQirijmYCiL4BQg82cAUGITgvB50BR2/Fi4gPtZcba9 sgeLtP9APAalHE3QwbIPpHzO5f9Zspk1r8QXBHANLz69o3wSO06pRYFiccvMkg3Z 42BZXp9uz9Dd3UoTuxrKIaSkVlo0h7Isb8PDUpURuujrKsHX8ywBSh1lFqvqG76Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddtgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghgucfm jfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecukfhppeefjedrjedurddugeefrdduje dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (170.143.71.37.rev.sfr.net [37.71.143.170]) by mail.messagingengine.com (Postfix) with ESMTPA id 080A430608AD; Sat, 18 Jan 2020 08:18:36 -0500 (EST) Date: Sat, 18 Jan 2020 14:18:35 +0100 From: Greg KH To: Dan Carpenter Cc: Steven Price , Sasha Levin , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Rob Herring , "dri-devel@lists.freedesktop.org" Subject: Re: [PATCH AUTOSEL 5.4 002/205] drm/panfrost: Add missing check for pfdev->regulator Message-ID: <20200118131835.GA4734@kroah.com> References: <20200116164300.6705-1-sashal@kernel.org> <20200116164300.6705-2-sashal@kernel.org> <20200117161226.GA8472@arm.com> <20200117165909.GA1949937@kroah.com> <20200118081845.GF19765@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200118081845.GF19765@kadam> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 18, 2020 at 11:18:45AM +0300, Dan Carpenter wrote: > On Fri, Jan 17, 2020 at 05:59:09PM +0100, Greg KH wrote: > > On Fri, Jan 17, 2020 at 04:12:27PM +0000, Steven Price wrote: > > > On Thu, Jan 16, 2020 at 04:39:37PM +0000, Sasha Levin wrote: > > > > From: Steven Price > > > > > > > > [ Upstream commit 52282163dfa651849e905886845bcf6850dd83c2 ] > > > > > > This commit is effectively already in 5.4. Confusingly there were two > > > versions of this upstream: > > > > > > 52282163dfa6 ("drm/panfrost: Add missing check for pfdev->regulator") > > > c90f30812a79 ("drm/panfrost: Add missing check for pfdev->regulator") > > > > > > It got merged both through a -fixes branch and through the normal merge > > > window. The two copies caused a bad merge in mainline and this was > > > effectively reverted in commit 603e398a3db2 ("drm/panfrost: Remove NULL > > > check for regulator"). > > > > > > c90f30812a79 is included in v5.4 so should already be in any v5.4.y > > > release. > > > > Have I mentioned this month just how much I hate the way the DRM tree > > handles stable patches like this? This kind of fallout is a pain for > > stable maintainers, I dred every time I see a drm patch tagged for > > stable. > > > > But we've been over this all before :( > > Another example is: > > 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl") > 0d352a3a8a1f ("drm/v3d: don't leak bin job if v3d_job_init fails.") > > Two fixes for a memory leak were merged so now it's a double free. I > sent a patch on Jan 10 but no one responded. Have a link to the patch? I can't seem to find it :(