From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8 15/20] package/kodi-screensaver-rsxs: bump version
Date: Sun, 19 Jan 2020 09:53:35 +0100 [thread overview]
Message-ID: <20200119085335.GM32369@scaer> (raw)
In-Reply-To: <f8ecfgxnh9.ln2@ID-313208.user.individual.net>
Bernd, All,
On 2020-01-18 23:42 +0100, Bernd Kuhls spake thusly:
> Am Sat, 18 Jan 2020 23:14:42 +0100 schrieb Yann E. MORIN:
> > Note: I am fine with disabling entirely, but I'd prefer this is
> > explictly stated, like:
> >
> > Even though rsxs has a minimal bundled imagemagick, we simply
> > disable drempels to avoid using a bundled library.
> ok, you can add this sentence to the commit log because this was my
> intention.
>
> > You're adding a few dependencies, some of whihch are not ovious, like
> > libtool.
>
> They are all lined-up in CMakeLists.txt, including ltdl:
> https://github.com/xbmc/screensavers.rsxs/blob/Leia/CMakeLists.txt#L15
>
> > Additionally, you're not propagating the dependency of glm (needs
> > libstdc++). That's OK because Kodi does need C++, and thus rsxs already
> > implicitly has that dependency, but I don;t like it much, though...
>
> True, but there will never be a time when Kodi will not depend on c++ so
> I did not add this dependency to all the subpackages of kodi.
Yeah, but seeing new 'select' for whjich the dependencies are not
propagated at least warrant a note in the commit log, if at all to show
the reviewers/committers that you accoutned for the deepndency in some
way (and that it is not just an oversight).
Thanks for the feedback. :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-01-19 8:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 20:06 [Buildroot] [PATCH v8 00/20] package/kodi: bump to version 18.5-Leia Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 01/20] package/kodi-platform: bump version Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 02/20] package/kodi: bump to version 18.5-Leia Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 03/20] package/kodi-audiodecoder-*: mass version bump Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 04/20] package/kodi-audioencoder-*: " Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 05/20] package/kodi-inputstream-adaptive: bump version Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 06/20] package/kodi-inputstream-rtmp: " Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 07/20] package/kodi-peripheral-joystick: " Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 08/20] package/kodi-peripheral-*: mass version bump Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 09/20] package/kodi-pvr-iptvsimple: bump version Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 10/20] package/kodi-pvr-mediaportal-tvserver: " Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 11/20] package/kodi-pvr-stalker: " Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 12/20] package/kodi-pvr-vuplus: " Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 13/20] package/kodi-pvr-*: mass version bump Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 14/20] package/kodi-screensaver-asteroids: bump version Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 15/20] package/kodi-screensaver-rsxs: " Bernd Kuhls
2020-01-18 22:14 ` Yann E. MORIN
2020-01-18 22:42 ` Bernd Kuhls
2020-01-19 8:53 ` Yann E. MORIN [this message]
2020-01-18 20:06 ` [Buildroot] [PATCH v8 16/20] package/kodi-screensaver-*: mass version bump Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 17/20] package/kodi-skin-confluence: bump version Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 18/20] package/kodi-visualisation-goom: " Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 19/20] package/kodi-visualisation-*: mass version bump Bernd Kuhls
2020-01-18 22:03 ` Yann E. MORIN
2020-01-18 22:35 ` Bernd Kuhls
2020-01-19 8:44 ` Yann E. MORIN
2020-01-19 9:02 ` Bernd Kuhls
2020-01-18 20:06 ` [Buildroot] [PATCH v8 20/20] package/kodi-vfs-sftp: bump version Bernd Kuhls
2020-01-18 22:02 ` [Buildroot] [PATCH v8 00/20] package/kodi: bump to version 18.5-Leia Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200119085335.GM32369@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.