Re: [PATCH v3 1/2] open: introduce openat2(2) syscall

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6302 bytes --]

Hi Aleksa,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kselftest/next]
[also build test ERROR on arm64/for-next/core tip/x86/asm linus/master v5.5-rc6]
[cannot apply to next-20200117]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Aleksa-Sarai/openat2-minor-uapi-cleanups/20200118-201055
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
config: openrisc-or1ksim_defconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs/open.c: In function 'build_open_flags':
   fs/open.c:1063:19: error: 'LOOKUP_NO_XDEV' undeclared (first use in this function); did you mean 'LOOKUP_NO_REVAL'?
    1063 |   lookup_flags |= LOOKUP_NO_XDEV;
         |                   ^~~~~~~~~~~~~~
         |                   LOOKUP_NO_REVAL
   fs/open.c:1063:19: note: each undeclared identifier is reported only once for each function it appears in
   fs/open.c:1065:19: error: 'LOOKUP_NO_MAGICLINKS' undeclared (first use in this function); did you mean 'RESOLVE_NO_MAGICLINKS'?
    1065 |   lookup_flags |= LOOKUP_NO_MAGICLINKS;
         |                   ^~~~~~~~~~~~~~~~~~~~
         |                   RESOLVE_NO_MAGICLINKS
>> fs/open.c:1067:19: error: 'LOOKUP_NO_SYMLINKS' undeclared (first use in this function); did you mean 'RESOLVE_NO_SYMLINKS'?
    1067 |   lookup_flags |= LOOKUP_NO_SYMLINKS;
         |                   ^~~~~~~~~~~~~~~~~~
         |                   RESOLVE_NO_SYMLINKS
   fs/open.c:1069:19: error: 'LOOKUP_BENEATH' undeclared (first use in this function); did you mean 'LOOKUP_CREATE'?
    1069 |   lookup_flags |= LOOKUP_BENEATH;
         |                   ^~~~~~~~~~~~~~
         |                   LOOKUP_CREATE
   fs/open.c:1071:19: error: 'LOOKUP_IN_ROOT' undeclared (first use in this function); did you mean 'LOOKUP_ROOT'?
    1071 |   lookup_flags |= LOOKUP_IN_ROOT;
         |                   ^~~~~~~~~~~~~~
         |                   LOOKUP_ROOT

vim +1067 fs/open.c

   976	
   977	static inline int build_open_flags(const struct open_how *how,
   978					   struct open_flags *op)
   979	{
   980		int flags = how->flags;
   981		int lookup_flags = 0;
   982		int acc_mode = ACC_MODE(flags);
   983	
   984		/* Must never be set by userspace */
   985		flags &= ~(FMODE_NONOTIFY | O_CLOEXEC);
   986	
   987		/*
   988		 * Older syscalls implicitly clear all of the invalid flags or argument
   989		 * values before calling build_open_flags(), but openat2(2) checks all
   990		 * of its arguments.
   991		 */
   992		if (flags & ~VALID_OPEN_FLAGS)
   993			return -EINVAL;
   994		if (how->resolve & ~VALID_RESOLVE_FLAGS)
   995			return -EINVAL;
   996	
   997		/* Deal with the mode. */
   998		if (WILL_CREATE(flags)) {
   999			if (how->mode & ~S_IALLUGO)
  1000				return -EINVAL;
  1001			op->mode = how->mode | S_IFREG;
  1002		} else {
  1003			if (how->mode != 0)
  1004				return -EINVAL;
  1005			op->mode = 0;
  1006		}
  1007	
  1008		/*
  1009		 * In order to ensure programs get explicit errors when trying to use
  1010		 * O_TMPFILE on old kernels, O_TMPFILE is implemented such that it
  1011		 * looks like (O_DIRECTORY|O_RDWR & ~O_CREAT) to old kernels. But we
  1012		 * have to require userspace to explicitly set it.
  1013		 */
  1014		if (flags & __O_TMPFILE) {
  1015			if ((flags & O_TMPFILE_MASK) != O_TMPFILE)
  1016				return -EINVAL;
  1017			if (!(acc_mode & MAY_WRITE))
  1018				return -EINVAL;
  1019		}
  1020		if (flags & O_PATH) {
  1021			/* O_PATH only permits certain other flags to be set. */
  1022			if (flags & ~O_PATH_FLAGS)
  1023				return -EINVAL;
  1024			acc_mode = 0;
  1025		}
  1026	
  1027		/*
  1028		 * O_SYNC is implemented as __O_SYNC|O_DSYNC.  As many places only
  1029		 * check for O_DSYNC if the need any syncing at all we enforce it's
  1030		 * always set instead of having to deal with possibly weird behaviour
  1031		 * for malicious applications setting only __O_SYNC.
  1032		 */
  1033		if (flags & __O_SYNC)
  1034			flags |= O_DSYNC;
  1035	
  1036		op->open_flag = flags;
  1037	
  1038		/* O_TRUNC implies we need access checks for write permissions */
  1039		if (flags & O_TRUNC)
  1040			acc_mode |= MAY_WRITE;
  1041	
  1042		/* Allow the LSM permission hook to distinguish append
  1043		   access from general write access. */
  1044		if (flags & O_APPEND)
  1045			acc_mode |= MAY_APPEND;
  1046	
  1047		op->acc_mode = acc_mode;
  1048	
  1049		op->intent = flags & O_PATH ? 0 : LOOKUP_OPEN;
  1050	
  1051		if (flags & O_CREAT) {
  1052			op->intent |= LOOKUP_CREATE;
  1053			if (flags & O_EXCL)
  1054				op->intent |= LOOKUP_EXCL;
  1055		}
  1056	
  1057		if (flags & O_DIRECTORY)
  1058			lookup_flags |= LOOKUP_DIRECTORY;
  1059		if (!(flags & O_NOFOLLOW))
  1060			lookup_flags |= LOOKUP_FOLLOW;
  1061	
  1062		if (how->resolve & RESOLVE_NO_XDEV)
> 1063			lookup_flags |= LOOKUP_NO_XDEV;
  1064		if (how->resolve & RESOLVE_NO_MAGICLINKS)
  1065			lookup_flags |= LOOKUP_NO_MAGICLINKS;
  1066		if (how->resolve & RESOLVE_NO_SYMLINKS)
> 1067			lookup_flags |= LOOKUP_NO_SYMLINKS;
  1068		if (how->resolve & RESOLVE_BENEATH)
  1069			lookup_flags |= LOOKUP_BENEATH;
  1070		if (how->resolve & RESOLVE_IN_ROOT)
  1071			lookup_flags |= LOOKUP_IN_ROOT;
  1072	
  1073		op->lookup_flags = lookup_flags;
  1074		return 0;
  1075	}
  1076	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 8086 bytes --]