From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85359C33CAF for ; Sun, 19 Jan 2020 20:51:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57F2220678 for ; Sun, 19 Jan 2020 20:51:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="w6LKLdRz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbgASUvH (ORCPT ); Sun, 19 Jan 2020 15:51:07 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:46196 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728682AbgASUvH (ORCPT ); Sun, 19 Jan 2020 15:51:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LsGWUihwaAVRXCio4bkLWcKVxSomCGiW0iPSq0q6tOQ=; b=w6LKLdRzYTAvT0a1qRIKNHa4rT 2plERugGKZC+NB/OP3+RAgcJmy2l31if6nnHqAPA0ivIqNmq1gPSmvatOqRRKn0Mfzy7kvRhrl83Z jD82zCwvDEetkyoOF5QR6YEUKga8J2W4hSgu//xHf9q2rTshTIjk5TTkSnevGX1i9HJg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1itHXA-0005P9-0a; Sun, 19 Jan 2020 21:51:00 +0100 Date: Sun, 19 Jan 2020 21:50:59 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , Realtek linux nic maintainers , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 0/2] net: phy: add generic ndo_do_ioctl handler phy_do_ioctl Message-ID: <20200119205059.GD17720@lunn.ch> References: <520c07a1-dd26-1414-0a2f-7f0d491589d1@gmail.com> <20200119161240.GA17720@lunn.ch> <97389eb0-fc7f-793b-6f84-730e583c00e9@googlemail.com> <20200119175109.GB17720@lunn.ch> <20200119185035.GC17720@lunn.ch> <82737a2f-b6c1-943e-42a2-d42d87212457@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82737a2f-b6c1-943e-42a2-d42d87212457@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Speaking for r8169: > If interface is up and cable detached, then it runtime-suspends > and goes into PCI D3 (chip and MDIO bus not accessible). > But ndev is "running" and PHY is attached. Hi Heiner And how does it get out of this state? I assume the PHY interrupts when the link is established. Is phylib handling this interrupt? If so, when phylib accesses the MDIO bus, the bus needs to be runtime PM aware. And if the bus is runtime PM aware, the IOCTL handler should work, when the device is runtime suspended. If the MAC is handling this interrupt, and it is the MAC interrupt handler which is run-time unsuspending, then the ioctl handler is not going to work unless it also runtime unsuspends. Andrew