From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Mon, 20 Jan 2020 03:46:58 +0000 Subject: Re: [PATCH v2 41/45] KVM: PPC: Move all vcpu init code into kvm_arch_vcpu_create() Message-Id: <20200120034658.GD14307@blackberry> List-Id: References: <20191218215530.2280-1-sean.j.christopherson@intel.com> <20191218215530.2280-42-sean.j.christopherson@intel.com> In-Reply-To: <20191218215530.2280-42-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Sean Christopherson Cc: Marc Zyngier , James Hogan , Christian Borntraeger , Janosch Frank , Paolo Bonzini , James Morse , Julien Thierry , Suzuki K Poulose , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kurz On Wed, Dec 18, 2019 at 01:55:26PM -0800, Sean Christopherson wrote: > Fold init() into create() now that the two are called back-to-back by > common KVM code (kvm_vcpu_init() calls kvm_arch_vcpu_init() as its last > action, and kvm_vm_ioctl_create_vcpu() calls kvm_arch_vcpu_create() > immediately thereafter). Rinse and repeat for kvm_arch_vcpu_uninit() > and kvm_arch_vcpu_destroy(). This paves the way for removing > kvm_arch_vcpu_{un}init() entirely. > > Note, calling kvmppc_mmu_destroy() if kvmppc_core_vcpu_create() fails > may or may not be necessary. Move it along with the more obvious call > to kvmppc_subarch_vcpu_uninit() so as not to inadvertantly introduce a > functional change and/or bug. > > No functional change intended. > > Signed-off-by: Sean Christopherson This doesn't compile. I get: CC [M] arch/powerpc/kvm/powerpc.o /home/paulus/kernel/kvm/arch/powerpc/kvm/powerpc.c: In function ‘kvm_arch_vcpu_create’: /home/paulus/kernel/kvm/arch/powerpc/kvm/powerpc.c:733:34: error: ‘kvmppc_decrementer_wakeup’ undeclared (first use in this function) vcpu->arch.dec_timer.function = kvmppc_decrementer_wakeup; ^ /home/paulus/kernel/kvm/arch/powerpc/kvm/powerpc.c:733:34: note: each undeclared identifier is reported only once for each function it appears in /home/paulus/kernel/kvm/arch/powerpc/kvm/powerpc.c: At top level: /home/paulus/kernel/kvm/arch/powerpc/kvm/powerpc.c:794:29: warning: ‘kvmppc_decrementer_wakeup’ defined but not used [-Wunused-function] static enum hrtimer_restart kvmppc_decrementer_wakeup(struct hrtimer *timer) ^ make[3]: *** [/home/paulus/kernel/kvm/scripts/Makefile.build:266: arch/powerpc/kvm/powerpc.o] Error 1 The problem is that kvmppc_decrementer_wakeup() is a static function defined in this file (arch/powerpc/kvm/powerpc.c) after kvm_arch_vcpu_create() but before kvm_arch_vcpu_init(). You need a forward static declaration of kvmppc_decrementer_wakeup() before kvm_arch_vcpu_create(), or else move one or other function. Paul. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 365EFC32771 for ; Mon, 20 Jan 2020 03:47:18 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id A7B5220684 for ; Mon, 20 Jan 2020 03:47:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="JwTKZpUV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7B5220684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ozlabs.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 13FE64AED4; Sun, 19 Jan 2020 22:47:17 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@ozlabs.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MnDPZSGgSav0; Sun, 19 Jan 2020 22:47:16 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 05BA94AED5; Sun, 19 Jan 2020 22:47:16 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BA40B4AECF for ; Sun, 19 Jan 2020 22:47:15 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NRys7uwSrmji for ; Sun, 19 Jan 2020 22:47:14 -0500 (EST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 8805E4AE9D for ; Sun, 19 Jan 2020 22:47:14 -0500 (EST) Received: by ozlabs.org (Postfix, from userid 1003) id 481Hfj74CGz9sRK; Mon, 20 Jan 2020 14:47:09 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1579492030; bh=1dfZ9T6ilNfzX2EqbpEQ5eAKgIEJ6P5R1+t5DDy1LSA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JwTKZpUVsDbJ4TcBhEsofl/FKEJ5tQrZ9Aj0R5fO2fk6ipXMh/Ze+fuyk+OikxvSN 67/wLRnHG2mDyEw8LSp8oRMr2p5aKIS1bUJ4t3GOuRZbsLyzpzHmOuZ2qTHBGOqfbF moZ/eN5AqS9TPo6UXaN5U6ooTa7+OmIYkvdmFYWqpFVxDhUrMzJ34X8IxIDq0Ms2f6 wkQCV272ypuxGDczKD0+9/Hd5WXIkWzuKDoo+s7KsL/R/o3ah5CvtNtzTmgEF5QLDA JoX9Oljp4OG49H/vTZPOusq/ctGjNpNJBsOmEo+EUk8lzjUU+oofoyANvdWbPRrwrC HNXz1928tQDng== Date: Mon, 20 Jan 2020 14:46:58 +1100 From: Paul Mackerras To: Sean Christopherson Subject: Re: [PATCH v2 41/45] KVM: PPC: Move all vcpu init code into kvm_arch_vcpu_create() Message-ID: <20200120034658.GD14307@blackberry> References: <20191218215530.2280-1-sean.j.christopherson@intel.com> <20191218215530.2280-42-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191218215530.2280-42-sean.j.christopherson@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: Cornelia Huck , Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, Marc Zyngier , Joerg Roedel , David Hildenbrand , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Borntraeger , Greg Kurz , linux-arm-kernel@lists.infradead.org, James Hogan , Paolo Bonzini , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gV2VkLCBEZWMgMTgsIDIwMTkgYXQgMDE6NTU6MjZQTSAtMDgwMCwgU2VhbiBDaHJpc3RvcGhl cnNvbiB3cm90ZToKPiBGb2xkIGluaXQoKSBpbnRvIGNyZWF0ZSgpIG5vdyB0aGF0IHRoZSB0d28g YXJlIGNhbGxlZCBiYWNrLXRvLWJhY2sgYnkKPiBjb21tb24gS1ZNIGNvZGUgKGt2bV92Y3B1X2lu aXQoKSBjYWxscyBrdm1fYXJjaF92Y3B1X2luaXQoKSBhcyBpdHMgbGFzdAo+IGFjdGlvbiwgYW5k IGt2bV92bV9pb2N0bF9jcmVhdGVfdmNwdSgpIGNhbGxzIGt2bV9hcmNoX3ZjcHVfY3JlYXRlKCkK PiBpbW1lZGlhdGVseSB0aGVyZWFmdGVyKS4gIFJpbnNlIGFuZCByZXBlYXQgZm9yIGt2bV9hcmNo X3ZjcHVfdW5pbml0KCkKPiBhbmQga3ZtX2FyY2hfdmNwdV9kZXN0cm95KCkuICBUaGlzIHBhdmVz IHRoZSB3YXkgZm9yIHJlbW92aW5nCj4ga3ZtX2FyY2hfdmNwdV97dW59aW5pdCgpIGVudGlyZWx5 Lgo+IAo+IE5vdGUsIGNhbGxpbmcga3ZtcHBjX21tdV9kZXN0cm95KCkgaWYga3ZtcHBjX2NvcmVf dmNwdV9jcmVhdGUoKSBmYWlscwo+IG1heSBvciBtYXkgbm90IGJlIG5lY2Vzc2FyeS4gIE1vdmUg aXQgYWxvbmcgd2l0aCB0aGUgbW9yZSBvYnZpb3VzIGNhbGwKPiB0byBrdm1wcGNfc3ViYXJjaF92 Y3B1X3VuaW5pdCgpIHNvIGFzIG5vdCB0byBpbmFkdmVydGFudGx5IGludHJvZHVjZSBhCj4gZnVu Y3Rpb25hbCBjaGFuZ2UgYW5kL29yIGJ1Zy4KPiAKPiBObyBmdW5jdGlvbmFsIGNoYW5nZSBpbnRl bmRlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTZWFuIENocmlzdG9waGVyc29uIDxzZWFuLmouY2hy aXN0b3BoZXJzb25AaW50ZWwuY29tPgoKVGhpcyBkb2Vzbid0IGNvbXBpbGUuICBJIGdldDoKCiAg Q0MgW01dICBhcmNoL3Bvd2VycGMva3ZtL3Bvd2VycGMubwovaG9tZS9wYXVsdXMva2VybmVsL2t2 bS9hcmNoL3Bvd2VycGMva3ZtL3Bvd2VycGMuYzogSW4gZnVuY3Rpb24g4oCYa3ZtX2FyY2hfdmNw dV9jcmVhdGXigJk6Ci9ob21lL3BhdWx1cy9rZXJuZWwva3ZtL2FyY2gvcG93ZXJwYy9rdm0vcG93 ZXJwYy5jOjczMzozNDogZXJyb3I6IOKAmGt2bXBwY19kZWNyZW1lbnRlcl93YWtldXDigJkgdW5k ZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pCiAgdmNwdS0+YXJjaC5kZWNfdGlt ZXIuZnVuY3Rpb24gPSBrdm1wcGNfZGVjcmVtZW50ZXJfd2FrZXVwOwogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXgovaG9tZS9wYXVsdXMva2VybmVsL2t2bS9hcmNoL3Bvd2VycGMv a3ZtL3Bvd2VycGMuYzo3MzM6MzQ6IG5vdGU6IGVhY2ggdW5kZWNsYXJlZCBpZGVudGlmaWVyIGlz IHJlcG9ydGVkIG9ubHkgb25jZSBmb3IgZWFjaCBmdW5jdGlvbiBpdCBhcHBlYXJzIGluCi9ob21l L3BhdWx1cy9rZXJuZWwva3ZtL2FyY2gvcG93ZXJwYy9rdm0vcG93ZXJwYy5jOiBBdCB0b3AgbGV2 ZWw6Ci9ob21lL3BhdWx1cy9rZXJuZWwva3ZtL2FyY2gvcG93ZXJwYy9rdm0vcG93ZXJwYy5jOjc5 NDoyOTogd2FybmluZzog4oCYa3ZtcHBjX2RlY3JlbWVudGVyX3dha2V1cOKAmSBkZWZpbmVkIGJ1 dCBub3QgdXNlZCBbLVd1bnVzZWQtZnVuY3Rpb25dCiBzdGF0aWMgZW51bSBocnRpbWVyX3Jlc3Rh cnQga3ZtcHBjX2RlY3JlbWVudGVyX3dha2V1cChzdHJ1Y3QgaHJ0aW1lciAqdGltZXIpCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXgptYWtlWzNdOiAqKiogWy9ob21lL3BhdWx1cy9rZXJu ZWwva3ZtL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6MjY2OiBhcmNoL3Bvd2VycGMva3ZtL3Bvd2Vy cGMub10gRXJyb3IgMQoKVGhlIHByb2JsZW0gaXMgdGhhdCBrdm1wcGNfZGVjcmVtZW50ZXJfd2Fr ZXVwKCkgaXMgYSBzdGF0aWMgZnVuY3Rpb24KZGVmaW5lZCBpbiB0aGlzIGZpbGUgKGFyY2gvcG93 ZXJwYy9rdm0vcG93ZXJwYy5jKSBhZnRlcgprdm1fYXJjaF92Y3B1X2NyZWF0ZSgpIGJ1dCBiZWZv cmUga3ZtX2FyY2hfdmNwdV9pbml0KCkuICBZb3UgbmVlZCBhCmZvcndhcmQgc3RhdGljIGRlY2xh cmF0aW9uIG9mIGt2bXBwY19kZWNyZW1lbnRlcl93YWtldXAoKSBiZWZvcmUKa3ZtX2FyY2hfdmNw dV9jcmVhdGUoKSwgb3IgZWxzZSBtb3ZlIG9uZSBvciBvdGhlciBmdW5jdGlvbi4KClBhdWwuCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWls aW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNv bHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E25C32771 for ; Mon, 20 Jan 2020 03:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5914B2073A for ; Mon, 20 Jan 2020 03:47:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="JwTKZpUV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729030AbgATDrM (ORCPT ); Sun, 19 Jan 2020 22:47:12 -0500 Received: from ozlabs.org ([203.11.71.1]:44663 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729011AbgATDrM (ORCPT ); Sun, 19 Jan 2020 22:47:12 -0500 Received: by ozlabs.org (Postfix, from userid 1003) id 481Hfj74CGz9sRK; Mon, 20 Jan 2020 14:47:09 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1579492030; bh=1dfZ9T6ilNfzX2EqbpEQ5eAKgIEJ6P5R1+t5DDy1LSA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JwTKZpUVsDbJ4TcBhEsofl/FKEJ5tQrZ9Aj0R5fO2fk6ipXMh/Ze+fuyk+OikxvSN 67/wLRnHG2mDyEw8LSp8oRMr2p5aKIS1bUJ4t3GOuRZbsLyzpzHmOuZ2qTHBGOqfbF moZ/eN5AqS9TPo6UXaN5U6ooTa7+OmIYkvdmFYWqpFVxDhUrMzJ34X8IxIDq0Ms2f6 wkQCV272ypuxGDczKD0+9/Hd5WXIkWzuKDoo+s7KsL/R/o3ah5CvtNtzTmgEF5QLDA JoX9Oljp4OG49H/vTZPOusq/ctGjNpNJBsOmEo+EUk8lzjUU+oofoyANvdWbPRrwrC HNXz1928tQDng== Date: Mon, 20 Jan 2020 14:46:58 +1100 From: Paul Mackerras To: Sean Christopherson Cc: Marc Zyngier , James Hogan , Christian Borntraeger , Janosch Frank , Paolo Bonzini , James Morse , Julien Thierry , Suzuki K Poulose , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kurz Subject: Re: [PATCH v2 41/45] KVM: PPC: Move all vcpu init code into kvm_arch_vcpu_create() Message-ID: <20200120034658.GD14307@blackberry> References: <20191218215530.2280-1-sean.j.christopherson@intel.com> <20191218215530.2280-42-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191218215530.2280-42-sean.j.christopherson@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Dec 18, 2019 at 01:55:26PM -0800, Sean Christopherson wrote: > Fold init() into create() now that the two are called back-to-back by > common KVM code (kvm_vcpu_init() calls kvm_arch_vcpu_init() as its last > action, and kvm_vm_ioctl_create_vcpu() calls kvm_arch_vcpu_create() > immediately thereafter). Rinse and repeat for kvm_arch_vcpu_uninit() > and kvm_arch_vcpu_destroy(). This paves the way for removing > kvm_arch_vcpu_{un}init() entirely. > > Note, calling kvmppc_mmu_destroy() if kvmppc_core_vcpu_create() fails > may or may not be necessary. Move it along with the more obvious call > to kvmppc_subarch_vcpu_uninit() so as not to inadvertantly introduce a > functional change and/or bug. > > No functional change intended. > > Signed-off-by: Sean Christopherson This doesn't compile. I get: CC [M] arch/powerpc/kvm/powerpc.o /home/paulus/kernel/kvm/arch/powerpc/kvm/powerpc.c: In function ‘kvm_arch_vcpu_create’: /home/paulus/kernel/kvm/arch/powerpc/kvm/powerpc.c:733:34: error: ‘kvmppc_decrementer_wakeup’ undeclared (first use in this function) vcpu->arch.dec_timer.function = kvmppc_decrementer_wakeup; ^ /home/paulus/kernel/kvm/arch/powerpc/kvm/powerpc.c:733:34: note: each undeclared identifier is reported only once for each function it appears in /home/paulus/kernel/kvm/arch/powerpc/kvm/powerpc.c: At top level: /home/paulus/kernel/kvm/arch/powerpc/kvm/powerpc.c:794:29: warning: ‘kvmppc_decrementer_wakeup’ defined but not used [-Wunused-function] static enum hrtimer_restart kvmppc_decrementer_wakeup(struct hrtimer *timer) ^ make[3]: *** [/home/paulus/kernel/kvm/scripts/Makefile.build:266: arch/powerpc/kvm/powerpc.o] Error 1 The problem is that kvmppc_decrementer_wakeup() is a static function defined in this file (arch/powerpc/kvm/powerpc.c) after kvm_arch_vcpu_create() but before kvm_arch_vcpu_init(). You need a forward static declaration of kvmppc_decrementer_wakeup() before kvm_arch_vcpu_create(), or else move one or other function. Paul. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7847C32771 for ; Mon, 20 Jan 2020 03:47:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 800B720684 for ; Mon, 20 Jan 2020 03:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nXoDxyWo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="JwTKZpUV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 800B720684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ozlabs.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g9m3V9+WE2J/2yAOX4bFxKqKMBi2OUI1MKBmGbdcb+E=; b=nXoDxyWofyQL5u rzLu1vpxdcaSgRncUN0p5z3IcL+qiyt7rok4X8P2DwmXlRPIes+/M3IJZ9KcUO2BfOT7AZKhlBb1X NAuOTIknq6BUunSt1PiRSDVTeY9bG11Yh/XASnfnVxkOxv6Jzf9D0UlzV/ShrAT9snA9NZeAXXgHW hZDLKWyBj9a91NQw0ngXb8RIHlRsU6S+yhRounMLsWZRITQRsoS1olmI3YIt1M0IC7uFAUP1iZyfZ 1+JuftEWN55JDicWtnjHuIuBxIgjIaiLZXnimeyTHp8AnyaNDYrGqJK5rXB51uzhWC8fPb/6wEyKG HgUgrzpg2RXJA/I/tYeg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1itO23-0004l3-P4; Mon, 20 Jan 2020 03:47:19 +0000 Received: from bilbo.ozlabs.org ([203.11.71.1] helo=ozlabs.org) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1itO20-0004kD-CX for linux-arm-kernel@lists.infradead.org; Mon, 20 Jan 2020 03:47:17 +0000 Received: by ozlabs.org (Postfix, from userid 1003) id 481Hfj74CGz9sRK; Mon, 20 Jan 2020 14:47:09 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1579492030; bh=1dfZ9T6ilNfzX2EqbpEQ5eAKgIEJ6P5R1+t5DDy1LSA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JwTKZpUVsDbJ4TcBhEsofl/FKEJ5tQrZ9Aj0R5fO2fk6ipXMh/Ze+fuyk+OikxvSN 67/wLRnHG2mDyEw8LSp8oRMr2p5aKIS1bUJ4t3GOuRZbsLyzpzHmOuZ2qTHBGOqfbF moZ/eN5AqS9TPo6UXaN5U6ooTa7+OmIYkvdmFYWqpFVxDhUrMzJ34X8IxIDq0Ms2f6 wkQCV272ypuxGDczKD0+9/Hd5WXIkWzuKDoo+s7KsL/R/o3ah5CvtNtzTmgEF5QLDA JoX9Oljp4OG49H/vTZPOusq/ctGjNpNJBsOmEo+EUk8lzjUU+oofoyANvdWbPRrwrC HNXz1928tQDng== Date: Mon, 20 Jan 2020 14:46:58 +1100 From: Paul Mackerras To: Sean Christopherson Subject: Re: [PATCH v2 41/45] KVM: PPC: Move all vcpu init code into kvm_arch_vcpu_create() Message-ID: <20200120034658.GD14307@blackberry> References: <20191218215530.2280-1-sean.j.christopherson@intel.com> <20191218215530.2280-42-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191218215530.2280-42-sean.j.christopherson@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200119_194716_585442_F17056F6 X-CRM114-Status: UNSURE ( 9.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, Suzuki K Poulose , Marc Zyngier , Joerg Roedel , David Hildenbrand , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Borntraeger , Greg Kurz , James Morse , linux-arm-kernel@lists.infradead.org, James Hogan , Paolo Bonzini , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Julien Thierry , Jim Mattson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMTgsIDIwMTkgYXQgMDE6NTU6MjZQTSAtMDgwMCwgU2VhbiBDaHJpc3RvcGhl cnNvbiB3cm90ZToKPiBGb2xkIGluaXQoKSBpbnRvIGNyZWF0ZSgpIG5vdyB0aGF0IHRoZSB0d28g YXJlIGNhbGxlZCBiYWNrLXRvLWJhY2sgYnkKPiBjb21tb24gS1ZNIGNvZGUgKGt2bV92Y3B1X2lu aXQoKSBjYWxscyBrdm1fYXJjaF92Y3B1X2luaXQoKSBhcyBpdHMgbGFzdAo+IGFjdGlvbiwgYW5k IGt2bV92bV9pb2N0bF9jcmVhdGVfdmNwdSgpIGNhbGxzIGt2bV9hcmNoX3ZjcHVfY3JlYXRlKCkK PiBpbW1lZGlhdGVseSB0aGVyZWFmdGVyKS4gIFJpbnNlIGFuZCByZXBlYXQgZm9yIGt2bV9hcmNo X3ZjcHVfdW5pbml0KCkKPiBhbmQga3ZtX2FyY2hfdmNwdV9kZXN0cm95KCkuICBUaGlzIHBhdmVz IHRoZSB3YXkgZm9yIHJlbW92aW5nCj4ga3ZtX2FyY2hfdmNwdV97dW59aW5pdCgpIGVudGlyZWx5 Lgo+IAo+IE5vdGUsIGNhbGxpbmcga3ZtcHBjX21tdV9kZXN0cm95KCkgaWYga3ZtcHBjX2NvcmVf dmNwdV9jcmVhdGUoKSBmYWlscwo+IG1heSBvciBtYXkgbm90IGJlIG5lY2Vzc2FyeS4gIE1vdmUg aXQgYWxvbmcgd2l0aCB0aGUgbW9yZSBvYnZpb3VzIGNhbGwKPiB0byBrdm1wcGNfc3ViYXJjaF92 Y3B1X3VuaW5pdCgpIHNvIGFzIG5vdCB0byBpbmFkdmVydGFudGx5IGludHJvZHVjZSBhCj4gZnVu Y3Rpb25hbCBjaGFuZ2UgYW5kL29yIGJ1Zy4KPiAKPiBObyBmdW5jdGlvbmFsIGNoYW5nZSBpbnRl bmRlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTZWFuIENocmlzdG9waGVyc29uIDxzZWFuLmouY2hy aXN0b3BoZXJzb25AaW50ZWwuY29tPgoKVGhpcyBkb2Vzbid0IGNvbXBpbGUuICBJIGdldDoKCiAg Q0MgW01dICBhcmNoL3Bvd2VycGMva3ZtL3Bvd2VycGMubwovaG9tZS9wYXVsdXMva2VybmVsL2t2 bS9hcmNoL3Bvd2VycGMva3ZtL3Bvd2VycGMuYzogSW4gZnVuY3Rpb24g4oCYa3ZtX2FyY2hfdmNw dV9jcmVhdGXigJk6Ci9ob21lL3BhdWx1cy9rZXJuZWwva3ZtL2FyY2gvcG93ZXJwYy9rdm0vcG93 ZXJwYy5jOjczMzozNDogZXJyb3I6IOKAmGt2bXBwY19kZWNyZW1lbnRlcl93YWtldXDigJkgdW5k ZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pCiAgdmNwdS0+YXJjaC5kZWNfdGlt ZXIuZnVuY3Rpb24gPSBrdm1wcGNfZGVjcmVtZW50ZXJfd2FrZXVwOwogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXgovaG9tZS9wYXVsdXMva2VybmVsL2t2bS9hcmNoL3Bvd2VycGMv a3ZtL3Bvd2VycGMuYzo3MzM6MzQ6IG5vdGU6IGVhY2ggdW5kZWNsYXJlZCBpZGVudGlmaWVyIGlz IHJlcG9ydGVkIG9ubHkgb25jZSBmb3IgZWFjaCBmdW5jdGlvbiBpdCBhcHBlYXJzIGluCi9ob21l L3BhdWx1cy9rZXJuZWwva3ZtL2FyY2gvcG93ZXJwYy9rdm0vcG93ZXJwYy5jOiBBdCB0b3AgbGV2 ZWw6Ci9ob21lL3BhdWx1cy9rZXJuZWwva3ZtL2FyY2gvcG93ZXJwYy9rdm0vcG93ZXJwYy5jOjc5 NDoyOTogd2FybmluZzog4oCYa3ZtcHBjX2RlY3JlbWVudGVyX3dha2V1cOKAmSBkZWZpbmVkIGJ1 dCBub3QgdXNlZCBbLVd1bnVzZWQtZnVuY3Rpb25dCiBzdGF0aWMgZW51bSBocnRpbWVyX3Jlc3Rh cnQga3ZtcHBjX2RlY3JlbWVudGVyX3dha2V1cChzdHJ1Y3QgaHJ0aW1lciAqdGltZXIpCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXgptYWtlWzNdOiAqKiogWy9ob21lL3BhdWx1cy9rZXJu ZWwva3ZtL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6MjY2OiBhcmNoL3Bvd2VycGMva3ZtL3Bvd2Vy cGMub10gRXJyb3IgMQoKVGhlIHByb2JsZW0gaXMgdGhhdCBrdm1wcGNfZGVjcmVtZW50ZXJfd2Fr ZXVwKCkgaXMgYSBzdGF0aWMgZnVuY3Rpb24KZGVmaW5lZCBpbiB0aGlzIGZpbGUgKGFyY2gvcG93 ZXJwYy9rdm0vcG93ZXJwYy5jKSBhZnRlcgprdm1fYXJjaF92Y3B1X2NyZWF0ZSgpIGJ1dCBiZWZv cmUga3ZtX2FyY2hfdmNwdV9pbml0KCkuICBZb3UgbmVlZCBhCmZvcndhcmQgc3RhdGljIGRlY2xh cmF0aW9uIG9mIGt2bXBwY19kZWNyZW1lbnRlcl93YWtldXAoKSBiZWZvcmUKa3ZtX2FyY2hfdmNw dV9jcmVhdGUoKSwgb3IgZWxzZSBtb3ZlIG9uZSBvciBvdGhlciBmdW5jdGlvbi4KClBhdWwuCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==