From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladis Dronov <vdronov@redhat.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>,
George Shuklin <george.shuklin@gmail.com>
Subject: Re: [PATCH iproute2] ip: fix link type and vlan oneline output
Date: Mon, 20 Jan 2020 09:34:04 -0800 [thread overview]
Message-ID: <20200120093404.172208c2@hermes.lan> (raw)
In-Reply-To: <20200119011251.7153-1-vdronov@redhat.com>
On Sun, 19 Jan 2020 02:12:51 +0100
Vladis Dronov <vdronov@redhat.com> wrote:
> Move link type printing in print_linkinfo() so multiline output does not
> break link options line. Add oneline support for vlan's ingress and egress
> qos maps.
>
> Before the fix:
>
> # ip -details link show veth90.4000
> 5: veth90.4000@veth90: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
> link/ether 26:9a:05:af:db:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535
> vlan protocol 802.1Q id 4000 <REORDER_HDR> the option line is broken ^^^
> ingress-qos-map { 1:2 }
> egress-qos-map { 2:1 } addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>
> # ip -oneline -details link show veth90.4000
> 5: veth90.4000@veth90: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000\ link/ether 26:9a:05:af:db:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535 \ vlan protocol 802.1Q id 4000 <REORDER_HDR>
> ingress-qos-map { 1:2 } <<< a multiline output despite -oneline
> egress-qos-map { 2:1 } addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>
> After the fix:
>
> # ip -details link show veth90.4000
> 5: veth90.4000@veth90: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
> link/ether 26:9a:05:af:db:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
> vlan protocol 802.1Q id 4000 <REORDER_HDR>
> ingress-qos-map { 1:2 }
> egress-qos-map { 2:1 }
>
> # ip -oneline -details link show veth90.4000
> 5: veth90.4000@veth90: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000\ link/ether 26:9a:05:af:db:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 \ vlan protocol 802.1Q id 4000 <REORDER_HDR> \ ingress-qos-map { 1:2 } \ egress-qos-map { 2:1 }
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206241
> Reported-by: George Shuklin <george.shuklin@gmail.com>
> Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Applied with changes.
The change to ipaddress.c was incorrect. You can't change the order of things in the
output.
Second, you needed to have a Fixes tag. In this case, it went back to original
vlan support.
next prev parent reply other threads:[~2020-01-20 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 1:12 [PATCH iproute2] ip: fix link type and vlan oneline output Vladis Dronov
2020-01-19 1:28 ` Vladis Dronov
2020-01-20 17:34 ` Stephen Hemminger [this message]
2020-01-21 16:59 ` Vladis Dronov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120093404.172208c2@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=george.shuklin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.