From: Ido Schimmel <idosch@idosch.org>
To: "Hans-Christian Egtvedt (hegtvedt)" <hegtvedt@cisco.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: Regression in macvlan driver in stable release 4.4.209
Date: Mon, 20 Jan 2020 11:57:14 +0200 [thread overview]
Message-ID: <20200120095714.GA3421303@splinter> (raw)
In-Reply-To: <01accb3f-bb52-906f-d164-c49f2dc170bc@cisco.com>
On Mon, Jan 20, 2020 at 09:17:35AM +0000, Hans-Christian Egtvedt (hegtvedt) wrote:
> Hello,
>
> I am seeing a regression in the macvlan kernel driver after Linux stable
> release 4.4.209, bisecting identifies commit
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.4.y&id=8d28d7e88851b1081b05dc269a27df1c8a903f3e
Noticed it too last week (on net-next), but Eric already fixed it:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1712b2fff8c682d145c7889d2290696647d82dab
I assume the patch will find its way to 4.4.y soon now that it is in
mainline.
>
> There seems to be a history behind this, and I do not have the full
> overview of the intention behind the change.
>
> What I see on my target, Aarch64 CPU, is that this patch moves the eth
> pointer in macvlan_broadcast() function some bytes. This will cause
> everything within the ethhdr struct to be wrong AFAICT.
>
> An example:
> Original code "eth = eth_hdr(skb)"
> eth = ffffffc007a1b002
> New code "eth = skb_eth_hdr(skb)"
> eth = ffffffc007a1b010
>
> Let me know if I can assist in any way.
>
> --
> Best regards,
> Hans-Christian Noren Egtvedt
next prev parent reply other threads:[~2020-01-20 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 9:17 Regression in macvlan driver in stable release 4.4.209 Hans-Christian Egtvedt (hegtvedt)
2020-01-20 9:57 ` Ido Schimmel [this message]
2020-01-20 10:03 ` Hans-Christian Egtvedt (hegtvedt)
2020-01-20 18:35 ` Sasha Levin
2020-01-20 18:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120095714.GA3421303@splinter \
--to=idosch@idosch.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hegtvedt@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.