From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 35/36] platform/x86: intel_pmc_ipc: Convert to MFD Date: Mon, 20 Jan 2020 12:50:59 +0000 Message-ID: <20200120125059.GF15507@dell> References: <20200113135623.56286-1-mika.westerberg@linux.intel.com> <20200113135623.56286-36-mika.westerberg@linux.intel.com> <20200116132108.GH325@dell> <20200116143730.GE2838@lahna.fi.intel.com> <20200117113202.GH15507@dell> <20200117142750.GP2838@lahna.fi.intel.com> <20200120081246.GS15507@dell> <20200120091258.GH2665@lahna.fi.intel.com> <20200120111450.GE15507@dell> <20200120112634.GN2665@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20200120112634.GN2665@lahna.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Mika Westerberg Cc: Andy Shevchenko , Darren Hart , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , "David E . Box" , Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Mon, 20 Jan 2020, Mika Westerberg wrote: > On Mon, Jan 20, 2020 at 11:14:50AM +0000, Lee Jones wrote: > > On Mon, 20 Jan 2020, Mika Westerberg wrote: > > > > > On Mon, Jan 20, 2020 at 08:12:46AM +0000, Lee Jones wrote: > > > > > Well, by "library" I mean that the SCU IPC itself does not bind to > > > > > anything but instead it gets called by different drivers such as this > > > > > one passing the device pointer that is the SCU IPC device. Here for > > > > > example it is the platfrom device created from an ACPI description. > > > > > > > > Not keen on that at all. Why can it not be a platform device? > > > > > > We also call the same library from a PCI driver (intel_scu_pcidrv.c in > > > this series) where the device is of type struct pci_dev. > > > > Not sure I understand the issue. > > You are asking why it cannot be a platform device. It cannot be because > we are calling the same library from a PCI driver where there is no > platform device available (only struct pci_dev). I'm asking why it needs to be called at all. Why can't it be probed using the Device Driver API, like most other drivers? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog