From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73DFBC2D0DB for ; Mon, 20 Jan 2020 15:28:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A08B22464 for ; Mon, 20 Jan 2020 15:28:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WM3/QuTj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728843AbgATP2N (ORCPT ); Mon, 20 Jan 2020 10:28:13 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:38340 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726642AbgATP2K (ORCPT ); Mon, 20 Jan 2020 10:28:10 -0500 Received: by mail-wm1-f65.google.com with SMTP id u2so15127667wmc.3 for ; Mon, 20 Jan 2020 07:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=w+9WBX8T8487sYdaCRBOXdftKEOOIGARUU12ptPCXoI=; b=WM3/QuTjf8YHugRgHr0CAc4EPmW7lL5TBdACtz7cIwWejTZRMsjvhvpYDk1vBCv8x/ mwSEMBD6BloK3XpD4M9pIYUXdWrL2+620dZ1+sv7VzGqnDERmsL63ChlF8tg20oIUyHN 52ASdnLuNO3Sz8qauPMfDhgnCWpxUMumc6RftxuofGduJ6V4Ri+m9/ezp6kMCpjP0Cag AtFqAedbPek8I2J21QlxubzVd67+p4k75DZEBCr6gQdRH2dUKnHDTWK3kJyHePYYwXMd 8gKlHjdsZ26gCY4wieLh8B5FzXN/qNQg1wHFrQ0GWe3qX7B5O2cOpVF0DpGUbwhfDz+P oqIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=w+9WBX8T8487sYdaCRBOXdftKEOOIGARUU12ptPCXoI=; b=OdAg/dFsq1FlLbeOZLnBE4ZfYC3NbkPuMQkx8P2FH9cw5hJ7lae1DViBnfH9dCM//k br/c8WPhQ2ub75HplvznLeisZa6GC1yoG1qdFpCwy+kTezkB5Vwm/5ElX0LVis1N9GYm Z9d2xyQVvb6BniQJK5ljyXzVENoAfoFpYxI1sjlXAUTVgi9XDW3yZLbjwatnbIcWIbKG s3NNx0gr8VzrVFtkWnsbmMF5i9JCe6RXSg8cunTjqjz+VRqN8XuqXoukUGHc+xKqsI0L O5Cbb4m5FDxeewg5MgJ/vjQdeAdHvQt1wNrQ8idyxrKGUUr/dx3HVurp/uimyLjaXNMo tINw== X-Gm-Message-State: APjAAAVrKdwtlrHDuneVIfEQRS/LaUXMA9yC7v8cBaIhLf9ZzpSQOhRP uxWAwargOgOJsJWL/utZzOg+wA== X-Google-Smtp-Source: APXvYqxyY0xjDcRn7kSUge9Pe/ZJykQdMkCOLrQxdDGvp71dWPGzFxihXcV4Py+Y8+/t7qRz+k6uxg== X-Received: by 2002:a1c:dcd5:: with SMTP id t204mr19453471wmg.34.1579534088409; Mon, 20 Jan 2020 07:28:08 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id d14sm51225920wru.9.2020.01.20.07.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 07:28:07 -0800 (PST) Date: Mon, 20 Jan 2020 15:28:04 +0000 From: Quentin Perret To: Dietmar Eggemann Cc: lukasz.luba@arm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Chris.Redpath@arm.com, ionela.voinescu@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, patrick.bellasi@matbug.net Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200120152804.GB164543@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <17b77e0c-9455-0479-d37b-c57717c784c7@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17b77e0c-9455-0479-d37b-c57717c784c7@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Monday 20 Jan 2020 at 15:53:35 (+0100), Dietmar Eggemann wrote: > Would be really nice if this wouldn't be required. We should really aim > for 1 framework == 1 set of interfaces. > > What happens if someone calls em_get_pd() on a CPU EM? > > E.g: > > static struct perf_domain *pd_init(int cpu) > { > - struct em_perf_domain *obj = em_cpu_get(cpu); > + struct device *dev = get_cpu_device(cpu); > + struct em_perf_domain *obj = em_pd_get(dev); > struct perf_domain *pd; > > Two versions of one functionality will confuse API user from the > beginning ... Agreed, this looks a bit confusing. It should be trivial to make em_dev_get() (or whatever we end up calling it) work for CPUs too, though. And we could always have a em_cpu_get(int cpu) API that is a basically a wrapper around em_dev_get() for convenience. Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A440C2D0DB for ; Mon, 20 Jan 2020 15:28:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E9CE22314 for ; Mon, 20 Jan 2020 15:28:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sivlWHky"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="WM3/QuTj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E9CE22314 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VUy8s5p0+BJ60AerfSAXNWEYSZ2mF0MbWgNCrBszljI=; b=sivlWHkylVTwW2 cRK1rO8fUkkWG77sqLy2qH74RupdW2mARi34pOkTsGu/IQkn78Hu0dQSa/vLl4Azbm4aOgw85GjsX UxDVd5HZ+CP0C2Altq3BdDBHBn2PvXb8OVrhQhbuWmU4jg+Hb66OMjPoC3LfmSntbk3RPpuxWG20S sRZQbXbmZufzpQZ8ckl14ObEar8CSycpliCYUyXnelT6IBD5Gf3TnTNod5zHdItQW5n6GRwamsVGr kdQYEvwuRN4/KtmYxae5pIJ0b8sXo5UD8a6nwO/EpAWfeTAwelpLdzjUCGZrYLZWGixEp0Bi15574 nBtdf2m+/HFkSLvU9MaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1itYyY-0005Fx-B3; Mon, 20 Jan 2020 15:28:26 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1itYyH-00054H-Vz for linux-mediatek@lists.infradead.org; Mon, 20 Jan 2020 15:28:16 +0000 Received: by mail-wm1-x341.google.com with SMTP id m24so14908378wmc.3 for ; Mon, 20 Jan 2020 07:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=w+9WBX8T8487sYdaCRBOXdftKEOOIGARUU12ptPCXoI=; b=WM3/QuTjf8YHugRgHr0CAc4EPmW7lL5TBdACtz7cIwWejTZRMsjvhvpYDk1vBCv8x/ mwSEMBD6BloK3XpD4M9pIYUXdWrL2+620dZ1+sv7VzGqnDERmsL63ChlF8tg20oIUyHN 52ASdnLuNO3Sz8qauPMfDhgnCWpxUMumc6RftxuofGduJ6V4Ri+m9/ezp6kMCpjP0Cag AtFqAedbPek8I2J21QlxubzVd67+p4k75DZEBCr6gQdRH2dUKnHDTWK3kJyHePYYwXMd 8gKlHjdsZ26gCY4wieLh8B5FzXN/qNQg1wHFrQ0GWe3qX7B5O2cOpVF0DpGUbwhfDz+P oqIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=w+9WBX8T8487sYdaCRBOXdftKEOOIGARUU12ptPCXoI=; b=AWKmw50LWLyYE+1H4/8MlyAoztvLZDQbEBGS+8+0a1XrvvEHIXQAimYKUqiJ6x83ZI domUfNYL9IWX8+znsdj7c9RjF9oMrLUIH9jeDbCvTWljnhpYJcK3GxmwolJmRlEIsGlz m4w5l20G16B/H3fHYPLOcyXiSh0N5aUHBItE6diR3nry56L17O9/hre0pR5EVftf2HPB budEEc91IK9HaYX8V4+hTLQgaz9r3MJfNpJK0M3WJG66/SrGYGF11/3vb4qxWFq3swlY IF1hIbwgsGoRYGp1BCVMZWqy6+UFjQuX9qScfyF9O2kf5W8gvN00QRqdI8kIPgVWznHZ fY+w== X-Gm-Message-State: APjAAAV5y9ReZlOByyTjCWWZ5qwd59Mk8tTLQJPQOKmrHSpB7qsODpBO 6CP3UgPyA031urPuB9cWnomLMw== X-Google-Smtp-Source: APXvYqxyY0xjDcRn7kSUge9Pe/ZJykQdMkCOLrQxdDGvp71dWPGzFxihXcV4Py+Y8+/t7qRz+k6uxg== X-Received: by 2002:a1c:dcd5:: with SMTP id t204mr19453471wmg.34.1579534088409; Mon, 20 Jan 2020 07:28:08 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id d14sm51225920wru.9.2020.01.20.07.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 07:28:07 -0800 (PST) Date: Mon, 20 Jan 2020 15:28:04 +0000 From: Quentin Perret To: Dietmar Eggemann Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200120152804.GB164543@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <17b77e0c-9455-0479-d37b-c57717c784c7@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <17b77e0c-9455-0479-d37b-c57717c784c7@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200120_072810_029881_9AC96C77 X-CRM114-Status: GOOD ( 10.06 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org, peterz@infradead.org, viresh.kumar@linaro.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Chris.Redpath@arm.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, shawnguo@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, ionela.voinescu@arm.com, lukasz.luba@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Monday 20 Jan 2020 at 15:53:35 (+0100), Dietmar Eggemann wrote: > Would be really nice if this wouldn't be required. We should really aim > for 1 framework == 1 set of interfaces. > > What happens if someone calls em_get_pd() on a CPU EM? > > E.g: > > static struct perf_domain *pd_init(int cpu) > { > - struct em_perf_domain *obj = em_cpu_get(cpu); > + struct device *dev = get_cpu_device(cpu); > + struct em_perf_domain *obj = em_pd_get(dev); > struct perf_domain *pd; > > Two versions of one functionality will confuse API user from the > beginning ... Agreed, this looks a bit confusing. It should be trivial to make em_dev_get() (or whatever we end up calling it) work for CPUs too, though. And we could always have a em_cpu_get(int cpu) API that is a basically a wrapper around em_dev_get() for convenience. Thanks, Quentin _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Perret Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Date: Mon, 20 Jan 2020 15:28:04 +0000 Message-ID: <20200120152804.GB164543@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <17b77e0c-9455-0479-d37b-c57717c784c7@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <17b77e0c-9455-0479-d37b-c57717c784c7@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Dietmar Eggemann Cc: lukasz.luba@arm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com, Morten.Rasmussen@arm.com, Chris.Redpath@arm.com, ionela.voinescu@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com List-Id: linux-omap@vger.kernel.org On Monday 20 Jan 2020 at 15:53:35 (+0100), Dietmar Eggemann wrote: > Would be really nice if this wouldn't be required. We should really aim > for 1 framework == 1 set of interfaces. > > What happens if someone calls em_get_pd() on a CPU EM? > > E.g: > > static struct perf_domain *pd_init(int cpu) > { > - struct em_perf_domain *obj = em_cpu_get(cpu); > + struct device *dev = get_cpu_device(cpu); > + struct em_perf_domain *obj = em_pd_get(dev); > struct perf_domain *pd; > > Two versions of one functionality will confuse API user from the > beginning ... Agreed, this looks a bit confusing. It should be trivial to make em_dev_get() (or whatever we end up calling it) work for CPUs too, though. And we could always have a em_cpu_get(int cpu) API that is a basically a wrapper around em_dev_get() for convenience. Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B0F2C2D0DB for ; Mon, 20 Jan 2020 15:28:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 095D222314 for ; Mon, 20 Jan 2020 15:28:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GHzWhQGg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="WM3/QuTj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 095D222314 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J2bjHHkA25MUY3s6pAkQCAa7oxIK33wRqXb9xjtNzSo=; b=GHzWhQGgxt8pEs V5GZ7fjkNYfaYvhRan3/BH65JP+d/8wj/VCES73+DzSq2eL9ODujzIDrIc/n7HC0tdK7rlTu7dopD egqprS3YLskQXME68Iu8643/D+7I6e8wMQQvXG5seTY2WfHgBZYCs8jddx+Z6qdElELv9ASeH+cST JnuKwk5ivoEJgkJp0hQ6TBDKtvvCJtHDCqXnTlTTbFHktFXJg+BggVrgpFZHr7DGO9ydk3K+Gl77I eIo4prUJlCzjj0YVYak6iZE/q5MYQ4R5N7pj+WJlfNrq94BocHuuBEJgtRxy+63UlHWM/ejYJo9uP bDkIn89VEEk3YdZRvgTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1itYyQ-00056x-Ab; Mon, 20 Jan 2020 15:28:18 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1itYyH-00054F-UI for linux-arm-kernel@lists.infradead.org; Mon, 20 Jan 2020 15:28:16 +0000 Received: by mail-wm1-x342.google.com with SMTP id p17so22423wmb.0 for ; Mon, 20 Jan 2020 07:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=w+9WBX8T8487sYdaCRBOXdftKEOOIGARUU12ptPCXoI=; b=WM3/QuTjf8YHugRgHr0CAc4EPmW7lL5TBdACtz7cIwWejTZRMsjvhvpYDk1vBCv8x/ mwSEMBD6BloK3XpD4M9pIYUXdWrL2+620dZ1+sv7VzGqnDERmsL63ChlF8tg20oIUyHN 52ASdnLuNO3Sz8qauPMfDhgnCWpxUMumc6RftxuofGduJ6V4Ri+m9/ezp6kMCpjP0Cag AtFqAedbPek8I2J21QlxubzVd67+p4k75DZEBCr6gQdRH2dUKnHDTWK3kJyHePYYwXMd 8gKlHjdsZ26gCY4wieLh8B5FzXN/qNQg1wHFrQ0GWe3qX7B5O2cOpVF0DpGUbwhfDz+P oqIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=w+9WBX8T8487sYdaCRBOXdftKEOOIGARUU12ptPCXoI=; b=H7PQ121eQscPvI2N/YeJAIeQ6X8925cAjwvqStReIwpznmwY28yI/h3Pvvxsro28Jw BndsnxAkX37OIoIRAd1t7gMVVig2fsJ7loVnAiXf3edsr/8Uv4wrYD86pWF1osx22OqC atiHpVZmtqMm5W8KBC3saLm7ZmrMpAHdzJm5wPhrkX2dmAuu1wOkt/nDNWuxOooyWpoD 5yg67PZBkR/Ecufx9DlfdP7+olyATTBBHWgdo2QxJJXjg5nZdZqm2cp0XaHaS+3kCrX0 Bzcj1khC6AxHYiP+ABrJal0nb5AqZ+cW33bl/tHQ0VWEzwA6ZZwEy8Y6oE57k4iGt/cj WZUw== X-Gm-Message-State: APjAAAUDsOApGt8QCP8T4FdRIW8zrxdUwCq4onH3sY90frVDDV8qIllY HQjzOa7rApyixSZwcX8J7lUeew== X-Google-Smtp-Source: APXvYqxyY0xjDcRn7kSUge9Pe/ZJykQdMkCOLrQxdDGvp71dWPGzFxihXcV4Py+Y8+/t7qRz+k6uxg== X-Received: by 2002:a1c:dcd5:: with SMTP id t204mr19453471wmg.34.1579534088409; Mon, 20 Jan 2020 07:28:08 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id d14sm51225920wru.9.2020.01.20.07.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 07:28:07 -0800 (PST) Date: Mon, 20 Jan 2020 15:28:04 +0000 From: Quentin Perret To: Dietmar Eggemann Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200120152804.GB164543@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <17b77e0c-9455-0479-d37b-c57717c784c7@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <17b77e0c-9455-0479-d37b-c57717c784c7@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200120_072810_018918_0242B940 X-CRM114-Status: GOOD ( 11.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org, peterz@infradead.org, viresh.kumar@linaro.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, festevam@gmail.com, Morten.Rasmussen@arm.com, robh@kernel.org, amit.kucheria@verdurent.com, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, daniel@ffwll.ch, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Chris.Redpath@arm.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, shawnguo@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, ionela.voinescu@arm.com, lukasz.luba@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday 20 Jan 2020 at 15:53:35 (+0100), Dietmar Eggemann wrote: > Would be really nice if this wouldn't be required. We should really aim > for 1 framework == 1 set of interfaces. > > What happens if someone calls em_get_pd() on a CPU EM? > > E.g: > > static struct perf_domain *pd_init(int cpu) > { > - struct em_perf_domain *obj = em_cpu_get(cpu); > + struct device *dev = get_cpu_device(cpu); > + struct em_perf_domain *obj = em_pd_get(dev); > struct perf_domain *pd; > > Two versions of one functionality will confuse API user from the > beginning ... Agreed, this looks a bit confusing. It should be trivial to make em_dev_get() (or whatever we end up calling it) work for CPUs too, though. And we could always have a em_cpu_get(int cpu) API that is a basically a wrapper around em_dev_get() for convenience. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C635C33CB8 for ; Mon, 20 Jan 2020 17:10:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C19522314 for ; Mon, 20 Jan 2020 17:10:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="WM3/QuTj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C19522314 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 84CC16EA2F; Mon, 20 Jan 2020 17:09:48 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 05BF56E9BE for ; Mon, 20 Jan 2020 15:28:09 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id d73so12234wmd.1 for ; Mon, 20 Jan 2020 07:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=w+9WBX8T8487sYdaCRBOXdftKEOOIGARUU12ptPCXoI=; b=WM3/QuTjf8YHugRgHr0CAc4EPmW7lL5TBdACtz7cIwWejTZRMsjvhvpYDk1vBCv8x/ mwSEMBD6BloK3XpD4M9pIYUXdWrL2+620dZ1+sv7VzGqnDERmsL63ChlF8tg20oIUyHN 52ASdnLuNO3Sz8qauPMfDhgnCWpxUMumc6RftxuofGduJ6V4Ri+m9/ezp6kMCpjP0Cag AtFqAedbPek8I2J21QlxubzVd67+p4k75DZEBCr6gQdRH2dUKnHDTWK3kJyHePYYwXMd 8gKlHjdsZ26gCY4wieLh8B5FzXN/qNQg1wHFrQ0GWe3qX7B5O2cOpVF0DpGUbwhfDz+P oqIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=w+9WBX8T8487sYdaCRBOXdftKEOOIGARUU12ptPCXoI=; b=K9513BZPNb4nXAB0ko0dKrCcFpszx2V+8YqoyCIsEXZApwGP4Cl/nywbRWfH41zBlY 7FwP56rAJ1p7FJnRr+14F6nbhxjGzKKAf2I+uw4SPQ+ZF7WFqwIkFcddUuCxEszVM/69 UqCwE6rjDAvoZPXa4WkhE+TwbmVLtQOfX6vlghdlMCmmll6HCyfLj+AbEjgpTqQ82uiu B2AaQn0dTo7SSUZyKGuvx+4lU3GWrQOJLFxPqihxyFCpfF5jhNHxKz5PYQdCSQsoDTR0 hj4cPRGl021oBVyBrF9ldv1MB1rEQrWDpdcBlLw6W6XGomcvAjIw7EANKFQGSBHDQEkZ fZdw== X-Gm-Message-State: APjAAAVQY7PlDTX2vJiZ/sShRfnNr2G2fzxJtrdBLzEDRL8z3O9UlPPB 7OMQbFyxywu4UiKNQmTOKgTSDQ== X-Google-Smtp-Source: APXvYqxyY0xjDcRn7kSUge9Pe/ZJykQdMkCOLrQxdDGvp71dWPGzFxihXcV4Py+Y8+/t7qRz+k6uxg== X-Received: by 2002:a1c:dcd5:: with SMTP id t204mr19453471wmg.34.1579534088409; Mon, 20 Jan 2020 07:28:08 -0800 (PST) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id d14sm51225920wru.9.2020.01.20.07.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 07:28:07 -0800 (PST) Date: Mon, 20 Jan 2020 15:28:04 +0000 From: Quentin Perret To: Dietmar Eggemann Subject: Re: [PATCH 1/4] PM / EM: and devices to Energy Model Message-ID: <20200120152804.GB164543@google.com> References: <20200116152032.11301-1-lukasz.luba@arm.com> <20200116152032.11301-2-lukasz.luba@arm.com> <17b77e0c-9455-0479-d37b-c57717c784c7@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <17b77e0c-9455-0479-d37b-c57717c784c7@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Mon, 20 Jan 2020 17:09:27 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, juri.lelli@redhat.com, daniel.lezcano@linaro.org, peterz@infradead.org, viresh.kumar@linaro.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, bsegall@google.com, alyssa.rosenzweig@collabora.com, Morten.Rasmussen@arm.com, amit.kucheria@verdurent.com, vincent.guittot@linaro.org, khilman@kernel.org, agross@kernel.org, b.zolnierkie@samsung.com, steven.price@arm.com, cw00.choi@samsung.com, mingo@redhat.com, linux-imx@nxp.com, rui.zhang@intel.com, mgorman@suse.de, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, s.hauer@pengutronix.de, rostedt@goodmis.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Chris.Redpath@arm.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, airlied@linux.ie, javi.merino@arm.com, tomeu.vizoso@collabora.com, sboyd@kernel.org, shawnguo@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, kernel@pengutronix.de, sudeep.holla@arm.com, patrick.bellasi@matbug.net, ionela.voinescu@arm.com, lukasz.luba@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Monday 20 Jan 2020 at 15:53:35 (+0100), Dietmar Eggemann wrote: > Would be really nice if this wouldn't be required. We should really aim > for 1 framework == 1 set of interfaces. > > What happens if someone calls em_get_pd() on a CPU EM? > > E.g: > > static struct perf_domain *pd_init(int cpu) > { > - struct em_perf_domain *obj = em_cpu_get(cpu); > + struct device *dev = get_cpu_device(cpu); > + struct em_perf_domain *obj = em_pd_get(dev); > struct perf_domain *pd; > > Two versions of one functionality will confuse API user from the > beginning ... Agreed, this looks a bit confusing. It should be trivial to make em_dev_get() (or whatever we end up calling it) work for CPUs too, though. And we could always have a em_cpu_get(int cpu) API that is a basically a wrapper around em_dev_get() for convenience. Thanks, Quentin _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel