From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: Fwd: [martineau:kbuild-mptcp 22/38] subflow.c:undefined reference to `__crypto_memneq'
Date: Mon, 20 Jan 2020 17:20:41 +0100 [thread overview]
Message-ID: <20200120162041.GD795@breakpoint.cc> (raw)
In-Reply-To: 48a83812-3670-ed88-7a75-7ea0a1c86438@tessares.net
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> > > I prefer selecting CRYPTO over copy/paste.
> >
> > I agree with 'select CRYPTO=y'
>
> Me too.
>
> Florian: do you ask the question because you think we can have issues or
> comments from net maintainers when forcing the selection of CRYPTO for
> MPTCP?
I think its fine, tcpmd5 and ipsec select it too.
> Do we plan to do this modification in "mptcp: Add handling of incoming
> MP_JOIN requests" commit (part 3) or before (part 2, when starting using
> functions from CRYPTO, e.g. "mptcp: Add key generation and token tree")?
I'm currently travelling so I can't comment which commit makes the most
sense. It should be added when the first crypto functions are used, I
think.
next reply other threads:[~2020-01-20 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 16:20 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-20 21:44 [MPTCP] Re: Fwd: [martineau:kbuild-mptcp 22/38] subflow.c:undefined reference to `__crypto_memneq' Matthieu Baerts
2020-01-20 9:49 Matthieu Baerts
2020-01-19 14:07 Paolo Abeni
2020-01-18 0:27 Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120162041.GD795@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.